{"id":16124,"url":"https://patchwork.libcamera.org/api/1.1/patches/16124/?format=json","web_url":"https://patchwork.libcamera.org/patch/16124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","date":"2022-05-30T23:00:45","name":"[libcamera-devel] libcamera: Fix incorrect toString() to operator<<() conversions","commit_ref":"2094ac4f8cf7c437d4ce8e35eef749f24f6f551e","pull_url":null,"state":"accepted","archived":false,"hash":"127a2b3639b2e2025a5faacc60710c96945b3e5e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16124/mbox/","series":[{"id":3150,"url":"https://patchwork.libcamera.org/api/1.1/series/3150/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3150","date":"2022-05-30T23:00:45","name":"[libcamera-devel] libcamera: Fix incorrect toString() to operator<<() conversions","version":1,"mbox":"https://patchwork.libcamera.org/series/3150/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16124/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16124/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 357D1BD161\n\tfor ;\n\tMon, 30 May 2022 23:00:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DA4465633;\n\tTue, 31 May 2022 01:00:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E07E160415\n\tfor ;\n\tTue, 31 May 2022 01:00:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lmontsouris-659-1-41-236.w92-154.abo.wanadoo.fr [92.154.76.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B8D06DF\n\tfor ;\n\tTue, 31 May 2022 01:00:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653951654;\n\tbh=b+/yAQScyyAMX8DeFdGmt2lAVjwfgNZNlQl0H8XbWRw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=WX1yy/ARTm8twYj4twhMbaCYEOFAFdVfkPeLa1gIdCJwyNYHvo6gJZ+p7aBbi5S1P\n\t7UUhot5NK6BHkGv9yGkPo1iyDStg53JPiP/2s3g6BHk/70N9xP+8UaqgfkOZLXIfjh\n\tT0bnY/FYwC+8XHDUI9oOv01ydatTUDSXPmSpsQ1mjHjQWB5R7RpeqKIdl7Gr5ToR4v\n\tfQ5AaqSMtTekVfxC9hXJpW5UKd8b1YhtpEQTwFtgLxC3opz76gJnZwD7irdvFHcWW8\n\tEC2MTzFr3DfE80dysZvoOT25DBZqlF7R51IFqBBI8PT0q38WIkXrW2rGWq6UMNb4/Z\n\tX34NutxViY+nw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653951651;\n\tbh=b+/yAQScyyAMX8DeFdGmt2lAVjwfgNZNlQl0H8XbWRw=;\n\th=From:To:Subject:Date:From;\n\tb=XigQ6rhx6hTxywutiZ5VZssAU9J5TNGfw69uoCWKZLm/7JkktpCIobFCJZkzcFpj7\n\tEKIkpYlrxbrHyxdevD3MIKO7aKXMHWb8DWwoJkrhZJR8KmVhwEn5I5TCKTa33VW0to\n\takzeZMKj+MaodiM2+MsZJNZQm5ZU9gU8Aus55hhM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XigQ6rhx\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 31 May 2022 02:00:45 +0300","Message-Id":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Fix incorrect toString() to\n\toperator<<() conversions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Commit 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for\nformat classes\") incorrectly converted some of the toString() usages,\nresulting in pointer values being printed instead of formats. Fix it.\n\nFixes: 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for format classes\")\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n src/libcamera/pipeline/ipu3/imgu.cpp | 4 ++--\n src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\n\nbase-commit: e115a691353151b3136581ac7f49cab6a3b0eb9a","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex a4e4d302f841..08e254f75eee 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -211,7 +211,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n \tif (ret)\n \t\treturn ret;\n \n-\tLOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat;\n+\tLOG(IPU3, Debug) << \"CIO2 output format \" << *outputFormat;\n \n \treturn 0;\n }\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 34613feb8130..59305f85073c 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -479,7 +479,7 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n \tif (ret)\n \t\treturn ret;\n \n-\tLOG(IPU3, Debug) << \"ImgU input format = \" << inputFormat;\n+\tLOG(IPU3, Debug) << \"ImgU input format = \" << *inputFormat;\n \n \t/*\n \t * \\todo The IPU3 driver implementation shall be changed to use the\n@@ -568,7 +568,7 @@ int ImgUDevice::configureVideoDevice(V4L2VideoDevice *dev, unsigned int pad,\n \n \tconst char *name = dev == output_.get() ? \"output\" : \"viewfinder\";\n \tLOG(IPU3, Debug) << \"ImgU \" << name << \" format = \"\n-\t\t\t << outputFormat;\n+\t\t\t << *outputFormat;\n \n \treturn 0;\n }\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 76bd228b5aba..de75465eb3b5 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -610,7 +610,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n \t\t\t\t\t<< \" produces \" << sourceFormat\n \t\t\t\t\t<< \", sink '\" << sink->entity()->name()\n \t\t\t\t\t<< \"':\" << sink->index()\n-\t\t\t\t\t<< \" requires \" << format;\n+\t\t\t\t\t<< \" requires \" << *format;\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \t\t}\n@@ -620,7 +620,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n \t\t\t<< \"':\" << source->index()\n \t\t\t<< \" -> '\" << sink->entity()->name()\n \t\t\t<< \"':\" << sink->index()\n-\t\t\t<< \" configured with format \" << format;\n+\t\t\t<< \" configured with format \" << *format;\n \t}\n \n \treturn 0;\n","prefixes":["libcamera-devel"]}