{"id":16085,"url":"https://patchwork.libcamera.org/api/1.1/patches/16085/?format=json","web_url":"https://patchwork.libcamera.org/patch/16085/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527144447.94891-15-tomi.valkeinen@ideasonboard.com>","date":"2022-05-27T14:44:31","name":"[libcamera-devel,v3,14/30] py: Rename 'efd' to 'event_fd'","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"68887bed68a4a80e77f19cf4be9f934ca38c6c27","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16085/mbox/","series":[{"id":3146,"url":"https://patchwork.libcamera.org/api/1.1/series/3146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3146","date":"2022-05-27T14:44:17","name":"More misc Python patches","version":3,"mbox":"https://patchwork.libcamera.org/series/3146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16085/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16085/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A12FC326E\n\tfor ;\n\tFri, 27 May 2022 14:45:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3A656569D;\n\tFri, 27 May 2022 16:45:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2ECC65633\n\tfor ;\n\tFri, 27 May 2022 16:45:11 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 306BF1BCB;\n\tFri, 27 May 2022 16:45:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662726;\n\tbh=toxqdvjDi4gk1YUfvMhAi3fdnpw79VdIr0qdXJMmdUs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rBbenwRz00L1p47UI23xJCgUcfVm/RPW8twJKhO5apfC329JrnEYA4eGXi1Qc7ord\n\tmpxqkmrc+HyBC/7lRqFV/zoWyi2WVAKJP3lDzJbx/9vVc5U84pVkQAbVgHyquoOzti\n\tcGaMwf9hy1E4hAUzAB9rfRRKKCncBMWPG93/OZkmKR7VnKeb9eCWIazLzlZvYmapUe\n\t1Yp7heheh2RC1Yr1R9SQEXma2u09KIHMlnq4A7aLRaNf3cE/piY9/vERX+6jAubak4\n\tcXAIPAyR4aMcFF3N7D7RSlUZmUfZWnQ50Bfn4y9rxYUdKEO1ekvcGK+p07PjbfPiLx\n\tuGsrk1jHPor1g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662711;\n\tbh=toxqdvjDi4gk1YUfvMhAi3fdnpw79VdIr0qdXJMmdUs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZfYb17pfkg6O33L/zEAszaKTkmPPt1zCDmuTs1NV/XipYeIjAiV4zyp6BHOpO3AfN\n\tVaql2Aq1P4Z/+h1N3voRVxDLhgJ5hzKzmKU5FeAqT7BOz+NXUmYDTzZgBswt1VQFub\n\tiDp7O3QKguUF/eLto/ck9QaEFVYVVYjMkhpexLGs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZfYb17pf\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Fri, 27 May 2022 17:44:31 +0300","Message-Id":"<20220527144447.94891-15-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 14/30] py: Rename 'efd' to 'event_fd'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Perhaps it's better to have a more descriptive name here. I also\nconsidered just renaming 'efd' to 'fd', but 'event_fd' won.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n src/py/cam/cam_kms.py | 2 +-\n src/py/cam/cam_null.py | 2 +-\n src/py/cam/cam_qt.py | 2 +-\n src/py/cam/cam_qtgl.py | 2 +-\n src/py/libcamera/py_main.cpp | 2 +-\n test/py/unittests.py | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex 213e0b03..49b00211 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -161,7 +161,7 @@ class KMSRenderer:\n \n sel = selectors.DefaultSelector()\n sel.register(self.card.fd, selectors.EVENT_READ, self.readdrm)\n- sel.register(self.cm.efd, selectors.EVENT_READ, self.readcam)\n+ sel.register(self.cm.event_fd, selectors.EVENT_READ, self.readcam)\n sel.register(sys.stdin, selectors.EVENT_READ, self.readkey)\n \n print('Press enter to exit')\ndiff --git a/src/py/cam/cam_null.py b/src/py/cam/cam_null.py\nindex 45c5f467..40dbd266 100644\n--- a/src/py/cam/cam_null.py\n+++ b/src/py/cam/cam_null.py\n@@ -23,7 +23,7 @@ class NullRenderer:\n self.running = True\n \n sel = selectors.DefaultSelector()\n- sel.register(self.cm.efd, selectors.EVENT_READ, self.readcam)\n+ sel.register(self.cm.event_fd, selectors.EVENT_READ, self.readcam)\n sel.register(sys.stdin, selectors.EVENT_READ, self.readkey)\n \n print('Press enter to exit')\ndiff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\nindex e2395c4b..c294c999 100644\n--- a/src/py/cam/cam_qt.py\n+++ b/src/py/cam/cam_qt.py\n@@ -193,7 +193,7 @@ class QtRenderer:\n self.windows = windows\n \n def run(self):\n- camnotif = QtCore.QSocketNotifier(self.cm.efd, QtCore.QSocketNotifier.Read)\n+ camnotif = QtCore.QSocketNotifier(self.cm.event_fd, QtCore.QSocketNotifier.Read)\n camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\ndiff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\nindex 5f7ccf1e..4b43f51d 100644\n--- a/src/py/cam/cam_qtgl.py\n+++ b/src/py/cam/cam_qtgl.py\n@@ -142,7 +142,7 @@ class QtRenderer:\n self.window = window\n \n def run(self):\n- camnotif = QtCore.QSocketNotifier(self.state.cm.efd, QtCore.QSocketNotifier.Read)\n+ camnotif = QtCore.QSocketNotifier(self.state.cm.event_fd, QtCore.QSocketNotifier.Read)\n camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 4fb66866..f903f1d2 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -205,7 +205,7 @@ PYBIND11_MODULE(_libcamera, m)\n \n \t\t.def_property_readonly(\"version\", &CameraManager::version)\n \n-\t\t.def_property_readonly(\"efd\", [](CameraManager &) {\n+\t\t.def_property_readonly(\"event_fd\", [](CameraManager &) {\n \t\t\treturn gEventfd;\n \t\t})\n \ndiff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 8c445bc9..426efb06 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -269,7 +269,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n gc.collect()\n \n sel = selectors.DefaultSelector()\n- sel.register(cm.efd, selectors.EVENT_READ)\n+ sel.register(cm.event_fd, selectors.EVENT_READ)\n \n reqs = []\n \n","prefixes":["libcamera-devel","v3","14/30"]}