{"id":16079,"url":"https://patchwork.libcamera.org/api/1.1/patches/16079/?format=json","web_url":"https://patchwork.libcamera.org/patch/16079/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527144447.94891-9-tomi.valkeinen@ideasonboard.com>","date":"2022-05-27T14:44:25","name":"[libcamera-devel,v3,08/30] py: MappedFrameBuffer: Add type hints & docs","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7d3a7900cf361a1c61b5d2c3198e29db8da19608","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16079/mbox/","series":[{"id":3146,"url":"https://patchwork.libcamera.org/api/1.1/series/3146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3146","date":"2022-05-27T14:44:17","name":"More misc Python patches","version":3,"mbox":"https://patchwork.libcamera.org/series/3146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16079/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16079/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CAFABD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 777B865657;\n\tFri, 27 May 2022 16:45:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5B91633A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:08 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19815EF2;\n\tFri, 27 May 2022 16:45:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662716;\n\tbh=O1E83xEQOu12v5ZIMjQFl7+ZKcLZq6RJVyYUYyL7Wyo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=eqIyXm8DtW+QJVuYWrdtNZ/TkRFCll5B+LngZ6yai/L/DT4NkxIn3HVnmOJ77pkhF\n\tDFWI5zgm44KzVaj9BbRud4QkInYSowKgAJxwOsgIeRz4tuEMZjBlnezPnJIWpdRmVM\n\tSX3UsV7yKLbhZv+TqtwlpudPnhabNTjlXFK+LKR4ZDyeaYBCOwUQjipwUKEhEq+xI3\n\tGUSVIIkw1bIdrtLvn14kI5OKPvr4L1swxKnx+pebZQsPQQfF0HKZSE+K12KqciKuzk\n\tmWdqq8NDXP66IuoxjQ/fxVvavgG5UzdqrPFMRA03efkPO2WNCQXPoSMPhTvFlN7OYN\n\tmsAkharm873ag==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662708;\n\tbh=O1E83xEQOu12v5ZIMjQFl7+ZKcLZq6RJVyYUYyL7Wyo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o6lzaJB7AgaGEc7/O6MXE8FKGOPYufZP6ustVbvgm1cxizACoxe24WrI2GURBVU6b\n\toFxN+OUioY0Q55jHVr2JeHTJ6tA3tuOi01C/b83pvt4pC9Gs0ANoGwf2mfVK8UHEwH\n\tNf7ifxQtpSU+NqFjjZv6SGgTiAE68wSS9bwximE0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o6lzaJB7\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>","Date":"Fri, 27 May 2022 17:44:25 +0300","Message-Id":"<20220527144447.94891-9-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 08/30] py: MappedFrameBuffer: Add type\n\thints & docs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a few type hints and (minimal) docs to MappedFrameBuffer.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/utils/MappedFrameBuffer.py | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/src/py/libcamera/utils/MappedFrameBuffer.py b/src/py/libcamera/utils/MappedFrameBuffer.py\nindex e7dd16ec..fc2726b6 100644\n--- a/src/py/libcamera/utils/MappedFrameBuffer.py\n+++ b/src/py/libcamera/utils/MappedFrameBuffer.py\n@@ -1,8 +1,14 @@\n # SPDX-License-Identifier: LGPL-2.1-or-later\n # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n \n+import libcamera\n+from typing import Tuple\n+\n class MappedFrameBuffer:\n-    def __init__(self, fb):\n+    \"\"\"\n+    Provides memoryviews for the FrameBuffer's planes\n+    \"\"\"\n+    def __init__(self, fb: libcamera.FrameBuffer):\n         self.__fb = fb\n \n     def __enter__(self):\n@@ -70,5 +76,6 @@ class MappedFrameBuffer:\n             mm.close()\n \n     @property\n-    def planes(self):\n+    def planes(self) -> Tuple[memoryview, ...]:\n+        \"\"\"memoryviews for the planes\"\"\"\n         return self.__planes\n","prefixes":["libcamera-devel","v3","08/30"]}