{"id":16070,"url":"https://patchwork.libcamera.org/api/1.1/patches/16070/?format=json","web_url":"https://patchwork.libcamera.org/patch/16070/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527093440.953377-6-paul.elder@ideasonboard.com>","date":"2022-05-27T09:34:40","name":"[libcamera-devel,v2,5/5] android: camera_device: Print the correct number of completed streams","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f372720061e2d761352348779023b364428dbae9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16070/mbox/","series":[{"id":3145,"url":"https://patchwork.libcamera.org/api/1.1/series/3145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3145","date":"2022-05-27T09:34:35","name":"Plumb the YUV processor in","version":2,"mbox":"https://patchwork.libcamera.org/series/3145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16070/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16070/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D38EEBD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 09:35:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B47265634;\n\tFri, 27 May 2022 11:35:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6385A65637\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 11:35:01 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EE4532A;\n\tFri, 27 May 2022 11:34:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653644104;\n\tbh=0BZicPyxMBeyivBumWFrMPChHa1PrWSpE0d1yA43m5M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YMC+fhMMD5pM3nLLwqc4m7H/LME8mqbobTXWO5D6ddRKlHCvLdXwwG+Q6gfkn+DGM\n\tv8amjSmoK7QxygrEtQWf7hPv5zugL7REtskLqPWLaHOcO6UicYGATFZEEgDUqsP54/\n\tu4+eBZDX2q4GnjkAIJhOHSJ/9QMZHnsUc7Hppv9+AOReY6GpRqIgVc0mxdE0nSkKCx\n\tCpH1MlSFuc/pRW41BuodCcOL7TihPkmfiRt8gPxg9ncVbMMa2ZtCiwV3ep+rVAnqQ+\n\tFpufqxRWuP/pQzx+vi1CBirIYSzaaDivrY0a3tjEHNDJLn08au9hC3mXTqwF8+ySoC\n\txbIcsxbDQMoeg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653644101;\n\tbh=0BZicPyxMBeyivBumWFrMPChHa1PrWSpE0d1yA43m5M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FnlRa58HoAUMzq44I6VbC5zp9OUfCowYFz6TYrYIsD/7cXD4ZKHXrTxdsCdTwaMpa\n\tYfHa84WPRLPgrGarQYOG/za/Vnr8koezPs2X7W1nweRk1MREy1KOSBXVVxgkH7nf1/\n\tYluGGUMuoI7bjd5fY+R0eGB0D8gFHOYh2bF6B1pU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FnlRa58H\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 27 May 2022 18:34:40 +0900","Message-Id":"<20220527093440.953377-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20220527093440.953377-1-paul.elder@ideasonboard.com>","References":"<20220527093440.953377-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] android: camera_device: Print the\n\tcorrect number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Paul Elder <paul.elder@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"From: Jacopo Mondi <jacopo@jmondi.org>\n\nWhen a request completes, a debug message is generated to help\nidentify the request and the number of streams it contains.\n\nThe printed number of streams is however the number of output buffers\nrequested by the camera framework, not the number of streams generated\nby libcamera. In facts, some output buffers are generated by\npost-processing, and not directly from the camera.\n\nAs the debug message prints the libcamera identifier for the Request, it\nis more logical to print the number of streams generated by the camera\ninstead of the total number of streams.\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- fix typo in commit message\n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 9ee34b93..dfff8ec4 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1194,7 +1194,7 @@ void CameraDevice::requestComplete(Request *request)\n \tnotifyShutter(descriptor->frameNumber_, sensorTimestamp);\n \n \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n-\t\t\t<< descriptor->buffers_.size() << \" streams\";\n+\t\t\t<< descriptor->request_->buffers().size() << \" streams\";\n \n \t/*\n \t * Generate the metadata associated with the captured buffers.\n","prefixes":["libcamera-devel","v2","5/5"]}