{"id":16067,"url":"https://patchwork.libcamera.org/api/1.1/patches/16067/?format=json","web_url":"https://patchwork.libcamera.org/patch/16067/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527093440.953377-3-paul.elder@ideasonboard.com>","date":"2022-05-27T09:34:37","name":"[libcamera-devel,v2,2/5] android: camera_stream: Create allocator unconditionally","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2a3748e96013b2eba72b650220191e0bfeba1133","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16067/mbox/","series":[{"id":3145,"url":"https://patchwork.libcamera.org/api/1.1/series/3145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3145","date":"2022-05-27T09:34:35","name":"Plumb the YUV processor in","version":2,"mbox":"https://patchwork.libcamera.org/series/3145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16067/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16067/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBD86BD161\n\tfor ;\n\tFri, 27 May 2022 09:34:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71C0865632;\n\tFri, 27 May 2022 11:34:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0848D60415\n\tfor ;\n\tFri, 27 May 2022 11:34:55 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A489632A;\n\tFri, 27 May 2022 11:34:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653644098;\n\tbh=ULliZzK0z4aEUbrgLmQxpYAzNul4FcvsIHrG/SSsrkA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=JbLh8dDZfI/YBe23ut+j5Jr678Iw3WSAwpxiQdYICVRhciXqout1o60xtghpGDno5\n\t0xx+7aMLsJjWaWBlZqmiJoQ4sWofOwaxBs72XbwefTxjS5fCxuvWrgeCpL9JD0zvpD\n\txHwaPgkvPD66deEFlwjaO0lQ962CJIjAn7n6wXDAad8GwZ+d16Yoeqwy/oiwwfjl4Z\n\tXjwnVW2ag5RLuL3doj3OW2E5/xBn57Mdy+FeBKN2Hn3FhhZFWQg/mdELLAXA3ui6YA\n\tMIPL70hpW/foBgdsGODhApPstUx+4PFWyi02Cr9YFRLB0gXfCUj+I2lbLWd83S4ymv\n\tnMxIVEK2x14nQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653644094;\n\tbh=ULliZzK0z4aEUbrgLmQxpYAzNul4FcvsIHrG/SSsrkA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=imdz+dB327Xq9is2baKdIH49f8jrHkJGvQs9y0rWOgbQlHt/OGl/u4NtVROgFuo90\n\tjZou7VGfGzSe5W1QLQkQ/tSR+tf4cOwZHitDqQRyqxfBpU4k7tu+Yfx/nnmdA+PzV5\n\thTtuI7KFm2oVvVTwlJ9OeSYLpRWDDLhKvfqwd7Sc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"imdz+dB3\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 27 May 2022 18:34:37 +0900","Message-Id":"<20220527093440.953377-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20220527093440.953377-1-paul.elder@ideasonboard.com>","References":"<20220527093440.953377-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/5] android: camera_stream: Create\n\tallocator unconditionally","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nWith the introduction of PlatformBufferAllocator all CameraStream can\nbe used to allocate buffers on-demand.\n\nCreate CameraStream::allocator_ and the associated mutex for all types\nof stream.\n\nSigned-off-by: Jacopo Mondi \n\n---\nNo change in v2\n\nIf we want to make CameraStream::mutex_ into non-pointer (as Hiro\nsuggested), it should be done on top. Do we want to do that? (I suppose\nit doesn't affect this patch itself)\n---\n src/android/camera_stream.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 154e088e..045e6006 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -128,10 +128,8 @@ int CameraStream::configure()\n \t\tworker_->start();\n \t}\n \n-\tif (type_ == Type::Internal) {\n-\t\tallocator_ = std::make_unique(cameraDevice_);\n-\t\tmutex_ = std::make_unique();\n-\t}\n+\tallocator_ = std::make_unique(cameraDevice_);\n+\tmutex_ = std::make_unique();\n \n \tcamera3Stream_->max_buffers = configuration().bufferCount;\n \n","prefixes":["libcamera-devel","v2","2/5"]}