{"id":16037,"url":"https://patchwork.libcamera.org/api/1.1/patches/16037/?format=json","web_url":"https://patchwork.libcamera.org/patch/16037/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220524225816.6830-12-laurent.pinchart@ideasonboard.com>","date":"2022-05-24T22:58:15","name":"[libcamera-devel,RFC,11/12] ipa: raspberrypi: Replace tabs with spaces in tuning data files","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e5ea42059c8f912924c244a2825de92aad5d9d91","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16037/mbox/","series":[{"id":3135,"url":"https://patchwork.libcamera.org/api/1.1/series/3135/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3135","date":"2022-05-24T22:58:04","name":"Replace boost JSON parser with libyaml in Raspberry Pi IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/3135/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16037/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16037/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC7C4C3270\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 22:58:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C59865673;\n\tWed, 25 May 2022 00:58:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3465665675\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 May 2022 00:58:31 +0200 (CEST)","from pendragon.ideasonboard.com (ip-109-40-241-133.web.vodafone.de\n\t[109.40.241.133])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F1C49DA;\n\tWed, 25 May 2022 00:58:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653433120;\n\tbh=Glf9pjjGnzIfbfULE+Zq+A8HaL9XSI9VV/ERWec7nYo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tS96R0zcrU+6quhbBKE3fBJ0XkTPPQWl7Tkr60vD303h92D1ZSIQe36LfcheCEOuA\n\tFzZuuweDCNr5tHR2tncytersfMISMEbjmXfT66H6FAmaH4bl45wFRUSRYTTNSG5iFK\n\tx+1GZlfs9J2ZHievib3qPQCuv4g/GqkIAKaoEoZ26EOebNAfogSVCnmydw/6I7ly5I\n\tcOqoRSTqrPX0R4DADioqlXhk6bVQ+jrypxlgjnx+IsrGoxHJomFu35oVENxwvojeWS\n\trpI3hAoJXLr2/WSz9tSbRVBcC/8LFsVz+OVe/JX0M22PTGkV07yD5Z3GXt7KWy5Bw8\n\txnwkVYkBZELog==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653433110;\n\tbh=Glf9pjjGnzIfbfULE+Zq+A8HaL9XSI9VV/ERWec7nYo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TBbmiWmX1zUXtXdEKT+Weh04bSWxs5RaRe/BWkJm4vyg/FSbVb9VYAO3I2fr7jYG9\n\t77S4W3Z01vrIQfMiy28EnfLhOdIgKNr+m5j7CFtJ77ASWWTP22XCmzOSoA2vWnIP9w\n\t4x6o1JxI31dHomHuAMvCZaN3IyMesG8MhGrzCtsY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TBbmiWmX\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 25 May 2022 01:58:15 +0300","Message-Id":"<20220524225816.6830-12-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>","References":"<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 11/12] ipa: raspberrypi: Replace tabs\n\twith spaces in tuning data files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Tuning data files mostly use spaces for indentation, with occasional\nstray tabs. Use spaces consistently. This allows parsing the tuning\nfiles with libyaml, preparing to replace the dependency on boost.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/data/imx219.json      |  8 ++++----\n src/ipa/raspberrypi/data/imx219_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/imx290.json      | 18 +++++++++---------\n src/ipa/raspberrypi/data/imx477.json      |  8 ++++----\n src/ipa/raspberrypi/data/imx477_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647.json      | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647_noir.json | 12 ++++++------\n src/ipa/raspberrypi/data/se327m12.json    |  6 +++---\n 8 files changed, 41 insertions(+), 41 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex de59d9363be4..4e24c5d57da1 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -189,10 +189,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\ndiff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json\nindex 9a3f03ec86f4..1835ec3df63b 100644\n--- a/src/ipa/raspberrypi/data/imx219_noir.json\n+++ b/src/ipa/raspberrypi/data/imx219_noir.json\n@@ -31,7 +31,7 @@\n     },\n     \"rpi.awb\":\n     {\n-\t\"bayes\": 0\n+        \"bayes\": 0\n     },\n     \"rpi.agc\":\n     {\n@@ -121,10 +121,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\ndiff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json\nindex 20b45c1684c2..1363bab71340 100644\n--- a/src/ipa/raspberrypi/data/imx290.json\n+++ b/src/ipa/raspberrypi/data/imx290.json\n@@ -29,11 +29,11 @@\n     },\n     \"rpi.awb\":\n     {\n-\t\"bayes\": 0\n+        \"bayes\": 0\n     },\n     \"rpi.agc\":\n     {\n-\t\"speed\": 0.2,\n+        \"speed\": 0.2,\n         \"metering_modes\":\n         {\n             \"matrix\":\n@@ -150,14 +150,14 @@\n     \"rpi.ccm\":\n     {\n         \"ccms\":\n-\t[\n+        [\n             {\n-\t\t\"ct\": 3900, \"ccm\":\n-\t\t[\n-\t\t    1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n-\t\t]\n-\t    }\n-\t]\n+                \"ct\": 3900, \"ccm\":\n+                [\n+                    1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n+                ]\n+            }\n+        ]\n     },\n     \"rpi.focus\":\n     {\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex d07febd283ed..0f389661c246 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -189,10 +189,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\ndiff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json\nindex 7d4fc7dab9fd..a379d780d966 100644\n--- a/src/ipa/raspberrypi/data/imx477_noir.json\n+++ b/src/ipa/raspberrypi/data/imx477_noir.json\n@@ -31,7 +31,7 @@\n     },\n     \"rpi.awb\":\n     {\n-\t\"bayes\": 0\n+        \"bayes\": 0\n     },\n     \"rpi.agc\":\n     {\n@@ -121,10 +121,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex 24bc06fb6114..e65f9385d970 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -189,10 +189,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\n@@ -203,7 +203,7 @@\n         [\n             0, 0.16, 1000, 0.165, 10000, 0.17\n         ],\n-\t\"base_ev\": 1.25\n+        \"base_ev\": 1.25\n     },\n     \"rpi.alsc\":\n     {\ndiff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json\nindex 1c628ed13f19..dad73a5e8cd9 100644\n--- a/src/ipa/raspberrypi/data/ov5647_noir.json\n+++ b/src/ipa/raspberrypi/data/ov5647_noir.json\n@@ -31,7 +31,7 @@\n     },\n     \"rpi.awb\":\n     {\n-\t\"bayes\": 0\n+        \"bayes\": 0\n     },\n     \"rpi.agc\":\n     {\n@@ -121,10 +121,10 @@\n                     ]\n                 }\n             ],\n-\t    \"shadows\":\n-\t    [\n-\t\t{\n-\t\t    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+            \"shadows\":\n+            [\n+                {\n+                    \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n                     [\n                         0, 0.17, 1000, 0.17\n                     ]\n@@ -135,7 +135,7 @@\n         [\n             0, 0.16, 1000, 0.165, 10000, 0.17\n         ],\n-\t\"base_ev\": 1.25\n+        \"base_ev\": 1.25\n     },\n     \"rpi.alsc\":\n     {\ndiff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json\nindex 94af2239f700..5b1ac2ce3bf8 100644\n--- a/src/ipa/raspberrypi/data/se327m12.json\n+++ b/src/ipa/raspberrypi/data/se327m12.json\n@@ -334,8 +334,8 @@\n     },\n     \"rpi.sharpen\":\n     {\n-\t\"threshold\": 2.0,\n-\t\"strength\": 0.5,\n-\t\"limit\": 0.5\n+        \"threshold\": 2.0,\n+        \"strength\": 0.5,\n+        \"limit\": 0.5\n     }\n }\n","prefixes":["libcamera-devel","RFC","11/12"]}