{"id":16033,"url":"https://patchwork.libcamera.org/api/1.1/patches/16033/?format=json","web_url":"https://patchwork.libcamera.org/patch/16033/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220524225816.6830-8-laurent.pinchart@ideasonboard.com>","date":"2022-05-24T22:58:11","name":"[libcamera-devel,RFC,07/12] android: Use the YamlObject iterator API","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"58bb05a9959a9a2cb366acb133b71e06cd8fea75","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16033/mbox/","series":[{"id":3135,"url":"https://patchwork.libcamera.org/api/1.1/series/3135/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3135","date":"2022-05-24T22:58:04","name":"Replace boost JSON parser with libyaml in Raspberry Pi IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/3135/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16033/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16033/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FF3CC326E\n\tfor ;\n\tTue, 24 May 2022 22:58:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0173165676;\n\tWed, 25 May 2022 00:58:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B89ED65663\n\tfor ;\n\tWed, 25 May 2022 00:58:28 +0200 (CEST)","from pendragon.ideasonboard.com (ip-109-40-241-133.web.vodafone.de\n\t[109.40.241.133])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23F8F1245;\n\tWed, 25 May 2022 00:58:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653433115;\n\tbh=+B+P8nN4wN36md/i6eEoSbd3s0PvS4G8/FkDKBz6VlY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dk7DwgOWbPExkI7ELOZ6iBVG1QN0wHnzG+Y8/HlHPrw6FmRugEVcVC+3rv3lRHoSs\n\tdWH4w7eKTbppKr0a36Sb0C2aV34/uV/3lvDg4Myl7Sp8qiRlayvvxaxiso1bKJslo/\n\tTvZ3UaYITqb/2Wwu+VSmizPO88JRvoozG2jlPbTqP8qq+o75dB5IQsxLp0xrhAME6w\n\tybTAMxwAGYmHXakc3KI0XXfMLof72SBFRQAb9qEgvTAIwuFHcIWhCKFEe+ra5fNIvX\n\t7J80FqF8IFK/5axt5hcFD2RN1lrqcpbAALev60KVSyA4HvIRlvAza9dhXrTv0p+g9s\n\ty9yqHWK2heOLw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653433108;\n\tbh=+B+P8nN4wN36md/i6eEoSbd3s0PvS4G8/FkDKBz6VlY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kBBEXskE0Rm8jZCqMjP0Pkv7kCf2mYMXib+fMHJ9pqoqcjhMxwdcE0rQ+jBliMHcg\n\tcpscLQu1So22Ji57H+RZDU7XIr1DlRBtfJkzZ1Mv348J0CM00zFyVKuBBROIkDEn4P\n\tj0nw0eeM+WqKcJlB22L1QJvFyfPPSgSKCa9KdYcU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kBBEXskE\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 25 May 2022 01:58:11 +0300","Message-Id":"<20220524225816.6830-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>","References":"<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 07/12] android: Use the YamlObject\n\titerator API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace usage of YamlObject::memberNames() with the more efficient\niterator API.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_config.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 42f3e3aeed04..723860db2371 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -82,10 +82,8 @@ int CameraHalConfig::Private::parseConfigFile(File &file,\n \tif (!yamlObjectCameras.isDictionary())\n \t\treturn -EINVAL;\n \n-\tstd::vector cameraIds = yamlObjectCameras.memberNames();\n-\tfor (const std::string &cameraId : cameraIds) {\n-\t\tif (parseCameraConfigData(cameraId,\n-\t\t\t\t\t yamlObjectCameras[cameraId]))\n+\tfor (const auto &[cameraId, configData] : yamlObjectCameras.asDict()) {\n+\t\tif (parseCameraConfigData(cameraId, configData))\n \t\t\treturn -EINVAL;\n \t}\n \n","prefixes":["libcamera-devel","RFC","07/12"]}