{"id":15986,"url":"https://patchwork.libcamera.org/api/1.1/patches/15986/?format=json","web_url":"https://patchwork.libcamera.org/patch/15986/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220519103347.33295-5-tomi.valkeinen@ideasonboard.com>","date":"2022-05-19T10:33:46","name":"[libcamera-devel,4/5] py: Fix SceneFlicker enum values","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"302e350a9c92f4bfa0cd6889ed787bcec334c477","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15986/mbox/","series":[{"id":3127,"url":"https://patchwork.libcamera.org/api/1.1/series/3127/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3127","date":"2022-05-19T10:33:42","name":"More misc Python patches","version":1,"mbox":"https://patchwork.libcamera.org/series/3127/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15986/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15986/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24C09C326D\n\tfor ;\n\tThu, 19 May 2022 10:34:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19DFB6566B;\n\tThu, 19 May 2022 12:34:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7612D60420\n\tfor ;\n\tThu, 19 May 2022 12:34:08 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E975410CC;\n\tThu, 19 May 2022 12:34:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652956452;\n\tbh=S/RVNlIlL/i+4loRKEAVUW+1XNEtUENfvOvlbekWDYg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Gsp2mVygVGiKtnI3FneVrQMRYGkR15WIj9GekcK/z0yaqMnoEPN9F2sXwK5X4NIws\n\tzyBqPrhfa2EV0tX4P/YJ9CkUEn3Rn30Di6sLiq9ZGTfPeI6sYI7z+CEbvbaqsrt9C+\n\tqEkwHIjw86pJbl3DlN0Dw0H+8huw4KD4ABgVnpf0n/dT9fqUeAhdUwK904eC0peVqg\n\tIhFm2NDZtj4uf8QGWu9KPcLIlsG6gZbzT69Ubw/xjckP3/lngF3DM1vOEdOgftCTs2\n\t6X0aa7N/m5ydjUh6pz+pv/lOxTkT4mJ7ff9yQO8sf62vZ9KfFTS+SwS19lDBxmf921\n\tZ0hv+3yB4XZLA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652956448;\n\tbh=S/RVNlIlL/i+4loRKEAVUW+1XNEtUENfvOvlbekWDYg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=P4x+HBgrXdSLHQgcv1nHegEnmJRFksVeIYjrFYdzFtJI/g2LaxpBOXVbT2GCx5C+O\n\taSrRj3F3/DOXVNQvvTqhqLK124+RrRGYj+qZhnkjHz+BX2+pYpfoL/NiDzK+G13YeT\n\t2AGTUBY3Qlrr+CxZyFEbV6G2Fed72HuIBRfyeMrg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"P4x+HBgr\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Thu, 19 May 2022 13:33:46 +0300","Message-Id":"<20220519103347.33295-5-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220519103347.33295-1-tomi.valkeinen@ideasonboard.com>","References":"<20220519103347.33295-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/5] py: Fix SceneFlicker enum values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Stripping 'SceneFlicker' prefix from the enum value names leads to\n'50Hz' and '60Hz', which are not valid names. So add another heuristics\nto keep the prefix for SceneFlicker.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/libcamera/gen-py-control-enums.py | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py\nindex dcc28b1a..6b2b5362 100755\n--- a/src/py/libcamera/gen-py-control-enums.py\n+++ b/src/py/libcamera/gen-py-control-enums.py\n@@ -42,6 +42,9 @@ def generate_py(controls):\n \n if name == 'LensShadingMapMode':\n prefix = 'LensShadingMapMode'\n+ elif name == 'SceneFlicker':\n+ # If we strip the prefix, we would get '50Hz', which is illegal name\n+ prefix = ''\n else:\n prefix = find_common_prefix([e['name'] for e in enum])\n \n","prefixes":["libcamera-devel","4/5"]}