{"id":15887,"url":"https://patchwork.libcamera.org/api/1.1/patches/15887/?format=json","web_url":"https://patchwork.libcamera.org/patch/15887/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220510115147.19360-48-laurent.pinchart@ideasonboard.com>","date":"2022-05-10T11:51:44","name":"[libcamera-devel,47/50] staging: media: imx: imx7-media-csi: Drop unneeded pixel format validation","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"13456cdfcf56cccf749ce3626cfe582d78317d2a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15887/mbox/","series":[{"id":3106,"url":"https://patchwork.libcamera.org/api/1.1/series/3106/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3106","date":"2022-05-10T11:50:57","name":"staging: media: imx: Prepare destaging of imx7-media-csi","version":1,"mbox":"https://patchwork.libcamera.org/series/3106/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15887/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15887/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9756CC0F2A\n\tfor ;\n\tTue, 10 May 2022 11:52:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39642656BE;\n\tTue, 10 May 2022 13:52:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29DD3656B7\n\tfor ;\n\tTue, 10 May 2022 13:52:37 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BF2EBA9;\n\tTue, 10 May 2022 13:52:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183566;\n\tbh=k83DkJluD69YCIeo/EtpffCkhSFp7txn436AUp0SJpM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZxOj1j4jWdo/Pdvy4ZNUKD/EOTy4yvqkZ8hCCz89JQ/d5L4yyoyW2iyAeV+u5GT22\n\tWtfvJvv1JcjPhRnMpCs9bHuweZcL6f8MeHmVtpZ8SGbTD63lsTk/eXEeW9YJXcPDw7\n\tdNqpvYRXr8HY41p0jvTw8RFXFTU506AgTYCFnZ7f/dYoh2fF3yIgSd9Tez3VJTaQ5O\n\tKarT5aPeKV7ZXKwhXVqZQc5r+ua/iB85m7yzgZRiBmWVcbft8aLncOyPViiAOXR/rn\n\tS5u1OJWp30+ARRwGbz7a18SYU2Tg+wONjAehjOZiFMyt1tnvAzA8ajI36zhuYpBawL\n\tgjKBhn6aE4Jhg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183556;\n\tbh=k83DkJluD69YCIeo/EtpffCkhSFp7txn436AUp0SJpM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PNEwPqdtqR8K1TgsuwDtYUX8bwK0cVMltqFu6A9GOGy94swCD6/BFmRfqX8FHwFZ0\n\tZtS7PvW/qTxw5Tss1r026aIn2+XmSc7YM4qTrxa7TSSW0Ci5/Yz2/T54a+gCbAGzfv\n\tsgBB2DveNdOLLGlevgM+lIVJyz3RnvkZGKOfIKz4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PNEwPqdt\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 10 May 2022 14:51:44 +0300","Message-Id":"<20220510115147.19360-48-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","References":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 47/50] staging: media: imx:\n\timx7-media-csi: Drop unneeded pixel format validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Martin Kepplinger , kernel@pengutronix.de,\n\tDorota Czaplejewicz ,\n\tAlexander Stein ,\n\tRui Miguel Silva ,\n\tPhilipp Zabel , \n\tSteve Longerbeam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The driver won't accept unsupported pixel formats, there's thus no need\nto validate it in imx7_csi_pad_link_validate().\n\nSigned-off-by: Laurent Pinchart \n---\n drivers/staging/media/imx/imx7-media-csi.c | 33 ----------------------\n 1 file changed, 33 deletions(-)","diff":"diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 4d8e3c0a3633..8be6f40588af 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1966,7 +1966,6 @@ static int imx7_csi_pad_link_validate(struct v4l2_subdev *sd,\n \t\t\t\t struct v4l2_subdev_format *sink_fmt)\n {\n \tstruct imx7_csi *csi = v4l2_get_subdevdata(sd);\n-\tconst struct v4l2_pix_format *out_pix = &csi->vdev_fmt;\n \tstruct media_pad *pad = NULL;\n \tunsigned int i;\n \tint ret;\n@@ -2016,38 +2015,6 @@ static int imx7_csi_pad_link_validate(struct v4l2_subdev *sd,\n \t\tbreak;\n \t}\n \n-\t/* Validate the sink link, ensure the pixel format is supported. */\n-\tswitch (out_pix->pixelformat) {\n-\tcase V4L2_PIX_FMT_UYVY:\n-\tcase V4L2_PIX_FMT_YUYV:\n-\tcase V4L2_PIX_FMT_GREY:\n-\tcase V4L2_PIX_FMT_Y10:\n-\tcase V4L2_PIX_FMT_Y12:\n-\tcase V4L2_PIX_FMT_Y14:\n-\tcase V4L2_PIX_FMT_SBGGR8:\n-\tcase V4L2_PIX_FMT_SGBRG8:\n-\tcase V4L2_PIX_FMT_SGRBG8:\n-\tcase V4L2_PIX_FMT_SRGGB8:\n-\tcase V4L2_PIX_FMT_SBGGR10:\n-\tcase V4L2_PIX_FMT_SGBRG10:\n-\tcase V4L2_PIX_FMT_SGRBG10:\n-\tcase V4L2_PIX_FMT_SRGGB10:\n-\tcase V4L2_PIX_FMT_SBGGR12:\n-\tcase V4L2_PIX_FMT_SGBRG12:\n-\tcase V4L2_PIX_FMT_SGRBG12:\n-\tcase V4L2_PIX_FMT_SRGGB12:\n-\tcase V4L2_PIX_FMT_SBGGR14:\n-\tcase V4L2_PIX_FMT_SGBRG14:\n-\tcase V4L2_PIX_FMT_SGRBG14:\n-\tcase V4L2_PIX_FMT_SRGGB14:\n-\t\tbreak;\n-\n-\tdefault:\n-\t\tdev_dbg(csi->dev, \"Invalid capture pixel format 0x%08x\\n\",\n-\t\t\tout_pix->pixelformat);\n-\t\treturn -EINVAL;\n-\t}\n-\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","47/50"]}