{"id":15860,"url":"https://patchwork.libcamera.org/api/1.1/patches/15860/?format=json","web_url":"https://patchwork.libcamera.org/patch/15860/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220510115147.19360-21-laurent.pinchart@ideasonboard.com>","date":"2022-05-10T11:51:17","name":"[libcamera-devel,20/50] staging: media: imx: imx7-media-csi: Drop imx_media_add_video_device call","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"2bc2ad9d1727f77c49e31de9b566f703e4a8748f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15860/mbox/","series":[{"id":3106,"url":"https://patchwork.libcamera.org/api/1.1/series/3106/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3106","date":"2022-05-10T11:50:57","name":"staging: media: imx: Prepare destaging of imx7-media-csi","version":1,"mbox":"https://patchwork.libcamera.org/series/3106/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15860/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15860/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAE3BC326F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 897096568B;\n\tTue, 10 May 2022 13:52:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 437E26567E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:14 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61A12DFF;\n\tTue, 10 May 2022 13:52:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183543;\n\tbh=gm/2LW6ZHCvoGWF4lJlzBcDie/aSGoep0fsUMokwzPE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OGQht47vvodgUcuhIGKmyFtE/XLRGGuOhFr+2jvPNjnaTN5yPIrKAV5dF5vr+Yl5u\n\t0yWKnoYyg/smI6GZqZ9nkx9QeCHLcMvRAhaUY4ex99zmZkBqHoRBBkNRwFa/yTKb1i\n\t1iyma+ivrAk7hPSLD8BFfPnonIMXrOSX4mcytUJ+bAbmgeWZpMF6MGSIxj+GVN8Sjh\n\t9xpG27ffN7NcNYsO0p0cPJZee9lH2B93dBT6nbDt0XadF+ySuVf/Hh5+u9V8WlrVcJ\n\tPw8lRTZKarb1PkID/kZlQoSHOqCTe0cNHWX8iP0Yh1NU3Izc0rj0fQGMJhbY285EDD\n\telnsKgftljbgA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183534;\n\tbh=gm/2LW6ZHCvoGWF4lJlzBcDie/aSGoep0fsUMokwzPE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fbU1gbP1ASerflboHSYXv6MTUY+4aAS6XJROh7J0OcfBcu9KY1SQKG5oOA6LhEswc\n\tZZ0JIgJPKeHZJvJqbpl+KY9nzxXBmNJ8QLGtFvKMRm+OkR9oKG9hXfCi/cdlM3p1SB\n\tfn5V1/tZZI2udwkrPWb74FvrCCW5hsKdTCxfNz6E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fbU1gbP1\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 10 May 2022 14:51:17 +0300","Message-Id":"<20220510115147.19360-21-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","References":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 20/50] staging: media: imx:\n\timx7-media-csi: Drop imx_media_add_video_device call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"There's no need to call imx_media_add_video_device() anymore, as the\nvideo devices list it manages is only used by the control inheritance\nmechanism in the helpers, which this driver doesn't use.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 891e939d7ea5..b6643952da25 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1267,9 +1267,6 @@ static int imx7_csi_video_register(struct imx7_csi *csi)\n \t\treturn ret;\n \t}\n \n-\t/* Add vdev to the video devices list. */\n-\timx_media_add_video_device(&csi->imxmd, &csi->vdev);\n-\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","20/50"]}