{"id":15817,"url":"https://patchwork.libcamera.org/api/1.1/patches/15817/?format=json","web_url":"https://patchwork.libcamera.org/patch/15817/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220506145414.99039-7-tomi.valkeinen@ideasonboard.com>","date":"2022-05-06T14:54:13","name":"[libcamera-devel,v8,6/7] py: add unittests.py","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c86484e6067ad074828ea931461a2f6473cc27fe","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15817/mbox/","series":[{"id":3098,"url":"https://patchwork.libcamera.org/api/1.1/series/3098/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3098","date":"2022-05-06T14:54:07","name":"Python bindings","version":8,"mbox":"https://patchwork.libcamera.org/series/3098/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15817/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15817/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1327EC326C\n\tfor ;\n\tFri, 6 May 2022 14:55:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72D4065660;\n\tFri, 6 May 2022 16:55:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C5E76564E\n\tfor ;\n\tFri, 6 May 2022 16:55:13 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81EAE492;\n\tFri, 6 May 2022 16:55:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651848918;\n\tbh=5dvrmpnIxMrEeM2EX3VJMkMAhM0T2w8XNKQDdlJj7jg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xVLeEuLXCVv1fBLVrc3mwXV2nOTPTZehh6uUjPpEMFzkUS+9JE6YVfE+REHjjXuDh\n\tAYVicVTJh0Yzd0Ch0HfTJchTZyN/OaXn6DoJO8lS2SZWvE4RUX3Nn3JckFHW5FPKbe\n\tTEjAvPI6W1163ItofTwOK6YpAC9MVOexWA56LbarL69Nt4RMbQLtca1dRC2SToEdf/\n\t3DxhTNC5ccUPsSMfp6YiVOrlb1GVJmjS4i+iKgF0tOZjL4lOrL7A/LS8uzxxjtNmMr\n\tnNEATMsJZ6WtG/Qi31sTmogFnzKmH50us5u4KcNH5c2DSOj29/kQP1QYSF03+FXDe3\n\tRxZMWLhpjI+Rg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651848912;\n\tbh=5dvrmpnIxMrEeM2EX3VJMkMAhM0T2w8XNKQDdlJj7jg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lIWHbj+4uX0hskeuG1C1WfsZBlAWyLJbdfHGORV77lyhIG9OpQxFFgo27vCt2OJRb\n\tFi+BDrTnqRs/R2JmVhGVvmqQJq2L1zJvq/sF1KLjcoIW1E8aKUGHODEoIPrZfuIWB2\n\tYNxvX2PViJ93Onu0Z85BXdqrLTrhEw9DRckYGZps="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lIWHbj+4\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Fri, 6 May 2022 17:54:13 +0300","Message-Id":"<20220506145414.99039-7-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220506145414.99039-1-tomi.valkeinen@ideasonboard.com>","References":"<20220506145414.99039-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 6/7] py: add unittests.py","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a simple unittests.py as a base for python unittests.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n test/meson.build | 1 +\n test/py/meson.build | 17 +++\n test/py/unittests.py | 352 +++++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 370 insertions(+)\n create mode 100644 test/py/meson.build\n create mode 100755 test/py/unittests.py","diff":"diff --git a/test/meson.build b/test/meson.build\nindex fd4c5ca0..623f3baa 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -18,6 +18,7 @@ subdir('log')\n subdir('media_device')\n subdir('pipeline')\n subdir('process')\n+subdir('py')\n subdir('serialization')\n subdir('stream')\n subdir('v4l2_compat')\ndiff --git a/test/py/meson.build b/test/py/meson.build\nnew file mode 100644\nindex 00000000..2affdbd4\n--- /dev/null\n+++ b/test/py/meson.build\n@@ -0,0 +1,17 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+if not pycamera_enabled\n+ subdir_done()\n+endif\n+\n+pymod = import('python')\n+py3 = pymod.find_installation('python3')\n+\n+pypathdir = meson.project_build_root() / 'src' / 'py'\n+\n+test('pyunittests',\n+ py3,\n+ args : files('unittests.py'),\n+ env : ['PYTHONPATH=' + pypathdir],\n+ suite : 'pybindings',\n+ is_parallel : false)\ndiff --git a/test/py/unittests.py b/test/py/unittests.py\nnew file mode 100755\nindex 00000000..cbc00ff3\n--- /dev/null\n+++ b/test/py/unittests.py\n@@ -0,0 +1,352 @@\n+#!/usr/bin/env python3\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2022, Tomi Valkeinen \n+\n+from collections import defaultdict\n+import errno\n+import gc\n+import libcamera as libcam\n+import os\n+import selectors\n+import time\n+import unittest\n+import weakref\n+\n+\n+class BaseTestCase(unittest.TestCase):\n+ def assertZero(self, a, msg=None):\n+ self.assertEqual(a, 0, msg)\n+\n+\n+class SimpleTestMethods(BaseTestCase):\n+ def test_get_ref(self):\n+ cm = libcam.CameraManager.singleton()\n+ wr_cm = weakref.ref(cm)\n+\n+ cam = cm.get('platform/vimc.0 Sensor B')\n+ self.assertIsNotNone(cam)\n+ wr_cam = weakref.ref(cam)\n+\n+ cm = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_cm())\n+\n+ cam = None\n+ gc.collect()\n+ self.assertIsNone(wr_cm())\n+ self.assertIsNone(wr_cam())\n+\n+ def test_acquire_release(self):\n+ cm = libcam.CameraManager.singleton()\n+ cam = cm.get('platform/vimc.0 Sensor B')\n+ self.assertIsNotNone(cam)\n+\n+ ret = cam.acquire()\n+ self.assertZero(ret)\n+\n+ ret = cam.release()\n+ self.assertZero(ret)\n+\n+ def test_double_acquire(self):\n+ cm = libcam.CameraManager.singleton()\n+ cam = cm.get('platform/vimc.0 Sensor B')\n+ self.assertIsNotNone(cam)\n+\n+ ret = cam.acquire()\n+ self.assertZero(ret)\n+\n+ libcam.log_set_level('Camera', 'FATAL')\n+ ret = cam.acquire()\n+ self.assertEqual(ret, -errno.EBUSY)\n+ libcam.log_set_level('Camera', 'ERROR')\n+\n+ ret = cam.release()\n+ self.assertZero(ret)\n+\n+ ret = cam.release()\n+ # I expected EBUSY, but looks like double release works fine\n+ self.assertZero(ret)\n+\n+\n+class CameraTesterBase(BaseTestCase):\n+ def setUp(self):\n+ self.cm = libcam.CameraManager.singleton()\n+ self.cam = next((cam for cam in self.cm.cameras if 'platform/vimc' in cam.id), None)\n+ if self.cam is None:\n+ self.cm = None\n+ self.skipTest('No vimc found')\n+\n+ ret = self.cam.acquire()\n+ if ret != 0:\n+ self.cam = None\n+ self.cm = None\n+ raise Exception('Failed to acquire camera')\n+\n+ def tearDown(self):\n+ # If a test fails, the camera may be in running state. So always stop.\n+ self.cam.stop()\n+\n+ ret = self.cam.release()\n+ if ret != 0:\n+ raise Exception('Failed to release camera')\n+\n+ self.cam = None\n+ self.cm = None\n+\n+\n+class AllocatorTestMethods(CameraTesterBase):\n+ def test_allocator(self):\n+ cam = self.cam\n+\n+ camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+ wr_camconfig = weakref.ref(camconfig)\n+\n+ streamconfig = camconfig.at(0)\n+ wr_streamconfig = weakref.ref(streamconfig)\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+ wr_stream = weakref.ref(stream)\n+\n+ # stream should keep streamconfig and camconfig alive\n+ streamconfig = None\n+ camconfig = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_camconfig())\n+ self.assertIsNotNone(wr_streamconfig())\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+ wr_allocator = weakref.ref(allocator)\n+\n+ buffers = allocator.buffers(stream)\n+ buffers = None\n+\n+ buffer = allocator.buffers(stream)[0]\n+ self.assertIsNotNone(buffer)\n+ wr_buffer = weakref.ref(buffer)\n+\n+ allocator = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_buffer())\n+ self.assertIsNotNone(wr_allocator())\n+ self.assertIsNotNone(wr_stream())\n+\n+ buffer = None\n+ gc.collect()\n+ self.assertIsNone(wr_buffer())\n+ self.assertIsNone(wr_allocator())\n+ self.assertIsNotNone(wr_stream())\n+\n+ stream = None\n+ gc.collect()\n+ self.assertIsNone(wr_stream())\n+ self.assertIsNone(wr_camconfig())\n+ self.assertIsNone(wr_streamconfig())\n+\n+\n+class SimpleCaptureMethods(CameraTesterBase):\n+ def test_sleep(self):\n+ cm = self.cm\n+ cam = self.cam\n+\n+ camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+\n+ streamconfig = camconfig.at(0)\n+ fmts = streamconfig.formats\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+\n+ num_bufs = len(allocator.buffers(stream))\n+\n+ reqs = []\n+ for i in range(num_bufs):\n+ req = cam.create_request(i)\n+ self.assertIsNotNone(req)\n+\n+ buffer = allocator.buffers(stream)[i]\n+ ret = req.add_buffer(stream, buffer)\n+ self.assertZero(ret)\n+\n+ reqs.append(req)\n+\n+ buffer = None\n+\n+ ret = cam.start()\n+ self.assertZero(ret)\n+\n+ for req in reqs:\n+ ret = cam.queue_request(req)\n+ self.assertZero(ret)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ time.sleep(0.5)\n+\n+ reqs = cm.get_ready_requests()\n+\n+ self.assertTrue(len(reqs) == num_bufs)\n+\n+ for i, req in enumerate(reqs):\n+ self.assertTrue(i == req.cookie)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ ret = cam.stop()\n+ self.assertZero(ret)\n+\n+ def test_select(self):\n+ cm = self.cm\n+ cam = self.cam\n+\n+ camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+\n+ streamconfig = camconfig.at(0)\n+ fmts = streamconfig.formats\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+\n+ num_bufs = len(allocator.buffers(stream))\n+\n+ reqs = []\n+ for i in range(num_bufs):\n+ req = cam.create_request(i)\n+ self.assertIsNotNone(req)\n+\n+ buffer = allocator.buffers(stream)[i]\n+ ret = req.add_buffer(stream, buffer)\n+ self.assertZero(ret)\n+\n+ reqs.append(req)\n+\n+ buffer = None\n+\n+ ret = cam.start()\n+ self.assertZero(ret)\n+\n+ for req in reqs:\n+ ret = cam.queue_request(req)\n+ self.assertZero(ret)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ sel = selectors.DefaultSelector()\n+ sel.register(cm.efd, selectors.EVENT_READ)\n+\n+ reqs = []\n+\n+ running = True\n+ while running:\n+ events = sel.select()\n+ for key, mask in events:\n+ os.read(key.fileobj, 8)\n+\n+ ready_reqs = cm.get_ready_requests()\n+\n+ self.assertTrue(len(ready_reqs) > 0)\n+\n+ reqs += ready_reqs\n+\n+ if len(reqs) == num_bufs:\n+ running = False\n+\n+ self.assertTrue(len(reqs) == num_bufs)\n+\n+ for i, req in enumerate(reqs):\n+ self.assertTrue(i == req.cookie)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ ret = cam.stop()\n+ self.assertZero(ret)\n+\n+\n+# Recursively expand slist's objects into olist, using seen to track already\n+# processed objects.\n+def _getr(slist, olist, seen):\n+ for e in slist:\n+ if id(e) in seen:\n+ continue\n+ seen.add(id(e))\n+ olist.append(e)\n+ tl = gc.get_referents(e)\n+ if tl:\n+ _getr(tl, olist, seen)\n+\n+\n+def get_all_objects(ignored=[]):\n+ gcl = gc.get_objects()\n+ olist = []\n+ seen = set()\n+\n+ seen.add(id(gcl))\n+ seen.add(id(olist))\n+ seen.add(id(seen))\n+ seen.update(set([id(o) for o in ignored]))\n+\n+ _getr(gcl, olist, seen)\n+\n+ return olist\n+\n+\n+def create_type_count_map(olist):\n+ map = defaultdict(int)\n+ for o in olist:\n+ map[type(o)] += 1\n+ return map\n+\n+\n+def diff_type_count_maps(before, after):\n+ return [(k, after[k] - before[k]) for k in after if after[k] != before[k]]\n+\n+\n+if __name__ == '__main__':\n+ # \\todo This is an attempt to see the Python objects that are not collected,\n+ # but this doesn't work very well, as things always leak a bit.\n+ test_leaks = False\n+\n+ if test_leaks:\n+ gc.unfreeze()\n+ gc.collect()\n+\n+ obs_before = get_all_objects()\n+\n+ unittest.main(exit=False)\n+\n+ if test_leaks:\n+ gc.unfreeze()\n+ gc.collect()\n+\n+ obs_after = get_all_objects([obs_before])\n+\n+ before = create_type_count_map(obs_before)\n+ after = create_type_count_map(obs_after)\n+\n+ leaks = diff_type_count_maps(before, after)\n+ if len(leaks) > 0:\n+ print(leaks)\n","prefixes":["libcamera-devel","v8","6/7"]}