{"id":1572,"url":"https://patchwork.libcamera.org/api/1.1/patches/1572/?format=json","web_url":"https://patchwork.libcamera.org/patch/1572/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190701201504.28487-14-laurent.pinchart@ideasonboard.com>","date":"2019-07-01T20:15:04","name":"[libcamera-devel,v4,13/13,PoC] QCam: Control demo: A SineWave Brightness","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"20793195c5b0397c7a3a28cd97d8ed52f333212a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/1572/mbox/","series":[{"id":386,"url":"https://patchwork.libcamera.org/api/1.1/series/386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=386","date":"2019-07-01T20:14:51","name":"libcamera Controls","version":4,"mbox":"https://patchwork.libcamera.org/series/386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1572/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1572/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62B76619E5\n\tfor ;\n\tMon, 1 Jul 2019 22:15:33 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0522F524\n\tfor ;\n\tMon, 1 Jul 2019 22:15:31 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562012132;\n\tbh=PIlqXsOiLQbKLx2Pi8tqvo7q5gEcHawdRl3WYeCSX6M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=GOidttDp7gDmV+gxp9C4TVsmDYKe8efoYMnyVgt0hkDg0fRWwJgAAOs/It9ufJHLD\n\twXCMScazgtnDu/h8J18AyNojcWa7ononZ9F8bmG1A48A2YbZzHtZ19IS8s3B6VO2xT\n\ti1Vy9l13rxcq5KoaqqOf02IjiubnhUlMCWfNBOZE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 1 Jul 2019 23:15:04 +0300","Message-Id":"<20190701201504.28487-14-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 13/13] [PoC] QCam: Control demo: A\n\tSineWave Brightness","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 20:15:33 -0000"},"content":"From: Kieran Bingham \n\nAs an example of how to add a control to each request, set the\nBrightness value with a changing value against the buffer time stamps.\nThe Brightness will go up and down following a sine wave to visualise\nthe control effect on the video stream.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Laurent Pinchart \n---\nChanges since v2:\n\n- Take controls min/max values into account\n---\n src/qcam/main_window.cpp | 29 ++++++++++++++++++++++++++++-\n src/qcam/main_window.h | 3 +++\n 2 files changed, 31 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 16b123132dd9..bfd3af1e4b92 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -5,6 +5,7 @@\n * main_window.cpp - qcam - Main application window\n */\n \n+#include \n #include \n #include \n #include \n@@ -21,7 +22,8 @@\n using namespace libcamera;\n \n MainWindow::MainWindow(const OptionsParser::Options &options)\n-\t: options_(options), isCapturing_(false)\n+\t: options_(options), isCapturing_(false),\n+\t brightness_(nullptr), gain_(nullptr)\n {\n \tint ret;\n \n@@ -88,6 +90,14 @@ int MainWindow::openCamera()\n \n \tstd::cout << \"Using camera \" << camera_->name() << std::endl;\n \n+\tconst ControlInfoMap &controls = camera_->controls();\n+\tauto iter = controls.find(Brightness);\n+\tif (iter != controls.end())\n+\t\tbrightness_ = &iter->second;\n+\titer = controls.find(ManualGain);\n+\tif (iter != controls.end())\n+\t\tgain_ = &iter->second;\n+\n \tcamera_->requestCompleted.connect(this, &MainWindow::requestComplete);\n \n \treturn 0;\n@@ -184,6 +194,14 @@ void MainWindow::stopCapture()\n \tconfig_.reset();\n }\n \n+static int sineWaveValue(Buffer *buffer, const ControlInfo *info)\n+{\n+\tunsigned int millisec = buffer->timestamp() / 1000000;\n+\tconstexpr float rads = 2 * M_PI / 180;\n+\treturn (sin(0.036 * rads * millisec) + 1) / 2 *\n+\t (info->max().getInt() - info->min().getInt());\n+}\n+\n void MainWindow::requestComplete(Request *request,\n \t\t\t\t const std::map &buffers)\n {\n@@ -213,6 +231,15 @@ void MainWindow::requestComplete(Request *request,\n \t\treturn;\n \t}\n \n+\t/*\n+\t * A demonstration control, which has a distinct visual effect.\n+\t * Scale the brightness up and down with a sine wave.\n+\t */\n+\tif (brightness_)\n+\t\trequest->controls()[Brightness] = sineWaveValue(buffer, brightness_);\n+\tif (gain_)\n+\t\trequest->controls()[ManualGain] = sineWaveValue(buffer, gain_);\n+\n \trequest->setBuffers(buffers);\n \tcamera_->queueRequest(request);\n }\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex fe565cbcb460..0a52399edc74 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -48,6 +48,9 @@ private:\n \tbool isCapturing_;\n \tstd::unique_ptr config_;\n \n+\tconst ControlInfo *brightness_;\n+\tconst ControlInfo *gain_;\n+\n \tViewFinder *viewfinder_;\n };\n \n","prefixes":["libcamera-devel","v4","13/13","PoC"]}