{"id":15719,"url":"https://patchwork.libcamera.org/api/1.1/patches/15719/?format=json","web_url":"https://patchwork.libcamera.org/patch/15719/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220426091409.1352047-2-chenghaoyang@chromium.org>","date":"2022-04-26T09:14:06","name":"[libcamera-devel,v3,1/4] Allow inheritance of FrameBuffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d78749ed8f4bce5d76dcf6ebd520776e9ce97bdb","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15719/mbox/","series":[{"id":3071,"url":"https://patchwork.libcamera.org/api/1.1/series/3071/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3071","date":"2022-04-26T09:14:05","name":"Add CrOS JEA implementation","version":3,"mbox":"https://patchwork.libcamera.org/series/3071/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15719/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15719/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36F2DC0F1B\n\tfor ;\n\tTue, 26 Apr 2022 09:16:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D678E65642;\n\tTue, 26 Apr 2022 11:16:02 +0200 (CEST)","from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FC4260431\n\tfor ;\n\tTue, 26 Apr 2022 11:16:01 +0200 (CEST)","by mail-pj1-x1036.google.com with SMTP id\n\ts14-20020a17090a880e00b001caaf6d3dd1so1694107pjn.3\n\tfor ;\n\tTue, 26 Apr 2022 02:16:01 -0700 (PDT)","from chenghaoyang.c.googlers.com.com\n\t(93.135.240.35.bc.googleusercontent.com. [35.240.135.93])\n\tby smtp.gmail.com with ESMTPSA id\n\tw123-20020a623081000000b005056a4d71e3sm14441042pfw.77.2022.04.26.02.15.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Apr 2022 02:15:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650964562;\n\tbh=MY8s5OVh76SUxRhlo1CHxzmj/Ds7Vml2S55M3asVEYw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WuacUDMO5ljH7Vj4LvxxtuwFGhfaxd0xO3zqSb39zIBYSrs/HYG/Woxovbvb3Ey8Y\n\tzNs6NRUadP50p2U0jP71mBA/G/l1HXUfzOZCGIAu5FG79Ern6iN8Pm80WMEFzJLwgd\n\tEWto2IlK9c0UTntbu59qgKJD/UEp3LXxjmehyGmy5O5iv4ob/Axijr6Z4wy8J+HW5N\n\tdl8DGM66b4R+FtEyD8GF++SYY4qk68Xqpg7vlNTVWW1VgmWJr/neMrOGavMlHi4sQx\n\tn6PS8/2iFTFnHFJEDryC1CYOMgTweN3uXCK1JI9wUuKWSXr68p5Q7dz0TEYwD3+xIn\n\twM/rkzbLh3Sew==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=coaS5RWqTLoXtJP51hv+aKejO7ClDzrYPRhHfrlXIJ0=;\n\tb=K2cAX/OeJG9GXPYCUIU5WCJXBUvqtsavpE0YdI1EZPqyhRN8Aye2vdZKgq8qp/Swk4\n\t7zpelQ0ZKNSFjEM4KDvEf3cauQs+JEQ+o6OWRDOaO0aiJcc6A8iI7enbPYgKJUyRk+gd\n\tlmgRHGSoifVWAED2xgXGTKPW9xHVwQhb1NsWQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"K2cAX/Oe\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=coaS5RWqTLoXtJP51hv+aKejO7ClDzrYPRhHfrlXIJ0=;\n\tb=zJhhoqrTMHjiyLn8ddv6DMMMNkmmkr2gcF9NoFC2GV+SFhrycHHPu5DWB/zKiCjtn+\n\tIJKnksJzrd038722J1mrD+FKjb6dgxIxv0JPR0ZB2/Ul0t/jMs3t5rbHUvpUPcXjX3rg\n\twx4HJYPQaA2K/qGugcksPeCV3KTfiT1ynkPaZR3M8Rjlxm7N9v5KQDsIih2GzZN+3QfE\n\t16VEOK2G5yRoqC7qIpEZL/5naA8+6h2v9savc2aRLSNqLDXKu3AUa0+jW2HDQLJsZi2z\n\tHjewypI7W0wZKkSTHPLdR0XEIAg0DSKpSPuLPCP8UK4LASsySckD1uWAyt853NsivBs5\n\t2exA==","X-Gm-Message-State":"AOAM530Bs7o8RgNshqOpUlRIxbahka9fycsx+AEnyUDC8AuOok9SfNpM\n\trS6+yDzk7qvKVG26UDn9ip8rwj4i9XCtQj0B","X-Google-Smtp-Source":"ABdhPJygdfQVtGIVyImZc1uaGKFye/FSsUKhDaHn6ytSYf16ETxlwEb7IHmdgBEiOt4pysQzy4CIrw==","X-Received":"by 2002:a17:902:7e83:b0:158:ae65:b926 with SMTP id\n\tz3-20020a1709027e8300b00158ae65b926mr13570076pla.41.1650964559164; \n\tTue, 26 Apr 2022 02:15:59 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Apr 2022 09:14:06 +0000","Message-Id":"<20220426091409.1352047-2-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog","In-Reply-To":"<20220426091409.1352047-1-chenghaoyang@chromium.org>","References":"<20220426091409.1352047-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/4] Allow inheritance of FrameBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Harvey Yang via libcamera-devel ","Reply-To":"Harvey Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To add buffer_handle_t access in android, this CL allows inheritance of\nFrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang \n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1..e6c769b4 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -61,6 +61,7 @@ public:\n \tFrameBuffer(const std::vector &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr d,\n \t\t const std::vector &planes, unsigned int cookie = 0);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector &planes() const { return planes_; }\n \tRequest *request() const;\n","prefixes":["libcamera-devel","v3","1/4"]}