{"id":15701,"url":"https://patchwork.libcamera.org/api/1.1/patches/15701/?format=json","web_url":"https://patchwork.libcamera.org/patch/15701/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220421172549.138360-2-utkarsh02t@gmail.com>","date":"2022-04-21T17:25:49","name":"[libcamera-devel,2/2] Explicit cast to int","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"51b59e447728dbc8a0720e8f056bfe109a41caba","submitter":{"id":114,"url":"https://patchwork.libcamera.org/api/1.1/people/114/?format=json","name":"Utkarsh Tiwari","email":"utkarsh02t@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15701/mbox/","series":[{"id":3065,"url":"https://patchwork.libcamera.org/api/1.1/series/3065/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3065","date":"2022-04-21T17:25:48","name":"[libcamera-devel,1/2] Support float data type in options","version":1,"mbox":"https://patchwork.libcamera.org/series/3065/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15701/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15701/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06B04C3256\n\tfor ;\n\tThu, 21 Apr 2022 17:26:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1C0465647;\n\tThu, 21 Apr 2022 19:26:12 +0200 (CEST)","from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com\n\t[IPv6:2607:f8b0:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27B4A6563D\n\tfor ;\n\tThu, 21 Apr 2022 19:26:11 +0200 (CEST)","by mail-pl1-x62c.google.com with SMTP id q1so4324742plx.13\n\tfor ;\n\tThu, 21 Apr 2022 10:26:11 -0700 (PDT)","from localhost.localdomain ([2404:bd00:3:db75:9357:7a99:9595:33ae])\n\tby smtp.gmail.com with ESMTPSA id\n\tiy2-20020a17090b16c200b001d75aabe050sm1080174pjb.34.2022.04.21.10.26.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Apr 2022 10:26:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650561972;\n\tbh=B605x6FDZziCnsyZtxZl3XDoBxUCCH++SlJRlt2ed9k=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Em71KWjvbly/nWhL/y9EEfNj74hA2BB+HkneMucuVViQABifYeK4IIRJRSAv/FzNR\n\t872E3DNCmhpVQYE02WNiw2Sk7dFcIJ0lp1TtokxrjtTg9k2Jg8Sih5F9ojTTAloX6u\n\tZLIZBjOg8VrKwlUUMs5tyoXaY3mg0lJuP+ztPMM68kIFwu4p3WQIGRttFKgx0IvrYx\n\tNHLPH3tjnhvZPrslrk7i6LfTPjTt0cI4J/O4zxhJ6yZqYnNhvkSTYpx2A2vfIbFnOu\n\tHUiOFMzOV7E2Zk26dJcENuwZEGH8loCpRkziUHnoqSTBvSOmsNfcfZ0ISJWxmAN5jS\n\t/ozC4Hu7wL3YA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=tjDgSZHigoB2liOF7pVd99zsUk3oR30dd+oovknN5ac=;\n\tb=RH1W+V3bK4XkJ8bZA9Bsyn2QHVFww5i1JsAmGgq7OD+Txwl9iTNooA607XXWN1KqnX\n\tI5UlzukPiXDWihsfWLNFx8Jo3Am5TB7wYDTju1fwXXCZb0YDVd5AmIqmouA8NMFjPOyK\n\tE6C3pemp2oOt6KHT1oQoc412v3MgOx83bPodCCBnFgwRw2x9d5DbGRN6BJ0OQe6ckTY2\n\tdu8H419vifYgFVFmysBjpjl01O9uNSKSEprGZZgg/bQPc69GY2sojCXgGWGQUsSzoa3W\n\tnUxAFhta8HTDYtDSwwz5lpWyHkN0lh9g58fy56YzTNAX3vvoFJMZmcfjZZKRrPw2nEVb\n\tywPA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RH1W+V3b\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=tjDgSZHigoB2liOF7pVd99zsUk3oR30dd+oovknN5ac=;\n\tb=0R9qTyNBv8umvcNR397AGr7/C5tHmcw2g1tiMCa4ThCM2ODYGcV+WC2Ka4VTHBWODd\n\ty1hSYX5SAMwTH3XEqZoThsC+XlTfeaO/ansWYkZIwqZ96iPXuSxjUhq5X+RppzaUrLQf\n\txKcAqsygTWI1NAsDZMFpb9iBGlKpFR/MGXUyYNbobstk24Ee1nsWCnrIPna3GGNXICjV\n\ty5rwdnK9CJPI/yl+0WmPqhcTWOR0EkyurmfzNuG+HCHxDjj5aAwX1sJuOHYHjYuPadNz\n\tUpIxAYK34YY0Nfkc3p1+460sggkkD74SfThE4RZBwCTOOflRU5Fzzqw970BGEN29m6ka\n\tGDGA==","X-Gm-Message-State":"AOAM532Fb6/k9fVMgp5KjVYujHCUPgJYbEB+8mGTGT9MlbLgyogWFoJy\n\tCYIRmSTzpQskDQaYioZDyy8ym4CbILT4ow==","X-Google-Smtp-Source":"ABdhPJx1UYeyvACvx2SXunOEwWrCwoET/Zj6x8nyy2P8fnrrjdPaIE3uMddLu7qRxdWY+WtdMlwQSQ==","X-Received":"by 2002:a17:903:2cf:b0:151:a932:f1f0 with SMTP id\n\ts15-20020a17090302cf00b00151a932f1f0mr564719plk.130.1650561968553; \n\tThu, 21 Apr 2022 10:26:08 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 21 Apr 2022 22:55:49 +0530","Message-Id":"<20220421172549.138360-2-utkarsh02t@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220421172549.138360-1-utkarsh02t@gmail.com>","References":"<20220421172549.138360-1-utkarsh02t@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] Explicit cast to int","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Utkarsh Tiwari via libcamera-devel\n\t","Reply-To":"Utkarsh Tiwari ","Cc":"Utkarsh Tiwari ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"After introduction of float values to options the conversion of unsigned int to int or vice versa is regarded as the same rank as conversion to and from float. Fix this by using an explicit cast\n---\n src/cam/stream_options.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\nindex 150bd27c..83d216b7 100644\n--- a/src/cam/stream_options.cpp\n+++ b/src/cam/stream_options.cpp\n@@ -90,8 +90,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n \t\tStreamConfiguration &cfg = config->at(i++);\n \n \t\tif (opts.isSet(\"width\") && opts.isSet(\"height\")) {\n-\t\t\tcfg.size.width = opts[\"width\"];\n-\t\t\tcfg.size.height = opts[\"height\"];\n+\t\t\tcfg.size.width = static_cast(opts[\"width\"]);\n+\t\t\tcfg.size.height = static_cast(opts[\"height\"]);\n \t\t}\n \n \t\tif (opts.isSet(\"pixelformat\"))\n","prefixes":["libcamera-devel","2/2"]}