{"id":15666,"url":"https://patchwork.libcamera.org/api/1.1/patches/15666/?format=json","web_url":"https://patchwork.libcamera.org/patch/15666/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220413095342.389460-2-kieran.bingham@ideasonboard.com>","date":"2022-04-13T09:53:41","name":"[libcamera-devel,v3,1/2] libcamera: camera: Add a mode sensitivity field","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f188d3e10b57ef66b5bac1936687977a8ea1afeb","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15666/mbox/","series":[{"id":3050,"url":"https://patchwork.libcamera.org/api/1.1/series/3050/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3050","date":"2022-04-13T09:53:40","name":"Application support for per-mode sensitivities","version":3,"mbox":"https://patchwork.libcamera.org/series/3050/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15666/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15666/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA5EFC3260\n\tfor ;\n\tWed, 13 Apr 2022 09:53:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FBFC6563F;\n\tWed, 13 Apr 2022 11:53:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB59C6563E\n\tfor ;\n\tWed, 13 Apr 2022 11:53:24 +0200 (CEST)","from Q.ksquared.org.uk.beta.tailscale.net (unknown\n\t[178.237.134.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 362D4482;\n\tWed, 13 Apr 2022 11:53:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649843607;\n\tbh=e07PUHPKxK3iB0J5Sy48tMn2fLcWIU2b9tRdks87DzM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xPOdFW3B4SSv05br8JTOQze1EY+QnO592ApXVSY9td5uza08o8AMCakMgjRffkKUk\n\tAMCnZ5Z6FaHaZmVWCIyGiyvC1M8AlNX32Hl+Oq6S1fxtk+2+nE/Cj4HaXe2/Ldk9O6\n\toJrPbvNqbh+ZuMheCSnhlMOvzo9u7aoqEp81u3kndJVCEWUhpGBnJ/a1fd9/7dwD4M\n\tkrKol4TPCxnPVM2Gl8L0+YLSX7/MwLCK1uxh1Sdc6WZXjlD4e9XXbAxrp5kWMsOinO\n\tmV6K5drd2mraD3ka8pHgnHMOaKcrdwFo2Mazu1eHdsIS0oLlg2pH/dECu/g6RK0I3c\n\tviDDXzcoM8Krg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649843604;\n\tbh=e07PUHPKxK3iB0J5Sy48tMn2fLcWIU2b9tRdks87DzM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NHe/i/8xsxvSVtWXSRmjJlw73yb3UkQzGPyCcIBG+VLKBQulDtWSFxZhnY2hkcNmv\n\twBiqXPUC6g0vwH3eRVDIU44kFyGB0byTqJVC5qx1am96xPVZdAFh61d3hcY/cdkA0x\n\tdoBev+uwBnzcYFp5jApdBRXT73RjJF6MQ/tm8h7o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NHe/i/8x\"; dkim-atps=neutral","To":"libcamera devel ,\n\tNaushir Patuck ,\n\tDavid Plowman ","Date":"Wed, 13 Apr 2022 11:53:41 +0200","Message-Id":"<20220413095342.389460-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220413095342.389460-1-kieran.bingham@ideasonboard.com>","References":"<20220413095342.389460-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/2] libcamera: camera: Add a mode\n\tsensitivity field","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: David Plowman \n\nThe modeSensitivity field is a number that describes how sensitive the\nselected sensor mode is compared to other readout modes of the same\nsensor. For example, a binned mode might have twice the sensitivity of\nthe full resolution mode, meaning you would get double the signal\nlevel for the same exposure and gains.\n\nSigned-off-by: David Plowman \nReviewed-by: Kieran Bingham \nReviewed-by: Naushir Patuck \nSigned-off-by: Kieran Bingham \n---\n\nv3: [Kieran] : Spelling correction\n\n include/libcamera/camera.h | 2 ++\n src/libcamera/camera.cpp | 16 +++++++++++++++-\n 2 files changed, 17 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 5bb065847e04..826181cabc92 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -67,6 +67,8 @@ public:\n \n \tTransform transform;\n \n+\tfloat modeSensitivity;\n+\n protected:\n \tCameraConfiguration();\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 713543fd1bdf..c2e64a0ba5e4 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -160,7 +160,7 @@ LOG_DECLARE_CATEGORY(Camera)\n * \\brief Create an empty camera configuration\n */\n CameraConfiguration::CameraConfiguration()\n-\t: transform(Transform::Identity), config_({})\n+\t: transform(Transform::Identity), modeSensitivity(1.0), config_({})\n {\n }\n \n@@ -412,6 +412,20 @@ CameraConfiguration::Status CameraConfiguration::validateColorSpaces(ColorSpaceF\n * may adjust this field at its discretion if the selection is not supported.\n */\n \n+/**\n+ * \\var CameraConfiguration::modeSensitivity\n+ * \\brief The relative sensitivity of the chosen sensor mode\n+ *\n+ * Some sensors have readout modes with different sensitivities. For example,\n+ * a binned camera mode might, with the same exposure and gains, produce\n+ * twice the signal level of the full resolution readout. This would be\n+ * signalled by the binned mode, when it is chosen, indicating a value here\n+ * that is twice that of the full resolution mode.\n+ *\n+ * This value should only be read, and not set, by the user. It will be\n+ * valid after the configure method has returned successfully.\n+ */\n+\n /**\n * \\var CameraConfiguration::config_\n * \\brief The vector of stream configurations\n","prefixes":["libcamera-devel","v3","1/2"]}