{"id":1566,"url":"https://patchwork.libcamera.org/api/1.1/patches/1566/?format=json","web_url":"https://patchwork.libcamera.org/patch/1566/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190701201504.28487-8-laurent.pinchart@ideasonboard.com>","date":"2019-07-01T20:14:58","name":"[libcamera-devel,v4,07/13] libcamera: controls: Add a set of initial controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7d754d820485275fd8f0ddf105da494d2ee02354","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1566/mbox/","series":[{"id":386,"url":"https://patchwork.libcamera.org/api/1.1/series/386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=386","date":"2019-07-01T20:14:51","name":"libcamera Controls","version":4,"mbox":"https://patchwork.libcamera.org/series/386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1566/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1566/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88CAC61E16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  1 Jul 2019 22:15:30 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3FB1E524\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  1 Jul 2019 22:15:30 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562012130;\n\tbh=vqiud2b6h+aZ++cnTpe5KXp0l7EK7Snlbie6MyK+imI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TCfqQfdXTim3Nsqn1hsIMJ/L67EOcrTQkbXo1eUJk16fWbjAsaXLWxuA52FGLbl9c\n\tuLbEeLJOiR0bNZVtN1zPU6iBMYuAK26fDQZciP9JXrdBqPHMCHY+K3cVo2v48//ZoN\n\tAbRPfdBRN0oCfsKBGCvkK4o9uwVB+MFrpwCXDnz8=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  1 Jul 2019 23:14:58 +0300","Message-Id":"<20190701201504.28487-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a set\n\tof initial controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 01 Jul 2019 20:15:31 -0000"},"content":"Add an initial set of controls to demonstrate how controls are defined.\n\nProper documentation for each control is missing.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/control_ids.h |  6 +++++\n src/libcamera/controls.cpp      | 42 +++++++++++++++++++++++++++++++++\n 2 files changed, 48 insertions(+)","diff":"diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\nindex d0e700da9844..75b6a2d5cafe 100644\n--- a/include/libcamera/control_ids.h\n+++ b/include/libcamera/control_ids.h\n@@ -13,6 +13,12 @@\n namespace libcamera {\n \n enum ControlId {\n+\tAwbEnable,\n+\tBrightness,\n+\tContrast,\n+\tSaturation,\n+\tManualExposure,\n+\tManualGain,\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 42a2f8990bf6..d9fbd46d81c9 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -186,6 +186,48 @@ std::string ControlValue::toString() const\n  * \\brief Numerical control ID\n  */\n \n+/**\n+ * \\var AwbEnable\n+ * ControlType: Bool\n+ *\n+ * Enables or disables the AWB. See also \\a libcamera::ControlId::ManualGain\n+ */\n+\n+/**\n+ * \\var Brightness\n+ * ControlType: Integer\n+ *\n+ * Specify a fixed brightness parameter.\n+ */\n+\n+/**\n+ * \\var Contrast\n+ * ControlType: Integer\n+ *\n+ * Specify a fixed constrast parameter.\n+ */\n+\n+/**\n+ * \\var Saturation\n+ * ControlType: Integer\n+ *\n+ * Specify a fixed saturation parameter.\n+ */\n+\n+/**\n+ * \\var ManualExposure\n+ * ControlType: Integer\n+ *\n+ * Specify a fixed exposure time in milli-seconds\n+ */\n+\n+/**\n+ * \\var ManualGain\n+ * ControlType: Integer\n+ *\n+ * Specify a fixed gain parameter\n+ */\n+\n /**\n  * \\struct ControlIdentifier\n  * \\brief Describe a ControlId with control specific constant meta-data\n","prefixes":["libcamera-devel","v4","07/13"]}