{"id":15649,"url":"https://patchwork.libcamera.org/api/1.1/patches/15649/?format=json","web_url":"https://patchwork.libcamera.org/patch/15649/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220407083719.21631-4-laurent.pinchart@ideasonboard.com>","date":"2022-04-07T08:37:19","name":"[libcamera-devel,3/3] test: v4l2_videodevice: Fix format configuration in the vimc pipeline","commit_ref":"302731cdf8e107f8fa005309f3475f98581de8e6","pull_url":null,"state":"accepted","archived":false,"hash":"5ba6c0f9884b88cf12d5af54d02cd3e278ce4781","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15649/mbox/","series":[{"id":3042,"url":"https://patchwork.libcamera.org/api/1.1/series/3042/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3042","date":"2022-04-07T08:37:16","name":"test: Fix dequeue_watchdog test failure when running the whole test suite","version":1,"mbox":"https://patchwork.libcamera.org/series/3042/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15649/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15649/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1092C326C\n\tfor ;\n\tThu, 7 Apr 2022 08:37:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 416C76564B;\n\tThu, 7 Apr 2022 10:37:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C35B965642\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)","from localhost.localdomain (117.145-247-81.adsl-dyn.isp.belgacom.be\n\t[81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89F0C880\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649320650;\n\tbh=Kc5rQ3wTdXxfGCnnrkYiSU3g48v9MxokGXTPyQcpySw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hv9sbTTdlBFJHe35jhwKoX1h/srI4ul5kpihNhw1W4+wMPFupfS7oQKFz2PX0s8H5\n\tTZkZ3Yslb4rUW5gyhZ43kYBQ8VTrVAlzXCqIkcjdbShPWbpgH7YrEGXyQtQPG5ka4o\n\t5o5ht/KL7C5dS28oSjsPcllVe+kHEutwv9oEycTIEhBjOx2NhS6ItdYylwHSXHHXLq\n\txqzSvqtOi4Ny6NIH+B8uIDzxsWsJqKWbQQ0cz31Cm3LEQfWJNClxDXOv35UCksLEF0\n\tpV2qyTqCtPoVyedmW+JKK7Atmtq67ZZVou5yRLHUxOhrfdg5CAdIZ30bNA1qmimKaD\n\t14TJJCFSqXQFA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649320646;\n\tbh=Kc5rQ3wTdXxfGCnnrkYiSU3g48v9MxokGXTPyQcpySw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fDT8J51pC2gG/14kN/KTvS8RO1GLr3T8TFvbjnb+RHUdX3asfwOf/1lZ+GrVTDKnK\n\t3HQrVr6+uI2Mo1MwniF/0rN6rPAJpzYv/nDwZtIV5RJR++hvn2Fpy1Zw71dbkiN8Os\n\t7IHkjjwR2M511wz65tTULtiHbCQfk9Kudaa4AwMo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fDT8J51p\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 7 Apr 2022 11:37:19 +0300","Message-Id":"<20220407083719.21631-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","References":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] test: v4l2_videodevice: Fix format\n\tconfiguration in the vimc pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2VideoDeviceTest class configures the capture pipeline with\nparameters that are partly hardcoded, and partly come from the current\nconfiguration of the device. In particular, with the vimc pipeline, the\nsensor subdevice is configured with the size retrieved from the capture\nvideo node, and the video node is then reconfigured to 640x480.\n\nRelying on the current (and thus possibly random) device configuration\ncan lead to broken pipes when starting streaming. This currently causes\nfailures of the dequeue_watchdog test when run after the formats test.\n\nFix it by explicitly setting the same size for both the vimc subdevs and\nthe video capture device.\n\nSigned-off-by: Laurent Pinchart \n---\n test/v4l2_videodevice/v4l2_videodevice_test.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\nindex f23aaf8f514b..125aafd65041 100644\n--- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n+++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n@@ -60,6 +60,9 @@ int V4L2VideoDeviceTest::init()\n \tif (capture_->getFormat(&format))\n \t\treturn TestFail;\n \n+\tformat.size.width = 640;\n+\tformat.size.height = 480;\n+\n \tif (driver_ == \"vimc\") {\n \t\tsensor_ = new CameraSensor(media_->getEntityByName(\"Sensor A\"));\n \t\tif (sensor_->init())\n@@ -82,8 +85,6 @@ int V4L2VideoDeviceTest::init()\n \t\t\treturn TestFail;\n \t}\n \n-\tformat.size.width = 640;\n-\tformat.size.height = 480;\n \tif (capture_->setFormat(&format))\n \t\treturn TestFail;\n \n","prefixes":["libcamera-devel","3/3"]}