{"id":15648,"url":"https://patchwork.libcamera.org/api/1.1/patches/15648/?format=json","web_url":"https://patchwork.libcamera.org/patch/15648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220407083719.21631-3-laurent.pinchart@ideasonboard.com>","date":"2022-04-07T08:37:18","name":"[libcamera-devel,2/3] test: v4l2_videodevice: dequeue_watchdog: Check return value of streamOn","commit_ref":"3980448e9f46f9ca2f27b38187215543984e3f5d","pull_url":null,"state":"accepted","archived":false,"hash":"0aa0faaf191dff8246ad00db268eaf412440ef95","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15648/mbox/","series":[{"id":3042,"url":"https://patchwork.libcamera.org/api/1.1/series/3042/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3042","date":"2022-04-07T08:37:16","name":"test: Fix dequeue_watchdog test failure when running the whole test suite","version":1,"mbox":"https://patchwork.libcamera.org/series/3042/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15648/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62E9EC3260\n\tfor ;\n\tThu, 7 Apr 2022 08:37:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5B7665645;\n\tThu, 7 Apr 2022 10:37:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1E8F61FBB\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)","from localhost.localdomain (117.145-247-81.adsl-dyn.isp.belgacom.be\n\t[81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 562D2499\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649320649;\n\tbh=ffILHcbRXXpA/Ufu8UVGlvdxDF8uUqT+FvqKKdKFFYo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qmOR68TjwHTn9ofe7CAC2gIeKFCu7mxqbq4gcjAKt6wIRnNyYeTTRIrtH5onVyPVM\n\tVF9V+VKNGi19uGZ1OXYGl71buWeS4+5QzBuit2IpiAMy0zVPJxMjauS85+MwR3mWPM\n\tc8JlsRDvt0JP4+wWT+p2o2Gbl6nCEvIjIuUWLudRpU6xYnDVcnONbJgyT+HxloiF8T\n\tWvuIWww14fN+e903ZwzahfJ61hfVVOqoVgrj2Er6VTwugKCCnEtL4H0ONpBvTDbL1g\n\tBxDI2AJ/CnK56KHkSozmsJ8G9xAQAZ5SSY/V+05mtWATz/VQhPsJRt8nH0jEmN8rhE\n\t9FE+gMUHz2vFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649320646;\n\tbh=ffILHcbRXXpA/Ufu8UVGlvdxDF8uUqT+FvqKKdKFFYo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UAU4hQQRmLvG8tt0R14swPHjswJHBoPgwWBgO9+8Ihiv4qNItSMdz7SPUAz2mFjXG\n\t9eMfM6vKAn4qOF6nFEx1Wr0xqXIRMT4y67ThgtmEnrVP2JyvyU5BnNAQin50nnahBQ\n\tRL5XOS5PQCUN2EI2wWIITkNao+NYJHkhDuECb2NI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UAU4hQQR\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 7 Apr 2022 11:37:18 +0300","Message-Id":"<20220407083719.21631-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","References":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] test: v4l2_videodevice:\n\tdequeue_watchdog: Check return value of streamOn","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the streamOn() call fails, there is no way the test will then\nsucceed. Catch it and return a failure.\n\nSigned-off-by: Laurent Pinchart \n---\n test/v4l2_videodevice/dequeue_watchdog.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/test/v4l2_videodevice/dequeue_watchdog.cpp b/test/v4l2_videodevice/dequeue_watchdog.cpp\nindex 2282e3958c03..320d14c8e442 100644\n--- a/test/v4l2_videodevice/dequeue_watchdog.cpp\n+++ b/test/v4l2_videodevice/dequeue_watchdog.cpp\n@@ -50,7 +50,11 @@ protected:\n \t\t\t}\n \t\t}\n \n-\t\tcapture_->streamOn();\n+\t\tret = capture_->streamOn();\n+\t\tif (ret < 0) {\n+\t\t\tstd::cout << \"Failed to start streaming\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \n \t\ttimeout.start(5s);\n \t\twhile (timeout.isRunning()) {\n","prefixes":["libcamera-devel","2/3"]}