{"id":15605,"url":"https://patchwork.libcamera.org/api/1.1/patches/15605/?format=json","web_url":"https://patchwork.libcamera.org/patch/15605/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220401000616.12976-3-Rauch.Christian@gmx.de>","date":"2022-04-01T00:06:13","name":"[libcamera-devel,2/5] generate fixed- and variable-sized Span Controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2ef70d0ab64404ec1cf78c7383bfd422713a6dd2","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/1.1/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15605/mbox/","series":[{"id":3022,"url":"https://patchwork.libcamera.org/api/1.1/series/3022/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3022","date":"2022-04-01T00:06:11","name":"generate and use fixed-sized Span Control types","version":1,"mbox":"https://patchwork.libcamera.org/series/3022/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15605/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15605/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0058C3265\n\tfor ;\n\tFri, 1 Apr 2022 00:06:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73ECA65641;\n\tFri, 1 Apr 2022 02:06:47 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F3B660135\n\tfor ;\n\tFri, 1 Apr 2022 02:06:45 +0200 (CEST)","from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1MuDc7-1nt8Mi0LQj-00udf7; Fri, 01 Apr 2022 02:06:45 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648771607;\n\tbh=LPPdeQdJbsck3dbM0H669GulrtDx8tgII4gP48FnFPQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mGGjf5D3U5dodLhtbyV4Q5Ty5ceqjpz8kAYRIuIMaLluFbDxht8J5B2wVk7wgZZ+g\n\tyH6ygfVEkHwbtZb66dPrsYqRCj2KaHRPE23AfqtjIp6AJ/IwLP1D3TXFjcE3eyErDa\n\t8b1V6H5HtexggseGc33XCdmfFUOPBPcCmoFmh9PrhTjcjy0PtRPYHUf6lgJZxbusDw\n\tm0wTZWHGdW5Tj/u5RToDIYYZ8Us7pGhjHQhi4zyUN9vTzCNZgSmtK9nOACcWPeo+bv\n\tqi9SbjcMey1GBUBBlWVhrrF1tZeSUnBYb6uCOFgHANNBdoR6e/RxUvy/uhtPAzs8Rx\n\tPIZ8Ca4Juu1jA==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1648771605;\n\tbh=LPPdeQdJbsck3dbM0H669GulrtDx8tgII4gP48FnFPQ=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=hAoJZsMZfONdEhCT+xug+y7eL2az2jmeo7XG9Ywl9tGRMl1fEtMze2x3/f79vClzK\n\tDGL2OLcdEVYi/gJYzP+EEiwQx7ZDBRBbZPDSOmAStHzMhEK4x+Z3eYET+czU3+tmkJ\n\tdhzKDH4ttF7bEBPJnp3wJwYONiGWt86fumW+SjT8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"hAoJZsMZ\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Apr 2022 01:06:13 +0100","Message-Id":"<20220401000616.12976-3-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220401000616.12976-1-Rauch.Christian@gmx.de>","References":"<20220401000616.12976-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:pjquAJgGrAojuXgsCfZezU4cJ5Y4vD8gFPSydcXosmIjWmYSmgL\n\twvsf4Nouc0N+J36r7vCUb5ZPB53G4CuweJ3qbL5wiJRBq3jgkBAZp/UxN/QVs3I7CK1AI5r\n\tMBKHnxc3AYgVp+6o25LO/iRtvxqvsH10PSZG7HyfWK30lKjl2n6QoE990JIXfkLzwmznPUF\n\tUSzdlmvbCBfGubjyddr9A==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:tY5BXCb8rQs=:QBNqE8PoEStqotT9DWAfuM\n\tcSjcRf7+ZTunkXKQSmaDs8HAuIGN8loavyGbJzCx4O1qXWeGiZedkJ5dK2SoyNsvuVt6AqOZy\n\tkSnaH8moO91yHL9wCrYG9Mdqz+d5Sjxbrwx/sny83JO/806qRdPtTuNRvL5xS7Wnz8IeF8jVn\n\t2ILHFEnNgiOxMLQnWxaQhx1rSsIfvR2CpkPuEBShoKMmEck9zc/mIkqql4y3FCXQFTO/qAMXD\n\taQsB8TY6xAzzQEoxPlMxoaGJY4d1mJ3AGG2AxDScqfQ8Gspd8v9tnIZzAQv73gfq6KsSu+AEo\n\tuTyVgAL7Bcdt+0T2MK/7sFWEqrXYrR1wjtvTE6aEWMzJtxEymj/27ZNCZgt1Xlo//7nbCQ0HV\n\tydoSyoMN0z1/Tuqt5rfdf9a8jm2mu8eZIMxuBiWKtzCspjX5GrtgpHDX97ZzHYugqa9sSromD\n\tD1CWr9cmzLcynKnbrO9p6XqQhsBEYkLO1DwArnbwOyCUEySAqJlhGRM5W33AHOV6iVUw6+/v5\n\tqPikoOpMSy3rB2vPiurHQTC22zuMsJVDfHHh9iGOMsMVWKYrNtRLMZUx3eWBja+drc1vmhsvR\n\t9HYHskmDyttFbHPyqKOKlT3e0DUiZ3furtty07MxSE8WwPeSl9ABoxwRK+jtU9LywmlRDg5qV\n\tHkSH9bEC+FdUYG+Npn73M2K04qGSWY9uB0KkQW0eUdpM4GN5CY6IuO0v/qqGjPW07D2qZ6kVh\n\tIWfsQWfhHlASlnOsM3Vvu6fYJUmi9fq0S3wuPVjdiMOIoMm1jxSPJRTTBQAVkxJNCFWmt19Ew\n\tUiWt91c5q1EnOtlEhDlf2ynyKKuCRsfScDW3RSACU3SIrrgsDeaAzeoBi0isLWPJ3N/BjdtbQ\n\tcVLn6e6MfjxGFbvkAmFMuVDp5OCmjLX1AfaVZba09/SOnV8x8tM1lVbWzcMF1JhFmTXkRVXD8\n\tYuKjMdmLanXfJ65SHOe4dpiefFoOilpOYhub8jUNSYmoDW5VVcarstXwYXv8RLS7w+z4jKa8J\n\thvxTkg5g8eXnQkTsRLW/bUtrie+C63zbUvc9vvLt29d2grA4DmW5SO7fTUFNgoPZrbgtHu7zv\n\tnGmPOpRL9cHuMQ=","Subject":"[libcamera-devel] [PATCH 2/5] generate fixed- and variable-sized\n\tSpan Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This defines Controls with a 'size' as either variable-sized Span or as\nfixed-sized Span.\n\nSigned-off-by: Christian Rauch \n---\n utils/gen-controls.py | 33 +++++++++++++++++++++++----------\n 1 file changed, 23 insertions(+), 10 deletions(-)\n\n--\n2.25.1","diff":"diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..694d761a 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -10,6 +10,7 @@ import argparse\n import string\n import sys\n import yaml\n+from math import prod\n\n\n def snake_case(s):\n@@ -22,6 +23,26 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type_format(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+ ctrl_is_span = ctrl_size_arr is not None\n+ if ctrl_is_span:\n+ ctrl_span_size = prod(ctrl_size_arr) if len(ctrl_size_arr)>0 else None\n+\n+ if ctrl_type == 'string':\n+ ctrl_type = 'std::string'\n+ elif ctrl_is_span:\n+ if ctrl_span_size:\n+ # fixed-sized Span\n+ ctrl_type = 'Span'.format(ctrl_type, ctrl_span_size)\n+ else:\n+ # variable-sized Span\n+ ctrl_type = 'Span'.format(ctrl_type)\n+\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +71,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type_format(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +152,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type_format(ctrl)\n\n info = {\n 'name': name,\n","prefixes":["libcamera-devel","2/5"]}