{"id":15602,"url":"https://patchwork.libcamera.org/api/1.1/patches/15602/?format=json","web_url":"https://patchwork.libcamera.org/patch/15602/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220331165725.188364-3-umang.jain@ideasonboard.com>","date":"2022-03-31T16:57:25","name":"[libcamera-devel,2/2] ipa: vimc: Rename processControls() to queueRequest()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"af5fa3538dba4ae743edde205fe664112cc73a49","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15602/mbox/","series":[{"id":3021,"url":"https://patchwork.libcamera.org/api/1.1/series/3021/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3021","date":"2022-03-31T16:57:23","name":"Synchronise IPA interfaces","version":1,"mbox":"https://patchwork.libcamera.org/series/3021/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15602/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15602/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3418AC0F1B\n\tfor ;\n\tThu, 31 Mar 2022 16:57:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD51C65635;\n\tThu, 31 Mar 2022 18:57:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDBEB6559A\n\tfor ;\n\tThu, 31 Mar 2022 18:57:51 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.74.73.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB18359D;\n\tThu, 31 Mar 2022 18:57:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648745872;\n\tbh=RRnhBGMlC1/FXvWNWEXLMl8JrgFzNMMVdYU6hpzuCmA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fhtUx2VJ0IuN4fndrCBk3e3YHQY4imSEPArjNgGy/XSYXfHljTMl/7UA2Jkf+StOH\n\tpCGNysTumVh37GW3LF4kk3Tu8FvGkK2WhtI+/ZhLkBANg52TXRmY4a4LTS9yz4lpVR\n\tuprvoDRZH6LV7bLXyJIAKL3dYi8okmwEl9WnSgKapl1evfNFi2XTKXB6dVRqiZx70U\n\t7OAnMgYUyTDzGFoI+NQ0z/Wz5k3lhgjB6mSskoT9TFguBLmoB297zY+2izegIlwOnd\n\tEtOgFeRhlaE7suaqqD3FY9TQHKuXK7TVXvAEkktwm4YVwaUKaFyHLfsoHHy5ySRcWE\n\tU+FDQ3bPs9fJA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648745871;\n\tbh=RRnhBGMlC1/FXvWNWEXLMl8JrgFzNMMVdYU6hpzuCmA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e81BYq9XjYMXitR5bGyWdUYFIGRo5G3/P9RbbOCsS7/dcN6Rz+ewR3iRVGdZ5YT7o\n\tZQAuDITGx+KjlmE2FBB7r22XmY0dPknLmatg4jqZnzDpSpsKkmH6mJ+QM6tWnYjqZ5\n\tnnWSnoY1R0DDx4xfC0RxPYk30KwMrC13gSxstRNQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e81BYq9X\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 31 Mar 2022 22:27:25 +0530","Message-Id":"<20220331165725.188364-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220331165725.188364-1-umang.jain@ideasonboard.com>","References":"<20220331165725.188364-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: vimc: Rename processControls()\n\tto queueRequest()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Synchronise with other IPA intefaces (for e.g. IPU3, RkISP1)\nthat uses queueRequest() to pass in the request controls to\nIPA.\n\nSigned-off-by: Umang Jain \n---\n include/libcamera/ipa/vimc.mojom | 2 +-\n src/ipa/vimc/vimc.cpp | 6 +++---\n src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex e3b14e38..e5ac3609 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -37,7 +37,7 @@ interface IPAVimcInterface {\n \t * handle parameters at runtime.\n \t */\n \t[async] fillParams(uint32 frame, uint32 bufferId);\n-\t[async] processControls(uint32 frame, libcamera.ControlList controls);\n+\t[async] queueRequest(uint32 frame, libcamera.ControlList controls);\n };\n \n interface IPAVimcEventInterface {\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 8481b82b..315302c6 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -44,7 +44,7 @@ public:\n \tvoid unmapBuffers(const std::vector &ids) override;\n \n \tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n-\tvoid processControls(uint32_t frame, const ControlList &controls) override;\n+\tvoid queueRequest(uint32_t frame, const ControlList &controls) override;\n \n private:\n \tvoid initTrace();\n@@ -140,8 +140,8 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n \tparamsFilled.emit(bufferId);\n }\n \n-void IPAVimc::processControls([[maybe_unused]] uint32_t frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n+void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n+\t\t\t [[maybe_unused]] const ControlList &controls)\n {\n }\n \ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 29960fe3..69b83d07 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -432,7 +432,7 @@ int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tdata->ipa_->processControls(request->sequence(), request->controls());\n+\tdata->ipa_->queueRequest(request->sequence(), request->controls());\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","2/2"]}