{"id":1560,"url":"https://patchwork.libcamera.org/api/1.1/patches/1560/?format=json","web_url":"https://patchwork.libcamera.org/patch/1560/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190701201504.28487-2-laurent.pinchart@ideasonboard.com>","date":"2019-07-01T20:14:52","name":"[libcamera-devel,v4,01/13] libcamera: v4l2_controls: Add min and max to V4L2ControlInfo","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1fff64f7c76d3217ac1a933fb2b3dbbad40523c0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1560/mbox/","series":[{"id":386,"url":"https://patchwork.libcamera.org/api/1.1/series/386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=386","date":"2019-07-01T20:14:51","name":"libcamera Controls","version":4,"mbox":"https://patchwork.libcamera.org/series/386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1560/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1560/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF2206157D\n\tfor ;\n\tMon, 1 Jul 2019 22:15:28 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D09F1200\n\tfor ;\n\tMon, 1 Jul 2019 22:15:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562012128;\n\tbh=iiCXQgE/DuJHRcxh/gxNdbNgqY6dmgSnDSoeoDugz1c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Be9UUuWmGcPJIiUnRScfxp/Luy0CHe3Ii1SD0lY2YjdttDGkQLJp7GUTt8LMdR4N1\n\tw/tlGSv8TuUT86cLpON7DebluYGKEpH3I5ywhW8dHZkcCVkKx3wOZO78tGIbQxvK0A\n\thrjudmi4awC21/32Pj3vAc5PApcqL3kdokPn/U/w=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 1 Jul 2019 23:14:52 +0300","Message-Id":"<20190701201504.28487-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 01/13] libcamera: v4l2_controls: Add\n\tmin and max to V4L2ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 20:15:29 -0000"},"content":"Add min() and max() methods to V4L2ControlInfo to report the control's\nminimum and maximum value respectively.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \n---\n src/libcamera/include/v4l2_controls.h | 6 ++++++\n src/libcamera/v4l2_controls.cpp | 14 ++++++++++++++\n 2 files changed, 20 insertions(+)","diff":"diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\nindex 2c8cb9003f25..0047efab11fa 100644\n--- a/src/libcamera/include/v4l2_controls.h\n+++ b/src/libcamera/include/v4l2_controls.h\n@@ -28,11 +28,17 @@ public:\n \tsize_t size() const { return size_; }\n \tconst std::string &name() const { return name_; }\n \n+\tint64_t min() const { return min_; }\n+\tint64_t max() const { return max_; }\n+\n private:\n \tunsigned int id_;\n \tunsigned int type_;\n \tsize_t size_;\n \tstd::string name_;\n+\n+\tint64_t min_;\n+\tint64_t max_;\n };\n \n class V4L2Control\ndiff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\nindex 78888de29642..af017bce48ba 100644\n--- a/src/libcamera/v4l2_controls.cpp\n+++ b/src/libcamera/v4l2_controls.cpp\n@@ -74,6 +74,8 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n \ttype_ = ctrl.type;\n \tname_ = static_cast(ctrl.name);\n \tsize_ = ctrl.elem_size * ctrl.elems;\n+\tmin_ = ctrl.minimum;\n+\tmax_ = ctrl.maximum;\n }\n \n /**\n@@ -100,6 +102,18 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n * \\return The V4L2 control user readable name\n */\n \n+/**\n+ * \\fn V4L2ControlInfo::min()\n+ * \\brief Retrieve the control minimum value\n+ * \\return The V4L2 control minimum value\n+ */\n+\n+/**\n+ * \\fn V4L2ControlInfo::max()\n+ * \\brief Retrieve the control maximum value\n+ * \\return The V4L2 control maximum value\n+ */\n+\n /**\n * \\class V4L2Control\n * \\brief A V4L2 control value\n","prefixes":["libcamera-devel","v4","01/13"]}