{"id":15569,"url":"https://patchwork.libcamera.org/api/1.1/patches/15569/?format=json","web_url":"https://patchwork.libcamera.org/patch/15569/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","date":"2022-03-28T10:05:44","name":"[libcamera-devel] ipa: raspberrypi: Correct some of the ControlInfo ranges and defaults","commit_ref":"8dc2699bb87f5328dd3aae540d6e9d858212f774","pull_url":null,"state":"accepted","archived":false,"hash":"312a6fd65ce08402baae3268cac462fd37149897","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15569/mbox/","series":[{"id":3006,"url":"https://patchwork.libcamera.org/api/1.1/series/3006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3006","date":"2022-03-28T10:05:44","name":"[libcamera-devel] ipa: raspberrypi: Correct some of the ControlInfo ranges and defaults","version":1,"mbox":"https://patchwork.libcamera.org/series/3006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15569/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15569/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45AB7C3256\n\tfor ;\n\tMon, 28 Mar 2022 10:06:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 972BA65631;\n\tMon, 28 Mar 2022 12:06:02 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A18460135\n\tfor ;\n\tMon, 28 Mar 2022 12:06:01 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id h23so19578516wrb.8\n\tfor ;\n\tMon, 28 Mar 2022 03:06:01 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tp14-20020a5d59ae000000b00203dcc87d39sm18928848wrr.54.2022.03.28.03.05.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Mar 2022 03:06:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648461962;\n\tbh=fobxSYOca9n2xqEKbNJtunWSX+/5vXXf8PaEwvMuwf4=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=pGSYzPf/zAtn0qiZTf5M547tB5EyyaoHMmH7QpHZDvWk8Q9HOg0fON/ONPIip67iV\n\tVXpZC9Ut8RJksHYMBLvkj4C509Lj9kLHBEYA4lgkxChsPwtO5cPNEqaAKqSe6RB9Df\n\tPwb+Kk4vyGxfvn/m7lEQKQhY03nDzmjph4ZQa/h/O2KaqAmIi4qsN6cgAb8JTUy6kl\n\tYSAIx/Zu0Oc0dtP6JjPmV8gL5mpbaJkNHgmjgyMrtuh0qy2L7X7VMHNN46DVvLthn9\n\tdWugUmH+lWEPUjmygi6GWyn9U6JsUAgUqoVaCNaqdBjNYSRuIJKnI10uBm5elx+KYV\n\tc3kpIkrW6ARtA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=iypP3q+acGjWspBuWENRUV7LmQSI6M69OQXAEukl2vE=;\n\tb=I2w2w5OV7QbIFIuj/jakq5MxLsHrRL0boA8HCvkrm6pGeIUr3WQvu1MxtyrT18KWOQ\n\tK+ZLMFmtaKPDbyP8e7VRxjvaA2l5IOB/IAnNOGSauMuiXKGa8Ow90VjsNT/IxSmK1VrY\n\tYdm92/S2FEHb84xVU9PTojJyxhl8QPvAIy3UYU7vBx+CMwPIyBmvGXAP1Yl0yWLLMzdp\n\tReLrZ/Hwf13lNoJwt0nF5Lmzy4isej3AvhduCY8rNd4EDDnwaxdGPJ7clL2mvXlv5u8p\n\toDU6ZuXaRp1cbc3blxN8x54lC8s4crNDuM4KPMbA8FIHrsvzfEqwILgbjs+TGQGjB4OV\n\tY7PA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"I2w2w5OV\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=iypP3q+acGjWspBuWENRUV7LmQSI6M69OQXAEukl2vE=;\n\tb=7GaIom8DNpvjIPbaeGEgSzTbXFeR3aKfEzlxiJM52M4PLPNvQwpSletZ3z+0QlcNpX\n\tyRF9WNmNM2f/3VZ8xA+Cj8AP06v46G1WY6ReIZj2gZcX1AEjlJy6RGfWfZexYgy+XpEp\n\tE9vdt7+F7fIIO1DCCVPTGk7yLq6tYWD5369nXdq69mB4lTtQD3YDLvLB2Ufc0v4o63PY\n\tMxiLNzgEfqBpwUlJ04Kt1smf66PZ4x5jAX1Ti5eSs+vqBKxJiya5lJf9qgvedFZXfkm/\n\t05vpo331TVMJp/RZ7GHi4AeGBpJ7Y7lA1xDvDyppk60UbpRujrSX0uAELeFLTOvMMCVq\n\tJnuw==","X-Gm-Message-State":"AOAM5320+b8qPvFiPWUzEEBo+wKFwRQH+9U/ghVDMTc+d1wHiICC8oOR\n\tkAnmXfb/4hGta9V/JzX0V7RB8hiZVoIQpA==","X-Google-Smtp-Source":"ABdhPJxLc7K65nplT4tAvScuXq8p8JjI+eduAKj2b6mtFU1j2pnM+d/LkWX14C0hfGKxBoRdbtfSrA==","X-Received":"by 2002:adf:a411:0:b0:205:c4e1:6ee6 with SMTP id\n\td17-20020adfa411000000b00205c4e16ee6mr3617800wra.489.1648461960646; \n\tMon, 28 Mar 2022 03:06:00 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Mar 2022 11:05:44 +0100","Message-Id":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Some of the values were listed incorrectly. Specifically:\n\nExposureValue: the range is now centred correctly on zero\nBrightness: the default value (0.0) is made explicit\nContrast: the default value is corrected to be 1.0\nSaturation: the default value is corrected to be 1.0\n\nSigned-off-by: David Plowman \n---\n include/libcamera/ipa/raspberrypi.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 7f705e49..6a56b008 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -34,13 +34,13 @@ static const ControlInfoMap Controls({\n \t\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n \t\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },\n \t\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },\n-\t\t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n+\t\t{ &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f) },\n \t\t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n \t\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n-\t\t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n-\t\t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n-\t\t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n+\t\t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },\n+\t\t{ &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },\n+\t\t{ &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },\n \t\t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n \t\t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t\t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n","prefixes":["libcamera-devel"]}