{"id":15561,"url":"https://patchwork.libcamera.org/api/1.1/patches/15561/?format=json","web_url":"https://patchwork.libcamera.org/patch/15561/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220326174639.32199-1-laurent.pinchart@ideasonboard.com>","date":"2022-03-26T17:46:39","name":"[libcamera-devel] utils: hooks: pre-push: Catch commits without author's SoB","commit_ref":"4efca856c040ce78b08534a41190ae6c63326e04","pull_url":null,"state":"accepted","archived":false,"hash":"77fe64da9212f5ab632947685ec928d894d199cc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15561/mbox/","series":[{"id":3003,"url":"https://patchwork.libcamera.org/api/1.1/series/3003/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3003","date":"2022-03-26T17:46:39","name":"[libcamera-devel] utils: hooks: pre-push: Catch commits without author's SoB","version":1,"mbox":"https://patchwork.libcamera.org/series/3003/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15561/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15561/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1371BD80A\n\tfor ;\n\tSat, 26 Mar 2022 17:46:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3D63604C7;\n\tSat, 26 Mar 2022 18:46:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5CF7604C4\n\tfor ;\n\tSat, 26 Mar 2022 18:46:44 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E75A474\n\tfor ;\n\tSat, 26 Mar 2022 18:46:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648316806;\n\tbh=VFoWgGqRiNZXgsc8S0VJhREWLY4diTSAA+qboqGKAGc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=oeFU5ctlv/e+Fo/LgAGBPoKfU0Qb6hUgPKkoYz2lbIHyWhsUfpRWy/8EviTa6+nEr\n\tWiZZmDQbrSH23H2rgdpU08pBPOh/B10tTnKc7qsqm9mCmSfsTbZ1S18Ls4dqABQrmA\n\t9tFsQ9hn+lj1Dny5hhrEea7AxqLDDemEadmrrS7oVwSYPtt85MaK8VNqpZBrrMlIz/\n\tY9MHExU/oelqz4ZjnENaTzeNYzt9bdq3bUh+ZgqsWeUray7/3DIPd3TeOJ5x0SL83y\n\tkk78VG88jurszJgEqV3g57veZvTLPufl5OYWDuobgqB1167YxfGsbtl09OHLiTAgXz\n\t1EKjPpTEex61A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648316804;\n\tbh=VFoWgGqRiNZXgsc8S0VJhREWLY4diTSAA+qboqGKAGc=;\n\th=From:To:Subject:Date:From;\n\tb=RKEZXDYSZE1aFW9ikkDrMT2L+XQRUyFIQeOuwSkDyL2TskUtMpl7d2wTvASqH1NKR\n\tQlPCxCu8MsueCWYEcsO8a399n/Js08EUYb3y7rcf/unfFPodqqCn5XnW2j53xQva53\n\tCO/ilHKWLXdwP3VeLZb1Qd61rYUknnZhYhZWtoAw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RKEZXDYS\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 26 Mar 2022 19:46:39 +0200","Message-Id":"<20220326174639.32199-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] utils: hooks: pre-push: Catch commits\n\twithout author's SoB","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The pre-push git hook script catches commits without a SoB line\ncorresponding to the committer, but doesn't perform the same check on\nthe author. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/hooks/pre-push | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\nindex e4187f381a43..90ffdf6f1755 100755\n--- a/utils/hooks/pre-push\n+++ b/utils/hooks/pre-push\n@@ -67,8 +67,8 @@ do\n \t\t\terrors=$((errors+1))\n \t\tfi\n \n-\t\t# 2. The commit message shall have a Signed-off-by line\n-\t\t# corresponding the committer.\n+\t\t# 2. The commit message shall have Signed-off-by lines\n+\t\t# corresponding the committer and the author.\n \t\tcommitter=$(echo \"$msg\" | grep '^committer ' | head -1 | \\\n \t\t\t\tcut -d ' ' -f 2- | rev | cut -d ' ' -f 3- | rev)\n \t\tif ! echo \"$msg\" | grep -F -q \"Signed-off-by: ${committer}\"\n@@ -77,6 +77,14 @@ do\n \t\t\terrors=$((errors+1))\n \t\tfi\n \n+\t\tauthor=$(echo \"$msg\" | grep '^author ' | head -1 | \\\n+\t\t\t\tcut -d ' ' -f 2- | rev | cut -d ' ' -f 3- | rev)\n+\t\tif ! echo \"$msg\" | grep -F -q \"Signed-off-by: ${author}\"\n+\t\tthen\n+\t\t\techo >&2 \"Missing author Signed-off-by in commit $commit\"\n+\t\t\terrors=$((errors+1))\n+\t\tfi\n+\n \t\t# 3. A Reviewed-by or Acked-by is required.\n \t\tif ! echo \"$msg\" | grep -q '^\\(Reviewed\\|Acked\\)-by: '\n \t\tthen\n","prefixes":["libcamera-devel"]}