{"id":15523,"url":"https://patchwork.libcamera.org/api/1.1/patches/15523/?format=json","web_url":"https://patchwork.libcamera.org/patch/15523/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220323135614.865252-6-kieran.bingham@ideasonboard.com>","date":"2022-03-23T13:56:14","name":"[libcamera-devel,v2,5/5] ipa: ipu3: af: Simplify accumulations of y_items","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7ddbf2c62fbd75487c5f4bd32e00f5f4008f1d62","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15523/mbox/","series":[{"id":2989,"url":"https://patchwork.libcamera.org/api/1.1/series/2989/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2989","date":"2022-03-23T13:56:09","name":"ipa: ipu3: af: Small improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/2989/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15523/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15523/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B1EEC3264\n\tfor ;\n\tWed, 23 Mar 2022 13:56:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12285604E9;\n\tWed, 23 Mar 2022 14:56:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A92A8604E8\n\tfor ;\n\tWed, 23 Mar 2022 14:56:21 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57A349DE;\n\tWed, 23 Mar 2022 14:56:21 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648043787;\n\tbh=ksqITB42MM48DgLEZ5ynX4or9LnP0P5pmn4QxUXRY/g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=R61D1QuPed4r5b5u6ZXthGaGjqqPtedt/QvzwqkDqlDvQXIiZV5ASGBt3bf15oiTG\n\tW7Xcsyj3+HjGd8xGf9Rhirs7LwckGXsA0sYlCRSnlFrfdSBnB1LGhaRuYlz9c9pq+Y\n\tzQii1BKgj2z4+MBSmVM3ImtwPiwYiAiZzqARuYH4D8DbTX+jJ7w8o5WgwrftjJPr2d\n\tttPM5+I2O5INmZHaCsY0oqjzoy0fA62MN2U+vermL2gKGGgZSGoJuTrlkWD4KhVnYy\n\tjTa0bCtgLaNFdi3ImNJa6pdX0vbxin0hLsdxd93uNxNL67CyQ80/R/mdLfvLfrVepU\n\tFjw5oVIyUdwzQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648043781;\n\tbh=ksqITB42MM48DgLEZ5ynX4or9LnP0P5pmn4QxUXRY/g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ntzbQ2zvHPpuePQjXPcw6LpfW93rQ90IhRH8s2F2rgknbBwA64ue27E2wEIYU6jsU\n\tU7PM+rXc1xrf7yzqjacKtjGlEXnSrqnM44LeB7IX2yT5C8rs2jDTdXiiUCVoPMNob7\n\t7aTC/1H28HT+cBX3E2P8LTO83RTkTF6XcIAr/Sgg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ntzbQ2zv\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Wed, 23 Mar 2022 13:56:14 +0000","Message-Id":"<20220323135614.865252-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20220323135614.865252-1-kieran.bingham@ideasonboard.com>","References":"<20220323135614.865252-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] ipa: ipu3: af: Simplify\n\taccumulations of y_items","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Simplify the accumulation of the total and variance with a ternary\noperator.\n\nSigned-off-by: Kieran Bingham \n---\n\nThis is optional really, it's only really a stylistic preference.\n\n\n src/ipa/ipu3/algorithms/af.cpp | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex ff5e9fb5b3c5..940ed68ea14a 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -342,20 +342,14 @@ double Af::afEstimateVariance(Span y_items, bool isY1)\n \tdouble mean;\n \tdouble var_sum = 0;\n \n-\tfor (auto y : y_items) {\n-\t\tif (isY1)\n-\t\t\ttotal += y.y1_avg;\n-\t\telse\n-\t\t\ttotal += y.y2_avg;\n-\t}\n+\tfor (auto y : y_items)\n+\t\ttotal += isY1 ? y.y1_avg : y.y2_avg;\n \n \tmean = total / y_items.size();\n \n \tfor (auto y : y_items) {\n-\t\tif (isY1)\n-\t\t\tvar_sum += pow((y.y1_avg - mean), 2);\n-\t\telse\n-\t\t\tvar_sum += pow((y.y2_avg - mean), 2);\n+\t\tdouble avg = isY1 ? y.y1_avg : y.y2_avg;\n+\t\tvar_sum += pow((avg - mean), 2);\n \t}\n \n \treturn var_sum / static_cast(y_items.size());\n","prefixes":["libcamera-devel","v2","5/5"]}