{"id":15449,"url":"https://patchwork.libcamera.org/api/1.1/patches/15449/?format=json","web_url":"https://patchwork.libcamera.org/patch/15449/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220315133407.32348-2-laurent.pinchart@ideasonboard.com>","date":"2022-03-15T13:34:07","name":"[libcamera-devel,2/2] ipa: ipu3: agc: Use existing local short-hand variable in configure()","commit_ref":"4774d36779c49ee17e73109a86cb6205d8681f3a","pull_url":null,"state":"accepted","archived":false,"hash":"a2863c602129f7db3e4a259114b8b870be772ee6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15449/mbox/","series":[{"id":2961,"url":"https://patchwork.libcamera.org/api/1.1/series/2961/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2961","date":"2022-03-15T13:34:06","name":"[libcamera-devel,1/2] ipa: ipu3: agc: Reset frame count when configuring AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/2961/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15449/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15449/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06B78C3262\r\n\tfor ;\r\n\tTue, 15 Mar 2022 13:34:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E202E632E2;\r\n\tTue, 15 Mar 2022 14:34:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8850E604DA\r\n\tfor ;\r\n\tTue, 15 Mar 2022 14:34:32 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C8161C34\r\n\tfor ;\r\n\tTue, 15 Mar 2022 14:34:32 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647351273;\r\n\tbh=4oomBjcbeo/wtZoXxzrhAeBeEQFaLJJu2+DhxocT0oI=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=V1gHFoVmLW80mzLCzpGtRD3ho4okGU+yjf2aXyhOcVTasvpj7G3LSzg+c+DQTyrL5\r\n\t+CqpVcUBzsaltm4HvT5NTAGngt/fbnah8eDy5pJBYJRegln0RNxrxa264AJnFfH5OQ\r\n\tr+BrU25+5Mdd7GKUsKDVDqWX9pmUjnIKjLFkOT8Xuf+MD6KPn4LlZTh6fWnaMm0fcP\r\n\tRBl8ng/sWRbDPhmA1mijxAzGDwqWoW2NN7dvrA0PqbUnfx/wWmLnjPn/V1/NNuwiNC\r\n\tGyTrw/rflkKZfc+xTKY39lTJj8SFSuTaqV75AqnYdHNbTmcoyqTt6C56oRgB9ZkVbB\r\n\t0b5sr094KC+Tg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1647351272;\r\n\tbh=4oomBjcbeo/wtZoXxzrhAeBeEQFaLJJu2+DhxocT0oI=;\r\n\th=From:To:Subject:Date:In-Reply-To:References:From;\r\n\tb=XcAd71Xpt3thkwQabH2z2hPagBwXZLVukYGkyYC4La0KYC0r7Cccm82InShMlFC9t\r\n\tffdL3lko9vHFDPFOKLN93IMwRDSi7tPu827RNmYNaYUQ/7JH2TwjSwTR71O/M30jVz\r\n\tz+bTJzhN2P1ZEFPlEpP/+iT8K77tUPyxAkPEt/zU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"XcAd71Xp\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Mar 2022 15:34:07 +0200","Message-Id":"<20220315133407.32348-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","References":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: ipu3: agc: Use existing local\r\n\tshort-hand variable in configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Laurent Pinchart via libcamera-devel\r\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The configure() function has a local configuration variable referencing\ncontext.configuration for the purpose of shortening lines. Use it\ninstead of context.configuration in the remaining locations, and\nconstify it while at it as the configuration isn't meant to be modified.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\r\nindex 70cff3fed43c..7d4b3503f390 100644\r\n--- a/src/ipa/ipu3/algorithms/agc.cpp\r\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\r\n@@ -86,17 +86,17 @@ Agc::Agc()\r\n int Agc::configure(IPAContext &context,\r\n \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\r\n {\r\n-\tIPASessionConfiguration &configuration = context.configuration;\r\n+\tconst IPASessionConfiguration &configuration = context.configuration;\r\n \tIPAFrameContext &frameContext = context.frameContext;\r\n \r\n \tstride_ = configuration.grid.stride;\r\n \r\n-\tminShutterSpeed_ = context.configuration.agc.minShutterSpeed;\r\n-\tmaxShutterSpeed_ = std::min(context.configuration.agc.maxShutterSpeed,\r\n+\tminShutterSpeed_ = configuration.agc.minShutterSpeed;\r\n+\tmaxShutterSpeed_ = std::min(configuration.agc.maxShutterSpeed,\r\n \t\t\t\t kMaxShutterSpeed);\r\n \r\n-\tminAnalogueGain_ = std::max(context.configuration.agc.minAnalogueGain, kMinAnalogueGain);\r\n-\tmaxAnalogueGain_ = std::min(context.configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\r\n+\tminAnalogueGain_ = std::max(configuration.agc.minAnalogueGain, kMinAnalogueGain);\r\n+\tmaxAnalogueGain_ = std::min(configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\r\n \r\n \t/* Configure the default exposure and gain. */\r\n \tframeContext.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);","prefixes":["libcamera-devel","2/2"]}