{"id":15435,"url":"https://patchwork.libcamera.org/api/1.1/patches/15435/?format=json","web_url":"https://patchwork.libcamera.org/patch/15435/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-03-09T15:26:14","name":"[libcamera-devel] libcamera: Fix typo in a function name for camera lens class","commit_ref":"ed13310b1fe4c531d6a830c69fbbe0b544d805bd","pull_url":null,"state":"accepted","archived":false,"hash":"2cf8be26db800f4dd3e7861f2e91ee4256ba1d03","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15435/mbox/","series":[{"id":2956,"url":"https://patchwork.libcamera.org/api/1.1/series/2956/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2956","date":"2022-03-09T15:26:14","name":"[libcamera-devel] libcamera: Fix typo in a function name for camera lens class","version":1,"mbox":"https://patchwork.libcamera.org/series/2956/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15435/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15435/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD911BE08A\r\n\tfor ;\r\n\tWed, 9 Mar 2022 15:26:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E26CC6118B;\r\n\tWed, 9 Mar 2022 16:26:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[213.167.242.64])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 345C260475\r\n\tfor ;\r\n\tWed, 9 Mar 2022 16:26:18 +0100 (CET)","from tatooine.ideasonboard.com (unknown\r\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B10588C4;\r\n\tWed, 9 Mar 2022 16:26:17 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1646839578;\r\n\tbh=hD1TSPH0zzQ4sd/6g85fylEZEK/lmcFfVgmIJM23zZM=;\r\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\r\n\tList-Help:List-Subscribe:From:Reply-To:From;\r\n\tb=HXgN07Ljc2nX9d4CxBDn73Q2314fJ+VttjEoH521YxOWrC98k06xjP/Buk+kB+CvU\r\n\tZZM0Z+McUm/DW8eepuO1LE4teOwZKNziKrwErLaxWAxEW98RpC3fLStq/M4xK89StF\r\n\tBHnPXiJv5TR8OV/MBAEmwbdh5KUM9CFGiK4/p+sB6lozdLffxOrHurQ+VVDt4WGWPD\r\n\tiRy6kUFUWFUQgsdtYaD6KEmCRjO2zDiCXqK6J/EkryHUWKqVETU+mOeiqwe62vyPDD\r\n\t9MN1YI3T6ME9JjYhhcbB40z3N9DGUVT1O7DZeQkLtjtXe0y0/9ExE7yv+Qh2PdxvA+\r\n\tOIyr84PmN6CmA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1646839577;\r\n\tbh=hD1TSPH0zzQ4sd/6g85fylEZEK/lmcFfVgmIJM23zZM=;\r\n\th=From:To:Cc:Subject:Date:From;\r\n\tb=HrmVLHiHngpt06lSdzHRoZPbcH6mNh8De2e1bhTIX/1EHoAczloeRofZ1o96iICr9\r\n\to8f4WGxomHc86Qul0dHxlNCXIXz6Zyk4P1a+1jQUzHksGircretuwatHWd4NEcOAIm\r\n\trGsi591GA++84bI3xSuYydQtFnPfwYeC/UZ1mCmA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"HrmVLHiH\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 9 Mar 2022 16:26:14 +0100","Message-Id":"<20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Fix typo in a function name\r\n\tfor camera lens class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Jean-Michel Hautbois via libcamera-devel\r\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraLens class implements a function named \"setFocusPostion\".\nThere is a typo here, fix it.\nWhile at it fix it in the IPU3 IPA as it is used only here.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n include/libcamera/internal/camera_lens.h | 2 +-\n src/libcamera/camera_lens.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\r\nindex 6f2ea1bc..ff4d066e 100644\r\n--- a/include/libcamera/internal/camera_lens.h\r\n+++ b/include/libcamera/internal/camera_lens.h\r\n@@ -24,7 +24,7 @@ public:\r\n \t~CameraLens();\r\n \r\n \tint init();\r\n-\tint setFocusPostion(int32_t position);\r\n+\tint setFocusPosition(int32_t position);\r\n \r\n \tconst std::string &model() const { return model_; }\r\n \r\ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\r\nindex 189cb025..810fcffa 100644\r\n--- a/src/libcamera/camera_lens.cpp\r\n+++ b/src/libcamera/camera_lens.cpp\r\n@@ -84,7 +84,7 @@ int CameraLens::init()\r\n *\r\n * \\return 0 on success or -EINVAL otherwise\r\n */\r\n-int CameraLens::setFocusPostion(int32_t position)\r\n+int CameraLens::setFocusPosition(int32_t position)\r\n {\r\n \tControlList lensCtrls(subdev_->controls());\r\n \tlensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast(position));\r\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\r\nindex 6c5617cd..03259d0e 100644\r\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\r\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\r\n@@ -1267,7 +1267,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\r\n \t\tconst ControlValue &focusValue =\r\n \t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\r\n \r\n-\t\tfocusLens->setFocusPostion(focusValue.get());\r\n+\t\tfocusLens->setFocusPosition(focusValue.get());\r\n \r\n \t\tbreak;\r\n \t}","prefixes":["libcamera-devel"]}