{"id":15386,"url":"https://patchwork.libcamera.org/api/1.1/patches/15386/?format=json","web_url":"https://patchwork.libcamera.org/patch/15386/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220224151113.109858-3-jeanmichel.hautbois@ideasonboard.com>","date":"2022-02-24T15:11:11","name":"[libcamera-devel,v4,2/4] ipa: ipu3: Shorten exposure and gain lines","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"51a285f01f21743de051a8c7c210c0bede25162d","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15386/mbox/","series":[{"id":2940,"url":"https://patchwork.libcamera.org/api/1.1/series/2940/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2940","date":"2022-02-24T15:11:09","name":"ipa: ipu3: Misc clean up","version":4,"mbox":"https://patchwork.libcamera.org/series/2940/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15386/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15386/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21AB9C3261\n\tfor ;\n\tThu, 24 Feb 2022 15:11:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 372196115A;\n\tThu, 24 Feb 2022 16:11:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31C5761145\n\tfor ;\n\tThu, 24 Feb 2022 16:11:19 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBAD8E70;\n\tThu, 24 Feb 2022 16:11:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JGHgLBVl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645715478;\n\tbh=ZDm9VKGFF43duA1wbbFF797P0YbVhnM4JL6qJmSB5V4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JGHgLBVlKc56jczH70m/LK/PVmqbKCwDbtTVzZ9LgcJNRv292RvkDMvVhTjRVo2uT\n\tbq9Han9051zvG6B9vLR+szdi8soj2tkO5D/5Da9WRCiD2VFufYQvvBP0t8RMa548XL\n\ts+9Iwp7FuaorHqnF5ADzrSWx5PgD/JXYaCZ3sNxo=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Feb 2022 16:11:11 +0100","Message-Id":"<20220224151113.109858-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 2/4] ipa: ipu3: Shorten exposure and\n\tgain lines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the effective sensor values are stored during the EventStatReady\nevent, the lines are long. Fix it.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/ipu3.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 3d307708..c0c29416 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -547,8 +547,11 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast(mem.data());\n \n-\t\tcontext_.frameContext.sensor.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n-\t\tcontext_.frameContext.sensor.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n+\t\tint32_t exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n+\t\tint32_t gain = event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get();\n+\n+\t\tcontext_.frameContext.sensor.exposure = exposure;\n+\t\tcontext_.frameContext.sensor.gain = camHelper_->gain(gain);\n \n \t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n","prefixes":["libcamera-devel","v4","2/4"]}