{"id":15362,"url":"https://patchwork.libcamera.org/api/1.1/patches/15362/?format=json","web_url":"https://patchwork.libcamera.org/patch/15362/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","date":"2022-02-12T23:34:07","name":"[libcamera-devel] libcamera: camera_sensor: Do not initialise unsupported test patterns","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"338deac7b2287e3ea84c49d3ecc7ec96af55b165","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15362/mbox/","series":[{"id":2929,"url":"https://patchwork.libcamera.org/api/1.1/series/2929/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2929","date":"2022-02-12T23:34:07","name":"[libcamera-devel] libcamera: camera_sensor: Do not initialise unsupported test patterns","version":1,"mbox":"https://patchwork.libcamera.org/series/2929/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15362/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15362/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53C4BBE08A\n\tfor ;\n\tSat, 12 Feb 2022 23:34:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E70A61109;\n\tSun, 13 Feb 2022 00:34:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CD72610B3\n\tfor ;\n\tSun, 13 Feb 2022 00:34:15 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A6D65D;\n\tSun, 13 Feb 2022 00:34:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rAM30W0E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644708854;\n\tbh=37MdcEUn06WLMCqNjnCAD5V+Dkt55/Ojt3A6Yk+5xQQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=rAM30W0ElqDcqA+AkBQcjoGg0jIYqEg4Xc1TVJhsWhLwZudBQoQ7eb4HGnSH9U/WS\n\th+P2S8PeawnR1yIu1KHnslS7d+JM5++jlVcTr2qPIvIPZj14NOmFNWyXr5Rc5gEu1Q\n\tJ/a82YEFswsG864xYETr2uIi1Ff9nDK0TDJWTqeA=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Sat, 12 Feb 2022 23:34:07 +0000","Message-Id":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"After the CameraSensor class has initialised properties, a default\nsetting is applied to ensure that test pattern modes are disabled unless\nexplicitly requested.\n\nThis does not currently check to see if test patterns are supported on\nthe CameraSensor and the applyTestPatternMode call will report a failure\nif it attempts to set a mode when not supported.\n\nMove the initialisation of the test pattern mode to the implementation\nof the control mappings to ensure that it is correctly reset at start\nup, while the code path will have already completed early if not\nsupported.\n\nBug: https://github.com/raspberrypi/libcamera-apps/issues/249\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/camera_sensor.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 345b4a170d47..3a6a1a6bca77 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -172,7 +172,7 @@ int CameraSensor::init()\n \tif (ret)\n \t\treturn ret;\n \n-\treturn applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n+\treturn 0;\n }\n \n int CameraSensor::validateSensorDriver()\n@@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n \n \t\ttestPatternModes_.push_back(it->second);\n \t}\n+\n+\t/* Initialise the sensor with test patterns disabled. */\n+\tapplyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n }\n \n int CameraSensor::initProperties()\n","prefixes":["libcamera-devel"]}