{"id":15342,"url":"https://patchwork.libcamera.org/api/1.1/patches/15342/?format=json","web_url":"https://patchwork.libcamera.org/patch/15342/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220207151214.887140-3-naush@raspberrypi.com>","date":"2022-02-07T15:12:14","name":"[libcamera-devel,3/3] ipa: raspberrypi: Reduce the controller rate to 30fps","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1499e6bb1bf66419746024c6d68bc1b493d9d63f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15342/mbox/","series":[{"id":2921,"url":"https://patchwork.libcamera.org/api/1.1/series/2921/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2921","date":"2022-02-07T15:12:12","name":"[libcamera-devel,1/3] pipeline: raspberrypi: Allow Stream::returnBuffer() to handle internal buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/2921/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15342/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15342/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB374BF415\n\tfor ;\n\tMon, 7 Feb 2022 15:12:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8BDF61086;\n\tMon, 7 Feb 2022 16:12:21 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 578B16105F\n\tfor ;\n\tMon, 7 Feb 2022 16:12:20 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\tk127-20020a1ca185000000b0037bc4be8713so2324943wme.3\n\tfor ;\n\tMon, 07 Feb 2022 07:12:20 -0800 (PST)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:4a96:1adf:459f:8a7e])\n\tby smtp.gmail.com with ESMTPSA id\n\ti19sm21463085wmq.45.2022.02.07.07.12.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Feb 2022 07:12:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"VcMqomsA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=b+ZMf4eVFVMwWoM8wQemRo2DNOLvFAHjzpnIVlUsGZA=;\n\tb=VcMqomsArDG5ggX5CD68jYsKFJA43PJXI+K4x+ZYQDOd8GDlD4i75MgBjxpvjhWn0B\n\tFxzQwefq0UodfG3rSSy462GbfVVp8H5H5YS1n6/QcmeT9yIqXG27cAajkF3KUQ8JNsH3\n\tBm/VntCNg5r6oym+XNMsnii0wQfsMZeYEshuc8yf2pNhyO9lNxkQzcYtkpWWP2AtI5oW\n\tiZfDAaZdH6oMEg1+GcHZAZnwO7MSzxcb8zWcO1iNYnIgHcqSz18U64e7t0g5Tlxlt9H+\n\tdFNZUMg9LxU5nD8DLsQf9U73T3x6IKRWtTWSqsYtYZQZIWivtGBrpD0CytKTJDzrnBuP\n\tRYoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=b+ZMf4eVFVMwWoM8wQemRo2DNOLvFAHjzpnIVlUsGZA=;\n\tb=Mh3x7wczs5stvLGBF0k2yIP5ofKNP3TXbnHL3RrQdGkevu26Aqy0OO9UCpS+tkjrWj\n\tVBNbssp2fK49U/ObCRudut/dtSY5kxqm/K9Fso+ph5FM36C8TC2P9cmatMbsL1zQW6NU\n\trNaKgCj6f+WMTJbz30kfBMRs+a0Bs1KDriBOycU1Vcy0yr2jsMJQmyZVkvg7k0cVy0ZB\n\tT3/AHRskTIb6l3VYR5grE4yfnaizLGogF9WnEw0ug5UpPNJuxts/wD3cVVAN6GVhnDyn\n\tpIzQW2CrlNztz4mLC6xTAcDC7BNfvBlIo0LBhLhk99L25t7L+uvDJEi+zl7lZCLXs2rY\n\td3cg==","X-Gm-Message-State":"AOAM533ljT+eyb9qgWaIouDCjTY9k64a2V0sgou5pXjO2aNNpl6Bwg57\n\ta6tubjE93FXLiFUidyS3khBFNudx7memlQ==","X-Google-Smtp-Source":"ABdhPJzT972KDBiuVx9lzCi371BC8EZUTIWnwsgHA9gpHF3EGOqWWIF07P/7b710luBs2tasazEh+w==","X-Received":"by 2002:a7b:cb9a:: with SMTP id m26mr24052wmi.18.1644246739861; \n\tMon, 07 Feb 2022 07:12:19 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 7 Feb 2022 15:12:14 +0000","Message-Id":"<20220207151214.887140-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220207151214.887140-1-naush@raspberrypi.com>","References":"<20220207151214.887140-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the\n\tcontroller rate to 30fps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With the controller algorithms running at 60fps, there are some dropped frames\nwhen running at very high famerates. Reducing this to 30fps eliminates all these\ndrops without any noticeable changes to the image quality.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex a72d516f84ee..fd8fecb07f81 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;\n * we rate-limit the controller Prepare() and Process() calls to lower than or\n * equal to this rate.\n */\n-constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;\n+constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n \n LOG_DEFINE_CATEGORY(IPARPI)\n \n","prefixes":["libcamera-devel","3/3"]}