{"id":15281,"url":"https://patchwork.libcamera.org/api/1.1/patches/15281/?format=json","web_url":"https://patchwork.libcamera.org/patch/15281/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220115164434.30763-1-laurent.pinchart@ideasonboard.com>","date":"2022-01-15T16:44:34","name":"[libcamera-devel] test: v4l2_compat: Add --verbose argument","commit_ref":"6b160d91f9fee914fa16e6f36c6384930bea2a5d","pull_url":null,"state":"accepted","archived":false,"hash":"f623c7093c10ec4baeaf847234b437c2a7294ffe","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15281/mbox/","series":[{"id":2894,"url":"https://patchwork.libcamera.org/api/1.1/series/2894/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2894","date":"2022-01-15T16:44:34","name":"[libcamera-devel] test: v4l2_compat: Add --verbose argument","version":1,"mbox":"https://patchwork.libcamera.org/series/2894/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15281/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15281/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFE17BE086\n\tfor ;\n\tSat, 15 Jan 2022 16:44:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D69460868;\n\tSat, 15 Jan 2022 17:44:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FB706017B\n\tfor ;\n\tSat, 15 Jan 2022 17:44:50 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8EC0A24;\n\tSat, 15 Jan 2022 17:44:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cSbeIUXG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1642265090;\n\tbh=pvL2FinqixLdbgwBbmVGXyfxlXQYHUZYDP07v1fTJ+w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=cSbeIUXGJNiVyAASZDuDl4fVI/NRGpUloCu3lwTUnQfbvAtTfoOpwZ8VhmMPCHqT9\n\tFtHbURBhpqOOyg0Hl18QJWec0gOU7FVprCCBWatsPD757BdztZsl3ky+V5f8CmMhFD\n\tWfRSet1WOMLrAGoGI/NvO1aSZ/fx9IzDzMeWS9Wo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 15 Jan 2022 18:44:34 +0200","Message-Id":"<20220115164434.30763-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] test: v4l2_compat: Add --verbose argument","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a -v/--verbose argument to the v4l2_compat test to print the output\nof v4l2-compliance, even when the test passes. This can be useful when\ndebugging.\n\nSigned-off-by: Laurent Pinchart \n---\n test/v4l2_compat/v4l2_compat_test.py | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 29c25974c1c9..a77585fc2f49 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -65,7 +65,7 @@ def test_v4l2_compliance(v4l2_compliance, v4l2_compat, device, base_driver):\n \n result = extract_result(output[-2])\n if result['failed'] == 0:\n- return TestPass, None\n+ return TestPass, output\n \n # vimc will fail s_fmt because it only supports framesizes that are\n # multiples of 3\n@@ -73,7 +73,7 @@ def test_v4l2_compliance(v4l2_compliance, v4l2_compat, device, base_driver):\n failures = grep('fail', output)\n if re.search('S_FMT cannot handle an invalid format', failures[0]) is None:\n return TestFail, output\n- return TestPass, None\n+ return TestPass, output\n \n return TestFail, output\n \n@@ -82,6 +82,8 @@ def main(argv):\n parser = argparse.ArgumentParser()\n parser.add_argument('-a', '--all', action='store_true',\n help='Test all available cameras')\n+ parser.add_argument('-v', '--verbose', action='store_true',\n+ help='Make the output verbose')\n parser.add_argument('v4l2_compat', type=str,\n help='Path to v4l2-compat.so')\n args = parser.parse_args(argv[1:])\n@@ -146,9 +148,12 @@ def main(argv):\n if ret == TestFail:\n failed.append(device)\n print('failed')\n- print('\\n'.join(msg))\n else:\n print('success')\n+\n+ if ret == TestFail or args.verbose:\n+ print('\\n'.join(msg))\n+\n drivers_tested[driver] = True\n \n if len(drivers_tested) == 0:\n","prefixes":["libcamera-devel"]}