{"id":15273,"url":"https://patchwork.libcamera.org/api/1.1/patches/15273/?format=json","web_url":"https://patchwork.libcamera.org/patch/15273/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220111202838.586-1-laurent.pinchart@ideasonboard.com>","date":"2022-01-11T20:28:38","name":"[libcamera-devel] v4l2: v4l2_camera_proxy: Zero flags in VIDIOC_REQBUFS","commit_ref":"bc3d27234ed90924ae200a916afb97d1945912d5","pull_url":null,"state":"accepted","archived":false,"hash":"ad5ab6ba0210de3a79efc00e12ef5430db163076","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15273/mbox/","series":[{"id":2890,"url":"https://patchwork.libcamera.org/api/1.1/series/2890/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2890","date":"2022-01-11T20:28:38","name":"[libcamera-devel] v4l2: v4l2_camera_proxy: Zero flags in VIDIOC_REQBUFS","version":1,"mbox":"https://patchwork.libcamera.org/series/2890/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15273/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15273/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 584FDBE080\n\tfor ;\n\tTue, 11 Jan 2022 20:29:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB21E604F4;\n\tTue, 11 Jan 2022 21:29:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5555F60217\n\tfor ;\n\tTue, 11 Jan 2022 21:29:03 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84DD0340;\n\tTue, 11 Jan 2022 21:29:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GyLHffOj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641932942;\n\tbh=5TGm/IdgBpWifpR6/yzltKe4g/W/T1jJr8iVnIZxvdg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GyLHffOj1IPQJgACHm8BnUaji8qmcUv94lhICg3LeJAkEO9IcB1ukGp0ldPtGEc45\n\tRlDZnf5wqvPraRycJT06LehWvIZB7bhupOetYRk3ZuGqG95ZMvmtV8YvIos3bDpehr\n\tt+QHWa0xA+WKoSXx31/3V1u1iPGjGakWnu0q06+U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Jan 2022 22:28:38 +0200","Message-Id":"<20220111202838.586-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Zero flags in\n\tVIDIOC_REQBUFS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2 compatibility layer doesn't support any of the VIDIOC_REQBUFS\nflags. They are all correctly ignored, but also need to be zeroed\nbefore returning to indicate that they haven't been taken into account.\n\nThis fixes a v4l2-compliance failure:\n\nBuffer ioctls (Input 0):\n fail: ../../utils/v4l2-compliance/v4l2-test-buffers.cpp(682): coherent\n test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL\n\nFixes: aa4533639971 (\"include: linux: Update kernel headers to version v5.16-rc7\")\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/v4l2_camera_proxy.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: eff9de397ac37e948e5ca603814fcaba9bcd8df5","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 4d529bc29a4d..1802d90bf30b 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -469,6 +469,7 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \t\treturn -EBUSY;\n \n \targ->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP;\n+\targ->flags = 0;\n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n \tif (arg->count == 0) {\n","prefixes":["libcamera-devel"]}