{"id":15246,"url":"https://patchwork.libcamera.org/api/1.1/patches/15246/?format=json","web_url":"https://patchwork.libcamera.org/patch/15246/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","date":"2022-01-04T23:26:57","name":"[libcamera-devel] libcamera: pkg-config: Do not hardcode version","commit_ref":"cd7863503ae91f477bbd883f35d9845172840349","pull_url":null,"state":"accepted","archived":false,"hash":"a5019921b5cd6da21493101ec1a04985a471a3b7","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15246/mbox/","series":[{"id":2877,"url":"https://patchwork.libcamera.org/api/1.1/series/2877/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2877","date":"2022-01-04T23:26:57","name":"[libcamera-devel] libcamera: pkg-config: Do not hardcode version","version":1,"mbox":"https://patchwork.libcamera.org/series/2877/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15246/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15246/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48132BE080\n\tfor ;\n\tTue, 4 Jan 2022 23:27:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A775360921;\n\tWed, 5 Jan 2022 00:27:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A69B6021A\n\tfor ;\n\tWed, 5 Jan 2022 00:27:01 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3B35501;\n\tWed, 5 Jan 2022 00:27:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wct6q1Rk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641338821;\n\tbh=UZ9GTHpa7g/ap5a0qlN4tjf36BupmSDNwROqd15hTek=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=wct6q1Rkuurrj8+H+Mdx+bKiXjm5s+5WuRK5/Nin8DFSI7UHOJvDUdbVyNNSZRDYu\n\tfT3Mb0SWFfzRUN05H+BR5sBeQSMtNkxiCmqBiQV3tC8tkR2S0zHfzU8o3mA8y+jf/H\n\tjB6a6KpgdW4UFSC4TqXYy1pAwCHwXqw8wwtIEXdA=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 4 Jan 2022 23:26:57 +0000","Message-Id":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pkg-config: Do not hardcode\n\tversion","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The pkg-config version should not be hardcoded, and it should match the\nversion of the library, ideally with point releases where possible.\n\nSigned-off-by: Kieran Bingham \n---\n\nWith this patch, the pkg-config libcamera.pc will report\n Version: 0.0.0\nAs defined by our meson project instead of \n Version: 1.0\n\n src/libcamera/base/meson.build | 1 -\n src/libcamera/meson.build | 1 -\n 2 files changed, 2 deletions(-)","diff":"diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\nindex 0ae3b0aab7e2..7030ad1f5927 100644\n--- a/src/libcamera/base/meson.build\n+++ b/src/libcamera/base/meson.build\n@@ -65,7 +65,6 @@ libcamera_base = declare_dependency(sources : [\n \n pkg_mod = import('pkgconfig')\n pkg_mod.generate(libcamera_base_lib,\n- version : '1.0',\n description : 'Camera support base utility library',\n subdirs : 'libcamera')\n \ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 7ae909d47fe5..26912ca17819 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -162,7 +162,6 @@ libcamera_private = declare_dependency(sources : [\n pkg_mod = import('pkgconfig')\n pkg_mod.generate(libcamera,\n libraries : libcamera_base_lib,\n- version : '1.0',\n description : 'Complex Camera Support Library',\n subdirs : 'libcamera')\n \n","prefixes":["libcamera-devel"]}