{"id":15237,"url":"https://patchwork.libcamera.org/api/1.1/patches/15237/?format=json","web_url":"https://patchwork.libcamera.org/patch/15237/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220103170956.323025-4-umang.jain@ideasonboard.com>","date":"2022-01-03T17:09:55","name":"[libcamera-devel,3/4] ipa: ipu3: Mark the beginning and end of a frame","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"db683751951f3c3cde7b4b47f0da154506d97fe2","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15237/mbox/","series":[{"id":2873,"url":"https://patchwork.libcamera.org/api/1.1/series/2873/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2873","date":"2022-01-03T17:09:52","name":"IPAIPU3 - Rework interface and introduce context","version":1,"mbox":"https://patchwork.libcamera.org/series/2873/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15237/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15237/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03A6FC3258\n\tfor ;\n\tMon, 3 Jan 2022 17:10:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6ABD3608E9;\n\tMon, 3 Jan 2022 18:10:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBCBC604F4\n\tfor ;\n\tMon, 3 Jan 2022 18:10:15 +0100 (CET)","from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3e:193e:9a73:f356:8c6a:a1aa])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8E4DE57;\n\tMon, 3 Jan 2022 18:10:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bwt+vSLD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641229815;\n\tbh=7Um9WZFfBnDVnoqeIk6skONFCu4zOkLwAMXZZWy0xVU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Bwt+vSLD07i54b/arA0Snw122dAVYH+GqBuw+jhrcCLUV6yMHp+oyU280DgRE4e79\n\t3mSPFEOimhLX+wt5WqW6ATqRDXQEcB5fuDOsN/niBu3+7skj0HsdeUiVVT924+JmNV\n\tmrj3Kzt7ye3vlF+w1yKh2Uah97yeOSJCSzdYDmk4=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 Jan 2022 22:39:55 +0530","Message-Id":"<20220103170956.323025-4-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220103170956.323025-1-umang.jain@ideasonboard.com>","References":"<20220103170956.323025-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/4] ipa: ipu3: Mark the beginning and end\n\tof a frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jean-Michel Hautbois \n\nIntroduce the skeleton for two functions which will be used to\ninstantiate a frame context, and do everything needed when a frame is\nreceived. Do the same for the other end, once the algorithms have run\nand updated the frame context to later deallocate the corresponding\nframe context.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nSigned-off-by: Umang Jain \n---\n src/ipa/ipu3/ipu3.cpp | 33 +++++++++++++++++++++++++++++++++\n 1 file changed, 33 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 4f03d7e9..fa40c41f 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -162,6 +162,14 @@ private:\n \tvoid setControls(unsigned int frame);\n \tvoid calculateBdsGrid(const Size &bdsOutputSize);\n \n+\t/*\n+\t * Internal events that mark the beginning of processing a new frame\n+\t * to the point that it has successfully completed processing its\n+\t * statistics.\n+\t */\n+\tvoid frameStarted(const uint32_t frame);\n+\tvoid frameCompleted(const uint32_t frame);\n+\n \tstd::map buffers_;\n \n \tControlInfoMap ctrls_;\n@@ -508,6 +516,14 @@ void IPAIPU3::unmapBuffers(const std::vector &ids)\n \t}\n }\n \n+void IPAIPU3::frameStarted([[maybe_unused]] const uint32_t frame)\n+{\n+}\n+\n+void IPAIPU3::frameCompleted([[maybe_unused]] const uint32_t frame)\n+{\n+}\n+\n /**\n * \\brief Prepare the ISP to process the Request\n * \\param[in] frame The frame number\n@@ -566,6 +582,15 @@ void IPAIPU3::processControls(const uint32_t frame,\n \t\t\t [[maybe_unused]] const ControlList &controls)\n {\n \t/* \\todo Start processing for 'frame' based on 'controls'. */\n+\n+\t/*\n+\t * To save incurring extra IPC calls, we do not send explicit events\n+\t * when a new request is started or completed.\n+\t * ProcessControls is the first event handled upon receipt of a new\n+\t * request, so we can handle all actions required to start processing\n+\t * a new frame.\n+\t */\n+\tframeStarted(frame);\n }\n \n /**\n@@ -635,6 +660,14 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \t */\n \n \tmetadataReady.emit(frame, ctrls);\n+\n+\t/*\n+\t * To save incurring extra IPC calls, we do not send explicit events\n+\t * when we have completed all handling of a request.\n+\t * Once the statistics are fully processed, we will no longer handle this\n+\t * frame.\n+\t */\n+\tframeCompleted(frame);\n }\n \n /**\n","prefixes":["libcamera-devel","3/4"]}