{"id":15232,"url":"https://patchwork.libcamera.org/api/1.1/patches/15232/?format=json","web_url":"https://patchwork.libcamera.org/patch/15232/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211229222258.12691-1-laurent.pinchart@ideasonboard.com>","date":"2021-12-29T22:22:58","name":"[libcamera-devel] libcamera: controls: Use ASSERT() instead of assert()","commit_ref":"46b32fa0e48aed16778c6e8d324d65473fbd06b7","pull_url":null,"state":"accepted","archived":false,"hash":"1d7020da69bee2e77ee13722176c35087e8e81f1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15232/mbox/","series":[{"id":2871,"url":"https://patchwork.libcamera.org/api/1.1/series/2871/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2871","date":"2021-12-29T22:22:58","name":"[libcamera-devel] libcamera: controls: Use ASSERT() instead of assert()","version":1,"mbox":"https://patchwork.libcamera.org/series/2871/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15232/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15232/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80C40BE080\n\tfor ;\n\tWed, 29 Dec 2021 22:23:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D072D608FF;\n\tWed, 29 Dec 2021 23:23:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D90F2608E9\n\tfor ;\n\tWed, 29 Dec 2021 23:23:03 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BD9333F\n\tfor ;\n\tWed, 29 Dec 2021 23:23:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OfgsrXQo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640816583;\n\tbh=eL782lyImlywaX2y8Jbl+1oCzi8DU896wqOMrjNqtGE=;\n\th=From:To:Subject:Date:From;\n\tb=OfgsrXQoC7/mCilxBrpavVD81kqqq4X7kzG1ypLfChT5q9rH29pnBOVqOtxWJqMfz\n\tAh1pblMABmPc4mTEV+yrDNvrbCdWlJyQnwmP8fRcIsDnckunBVOj7ssa9czPjZu5SR\n\t7CpljviVhKvn0jtc6MBN7KKikuJ4+agx9gbaKGNQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Dec 2021 00:22:58 +0200","Message-Id":"<20211229222258.12691-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: controls: Use ASSERT() instead\n\tof assert()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ASSERT() macro integrates with the logging infrastructure, use it to\nreplace assert().\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/controls.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 030e6f389e2d0fa3f10a47634f3609378ccaf70e\nprerequisite-patch-id: 2c7bab8c8f15090cf10a19aaed62e33de1264351\nprerequisite-patch-id: 10478d16a049f895236c9b7bafcbe6d3a9b69ef9\nprerequisite-patch-id: f6f3784841cc8648c6b6cfdd12b7903751856f75\nprerequisite-patch-id: 41c39d0df627b7c1856cc8bc4d099f408983d6cd\nprerequisite-patch-id: 80397d3462f248e4ca0e9f3bcb2d793178b03142\nprerequisite-patch-id: 490c8f45203ef4d2281bddf2b36855ed99e1b2a4\nprerequisite-patch-id: 06537d8dd2471934bca5772ddb6556a85a32ee9c\nprerequisite-patch-id: e1c7842e5c488f6d3790a9c45b69974d8624dce4\nprerequisite-patch-id: 55a68f42975a115ab642766965a5e6c8f2c07026\nprerequisite-patch-id: 8601bcfa3c7da8d9984ac08e182610b5b52cbba9\nprerequisite-patch-id: 8bb54baf7b5a46c0d14606c2f1020e943633954e\nprerequisite-patch-id: f9b1926bdaa91bb4879b8e28f6849df8d6a9ae64\nprerequisite-patch-id: 2c928f3693350ad60bff02897240e379ab8fab1a","diff":"diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 0d8c0a5c39c9..03ac6345247c 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -527,7 +527,7 @@ ControlInfo::ControlInfo(Span values,\n ControlInfo::ControlInfo(std::set values, bool def)\n \t: min_(false), max_(true), def_(def), values_({ false, true })\n {\n-\tassert(values.count(def) && values.size() == 2);\n+\tASSERT(values.count(def) && values.size() == 2);\n }\n \n /**\n","prefixes":["libcamera-devel"]}