{"id":15227,"url":"https://patchwork.libcamera.org/api/1.1/patches/15227/?format=json","web_url":"https://patchwork.libcamera.org/patch/15227/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","date":"2021-12-28T21:59:47","name":"[libcamera-devel,v1,1/5] v4l2: v4l2_compat_manager: Print path and fd in openat()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"36b5033f9ab34cd95d377bc3e621da605e1e5081","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15227/mbox/","series":[{"id":2870,"url":"https://patchwork.libcamera.org/api/1.1/series/2870/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2870","date":"2021-12-28T21:59:46","name":"libcamera: Improve debug messages in V4L2 compat layer","version":1,"mbox":"https://patchwork.libcamera.org/series/2870/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15227/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15227/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A52FBF415\n\tfor ;\n\tTue, 28 Dec 2021 22:00:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8ADFB60913;\n\tTue, 28 Dec 2021 22:59:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBD73608E9\n\tfor ;\n\tTue, 28 Dec 2021 22:59:57 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6203E895\n\tfor ;\n\tTue, 28 Dec 2021 22:59:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UbClrQaV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640728797;\n\tbh=3I3vAIHb+uMi8YL3WHkzjPZoLjHt0cqbeCgCRKbR1Jw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UbClrQaVBKFcoADjT6mgtdjtfhCAlBxxPo9+oaOa89KUhJ751MbkkAr6Q7bByUXd7\n\tU0O8V29OE73is/xpQYguaZSwzxIOlnoa+0zt+hIOfaqaQV0cHjOz/3E1HqbF4Lmnte\n\thAzPOAlKVPd4Bu6g8JfyRHNdGvBTSpNm2X7r+bWk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 28 Dec 2021 23:59:47 +0200","Message-Id":"<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.33.1","In-Reply-To":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>","References":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager: Print\n\tpath and fd in openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2 compat layer prints debug messages that mention the file\ndescriptor of the video device, but no message that links the device\npath to the file descriptor. Fix it by adding a debug message in\nopenat().\n\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/v4l2_compat_manager.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\nindex 690a191fe2bf..c64cdb862489 100644\n--- a/src/v4l2/v4l2_compat_manager.cpp\n+++ b/src/v4l2/v4l2_compat_manager.cpp\n@@ -158,6 +158,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n \tV4L2CameraProxy *proxy = proxies_[ret].get();\n \tfiles_.emplace(efd, std::make_shared(efd, oflag & O_NONBLOCK, proxy));\n \n+\tLOG(V4L2Compat, Debug) << \"Opened \" << path << \" -> fd \" << efd;\n \treturn efd;\n }\n \n","prefixes":["libcamera-devel","v1","1/5"]}