{"id":15173,"url":"https://patchwork.libcamera.org/api/1.1/patches/15173/?format=json","web_url":"https://patchwork.libcamera.org/patch/15173/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211220232629.1485890-3-paul.elder@ideasonboard.com>","date":"2021-12-20T23:26:25","name":"[libcamera-devel,v2,2/6] android: camera_capabilities: Set read sensor settings capability","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3ba74045d569f0b9c79d31899a054483282f2633","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15173/mbox/","series":[{"id":2848,"url":"https://patchwork.libcamera.org/api/1.1/series/2848/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2848","date":"2021-12-20T23:26:23","name":"android: Miscellaneous fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/2848/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15173/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15173/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5980BE080\n\tfor ;\n\tMon, 20 Dec 2021 23:26:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC76A608A2;\n\tTue, 21 Dec 2021 00:26:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 679A960868\n\tfor ;\n\tTue, 21 Dec 2021 00:26:46 +0100 (CET)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 531BA881;\n\tTue, 21 Dec 2021 00:26:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gq7Os8lB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640042806;\n\tbh=cM+1AIJ2vM69L80j+c++pEO03MKvd7KsedbCkZuR86E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Gq7Os8lBYtPt1GyyWoLyoIqFgdJhtOaV8YYaN6vBmUDofNYK+GOF5MKtIIJ/LOIF1\n\t0xiu6Dj1sTEC4cylOUNcuTjJEZLkyRjDTk1gfiIkIUTgWbzUsPM0wrUsOA64ZIX1rS\n\tudik+Xff9oXUM5YpX908v+1SWj6Xv07KfQh3xIC4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Dec 2021 17:26:25 -0600","Message-Id":"<20211220232629.1485890-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/6] android: camera_capabilities: Set\n\tread sensor settings capability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A libcamera camera that supports the manual sensor capability also\nsatisfies all the requirements for the read sensor settings capability.\nSet it.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \n---\n src/android/camera_capabilities.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6ae2cd4d..6d383486 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -339,8 +339,11 @@ CameraCapabilities::computeCapabilities()\n \n \tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);\n \n-\tif (validateManualSensorCapability())\n+\tif (validateManualSensorCapability()) {\n \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n+\t\t/* The libcamera requirements cover this */\n+\t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_READ_SENSOR_SETTINGS);\n+\t}\n \n \tif (validateManualPostProcessingCapability())\n \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n","prefixes":["libcamera-devel","v2","2/6"]}