{"id":15158,"url":"https://patchwork.libcamera.org/api/1.1/patches/15158/?format=json","web_url":"https://patchwork.libcamera.org/patch/15158/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211213232849.40071-4-djrscally@gmail.com>","date":"2021-12-13T23:28:47","name":"[libcamera-devel,3/5] media: entity: Skip non-data links in graph iteration","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"c2b0302cd73e311dcd3139ad18be31bccaf5e718","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/1.1/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15158/mbox/","series":[{"id":2843,"url":"https://patchwork.libcamera.org/api/1.1/series/2843/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2843","date":"2021-12-13T23:28:44","name":"Introduce ancillary links","version":1,"mbox":"https://patchwork.libcamera.org/series/2843/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15158/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15158/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A3F7C324B\n\tfor ;\n\tMon, 13 Dec 2021 23:29:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5E046088C;\n\tTue, 14 Dec 2021 00:29:10 +0100 (CET)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9A5E60822\n\tfor ;\n\tTue, 14 Dec 2021 00:29:07 +0100 (CET)","by mail-wr1-x42b.google.com with SMTP id d24so29772502wra.0\n\tfor ;\n\tMon, 13 Dec 2021 15:29:07 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t38sm12551643wrc.1.2021.12.13.15.29.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Dec 2021 15:29:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fxhgQRcO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=YXsT7zHvatos7XfOBq5N+1fMVdHFdvEUedxZf+J7ouc=;\n\tb=fxhgQRcO3QjWRe/SJ1N8l/dwU94LkdYqBNc73Z3DonjM/hF0CBPS6bIUTinqONJnXI\n\tFj5JsTofGIe+mNUj6MQXrhokJ2L1DAfmIgbzO/WhCbm/uwn3CHeW3TXGJl7UtqoNK/iF\n\t7kVRRs3FARTEZys1ICGAWvwTag8auTAosg3Qf0J/BTFoSBBEuobmLZX41x4uzJD6gUh2\n\tFIxSe/OLhu40D6B440Xgza0J7zTMhEeYrIuWepq3S4c4valO3XRg6q1roCx58dQC7ksn\n\tBtd+CWgDx96LGsAJ467f2/fUXnsdy0Tl5mFTmovBRiwD6z3P/OwoEAU6GP0BB8aEtrWf\n\tzuOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=YXsT7zHvatos7XfOBq5N+1fMVdHFdvEUedxZf+J7ouc=;\n\tb=GpiHWBRP5OPa1M068KkX/ltd5mwxRk6nBXCOxbIaFGoISV83WKRmDzNwrTs6T9GI2Y\n\tpWqtiAYiF1t9bx+cjsDDPqxVNIDFWqLxCkkqk9rkdabiYjZSlRjH/DPKUYTiaMZ4Ndm9\n\tPwx2paziglgNfVbd8Pb/Op/vKPzf1Jft9492OgSomuY7uU2uuQctaxhQ6y8sDY0smwme\n\tEjU84H1Q2OYTcOO0OkKZ12Uj2sYDaNKLEw+H+1AAiA9dHIBZuT66hhorQUUJ6ZuDJdEn\n\tNd2E4i8xhsGP28cLbyJW3bnF+PBfwwl2DeBZeMEIoUNxXEzsEts4E/rsLoc9XTX/Qwvc\n\tXSjw==","X-Gm-Message-State":"AOAM533c5/CQQ3U0Q5+9AyO+MPRIupxbkot1uL/dN42/E1/c69KetqwQ\n\tdlZBsR1gfFsz0YjtHg1o5Rs=","X-Google-Smtp-Source":"ABdhPJxeFbxUyR8zW1g6fsTTqYu59SfX5eNdc/kncZmO/Gws0iR95QnRUxeRMq/ihdiJnI3MIsHU4Q==","X-Received":"by 2002:adf:f504:: with SMTP id q4mr1724215wro.698.1639438147393;\n\tMon, 13 Dec 2021 15:29:07 -0800 (PST)","From":"Daniel Scally ","To":"linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Dec 2021 23:28:47 +0000","Message-Id":"<20211213232849.40071-4-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20211213232849.40071-1-djrscally@gmail.com>","References":"<20211213232849.40071-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/5] media: entity: Skip non-data links in\n\tgraph iteration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When iterating over the media graph, don't follow links that are not\npad-to-pad links.\n\nSigned-off-by: Daniel Scally \n---\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex d79eb88bc167..aeddc3f6310e 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -325,6 +325,14 @@ static void media_graph_walk_iter(struct media_graph *graph)\n \n \tlink = list_entry(link_top(graph), typeof(*link), list);\n \n+\t/* If the link is not a pad-to-pad link, don't follow it */\n+\tif ((link->flags & MEDIA_LNK_FL_LINK_TYPE) != MEDIA_LNK_FL_DATA_LINK) {\n+\t\tlink_top(graph) = link_top(graph)->next;\n+\t\tdev_dbg(entity->graph_obj.mdev->dev, \"walk: skipping %s link\\n\",\n+\t\t\tlink_type(link));\n+\t\treturn;\n+\t}\n+\n \t/* The link is not enabled so we do not follow. */\n \tif (!(link->flags & MEDIA_LNK_FL_ENABLED)) {\n \t\tlink_top(graph) = link_top(graph)->next;\n","prefixes":["libcamera-devel","3/5"]}