{"id":15157,"url":"https://patchwork.libcamera.org/api/1.1/patches/15157/?format=json","web_url":"https://patchwork.libcamera.org/patch/15157/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211213232849.40071-3-djrscally@gmail.com>","date":"2021-12-13T23:28:46","name":"[libcamera-devel,2/5] media: entity: Add link_type() helper","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"37e1a400b3b68625b72765e545df4ad092aa5251","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/1.1/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15157/mbox/","series":[{"id":2843,"url":"https://patchwork.libcamera.org/api/1.1/series/2843/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2843","date":"2021-12-13T23:28:44","name":"Introduce ancillary links","version":1,"mbox":"https://patchwork.libcamera.org/series/2843/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15157/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15157/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 733ADBF415\n\tfor ;\n\tMon, 13 Dec 2021 23:29:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDBD56089F;\n\tTue, 14 Dec 2021 00:29:09 +0100 (CET)","from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1FEE6087E\n\tfor ;\n\tTue, 14 Dec 2021 00:29:06 +0100 (CET)","by mail-wr1-x42f.google.com with SMTP id u1so29549978wru.13\n\tfor ;\n\tMon, 13 Dec 2021 15:29:06 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t38sm12551643wrc.1.2021.12.13.15.29.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Dec 2021 15:29:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fpit3Yup\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MgCtKC+Gd7kApujFsuR5TW5hz/ErAzIhf2rX5Pgmy5o=;\n\tb=fpit3YupVLRQCsiBB98paZPY/vws70ChOL/XADsgVF+afDYelu3wOsyXvfZp07Yf7o\n\tndFBw+WRAtNMGJBYbZFUGgwLGzlp4qHkCjIYn04iy9f72bbyrJd/AUrbcGn2TM7XLNyU\n\t+cDf7APM95/8gyD9ibCDD59KxHrOJBokmhdBLlGPOOZy576lD2EEOZLKx2RggT01inI6\n\tOsxdBUsGarGkvz9cqyR8hDzHL/ZGYDj+GFjPyEPdjDACCx9tyH8pVdmlI4OUaH4hD2UG\n\tNL5vpAuXU613PQv6iRCmiz81P7QZdJMaVrVJCvhxUVJaHeuCC/mNtOHGDFCMrkGJh/mM\n\tNIXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MgCtKC+Gd7kApujFsuR5TW5hz/ErAzIhf2rX5Pgmy5o=;\n\tb=LGkp5Ak+59HX5kcIFIdXHknrl56pr7ztEH2gtEyV1ZAxYe5MCrCtzxwxPgpL0tpfYX\n\tuH4DdlsmM/AxgHieWIaN8YKLtmww/lROQ+rIqZVsXe7nFipFL8j+754roTFok6dI+qCy\n\tuQGHItiX/l1VeNd8Uwj/LBGdlNB2RkVW38Ohvt+qacK2ZTOm8OzS6ecxkq4mxJ+u/dtZ\n\tLgyD+wtxwcu2wTEx0H1kKA19PyWCzxwjAXd3kYukSUHq0FgdCFa8wK9YXIkszWHkxn39\n\tbqOr9tUOthTHz3YKvxUJW6sm5kaIpif78lOKlArXmkW6zRmE6CrE8x2MxIwGkjWpdXfK\n\tslwg==","X-Gm-Message-State":"AOAM533jD7r1oHIa/wjyjVlApGTufuleEMkC1dQUF1ymfxYTe2IV6b32\n\t7vp/BfUrfdM5zF8Frc20Gl4=","X-Google-Smtp-Source":"ABdhPJx3yb6CKioC+of69sRZt9ZhFjNno0BY3/9Z+rr7mxoEowwx35RVewqpHNlQ6z/8uOlnrGS03g==","X-Received":"by 2002:adf:900f:: with SMTP id\n\th15mr1736128wrh.562.1639438146517; \n\tMon, 13 Dec 2021 15:29:06 -0800 (PST)","From":"Daniel Scally ","To":"linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Dec 2021 23:28:46 +0000","Message-Id":"<20211213232849.40071-3-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20211213232849.40071-1-djrscally@gmail.com>","References":"<20211213232849.40071-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] media: entity: Add link_type() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now we have three types of media link, printing the right name during\ndebug output is slightly more complicated. Add a helper function to\nmake it easier.\n\nSigned-off-by: Daniel Scally \n---\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex f40f41977142..d79eb88bc167 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -60,6 +60,20 @@ static inline const char *intf_type(struct media_interface *intf)\n \t}\n };\n \n+static inline const char *link_type(struct media_link *link)\n+{\n+\tswitch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {\n+\tcase MEDIA_LNK_FL_DATA_LINK:\n+\t\treturn \"data\";\n+\tcase MEDIA_LNK_FL_INTERFACE_LINK:\n+\t\treturn \"interface\";\n+\tcase MEDIA_LNK_FL_ANCILLARY_LINK:\n+\t\treturn \"ancillary\";\n+\tdefault:\n+\t\treturn \"unknown\";\n+\t}\n+}\n+\n __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,\n \t\t\t\t\t int idx_max)\n {\n@@ -107,9 +121,7 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj)\n \n \t\tdev_dbg(gobj->mdev->dev,\n \t\t\t\"%s id %u: %s link id %u ==> id %u\\n\",\n-\t\t\tevent_name, media_id(gobj),\n-\t\t\tmedia_type(link->gobj0) == MEDIA_GRAPH_PAD ?\n-\t\t\t\t\"data\" : \"interface\",\n+\t\t\tevent_name, media_id(gobj), link_type(link),\n \t\t\tmedia_id(link->gobj0),\n \t\t\tmedia_id(link->gobj1));\n \t\tbreak;\n","prefixes":["libcamera-devel","2/5"]}