{"id":15117,"url":"https://patchwork.libcamera.org/api/1.1/patches/15117/?format=json","web_url":"https://patchwork.libcamera.org/patch/15117/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211210144424.14747-5-david.plowman@raspberrypi.com>","date":"2021-12-10T14:44:20","name":"[libcamera-devel,v12,4/8] libcamera: video_device: Support passing ColorSpaces to V4L2 video devices","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1e9b539403d9e5d985613a1f9de4c65bad401a45","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15117/mbox/","series":[{"id":2835,"url":"https://patchwork.libcamera.org/api/1.1/series/2835/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2835","date":"2021-12-10T14:44:16","name":"Colour spaces","version":12,"mbox":"https://patchwork.libcamera.org/series/2835/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15117/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15117/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4D67BF415\n\tfor ;\n\tFri, 10 Dec 2021 14:44:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 687466089A;\n\tFri, 10 Dec 2021 15:44:44 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6377608A2\n\tfor ;\n\tFri, 10 Dec 2021 15:44:39 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id u17so15331566wrt.3\n\tfor ;\n\tFri, 10 Dec 2021 06:44:39 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tw22sm3000515wmi.27.2021.12.10.06.44.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 Dec 2021 06:44:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZKSRMZ81\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sa0O0O7qhAIzGiKmiVtW9p2VAUFKzxTft78J+gwVYZU=;\n\tb=ZKSRMZ812M7va0ljUZfIc2hblrq9h+hm0K+5QLVdq8Mghd9Jq/kJj7UlxAoPeIH6k8\n\tRqxIyeSoolx36FEoMPYJL6Hd2bo9Ze8CSdlA2LvfnjAmuOClePl1MCPu/HXLMPOIvRh4\n\tdP/WZZdrFCja0tvCrATZ8SN/zCcPNib/j7MZXzlcxrM5B2kvsykNjzlMneQg2eMdqMrQ\n\t56mhVsk/myGiIjfRAdF/RL/KrN6+uVjDtMthqI+mSo6Vp/TyVNiXf05Sup0sDRih/9wg\n\thCoT2l1ku6/Yb9VJK5/DmyTxqhIAy2L3juJRLHBe3X3Y7uvnR80sO/r2wxg0qNdMPpEB\n\txVYw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sa0O0O7qhAIzGiKmiVtW9p2VAUFKzxTft78J+gwVYZU=;\n\tb=Yob3aYqDedX0d1De7GYuZe0LokRZTeE8+qNL7uU97bVNpjhl2477coN1ygqhzbZ1kt\n\tDVuqL+ETmi08jrcExpBOAiT0fMdX9K8gkmHa5QbQfJo1u5wHYlB/OMGEvQsnBu3XNdUH\n\tG+v2O25dnuTjtEgkEJIBcrJCuAV2ooyEZKE/Git0VQxSyCc3eRcSQ9sWEZNvpBgnV+7Q\n\tvTIc/s65XIdwoT74uiMan/J3GIT6niFNIhtvL1uWSaZ9K5V6eiqWgnD1GXNK0RyUqSTZ\n\tntenmo/0GsVGACNwSfHpHv5sPS+rzMVlNsTSmo+XxwGmj5l+mjwqYEIvnriyNCyxWpWU\n\tRiRA==","X-Gm-Message-State":"AOAM533ErmIaYDrXwINuAMfSfBm8vyH/+xqrquYY6mixpNgbyCTX3B3W\n\tiArvw65N3ua5jWcPsl/onVqC+Q==","X-Google-Smtp-Source":"ABdhPJyjIdO2zfCvNRKOmZFiZ82ca+J1OjQ7GqUWziJH58rfHYWeWqq62sKtFYQENQzUm+8EcX5H4A==","X-Received":"by 2002:a5d:6244:: with SMTP id\n\tm4mr14792682wrv.186.1639147479467; \n\tFri, 10 Dec 2021 06:44:39 -0800 (PST)","From":"David Plowman ","To":"Laurent Pinchart ,\n\tKieran Bingham ,\n\tHans Verkuil , Tomasz Figa , \n\tJacopo Mondi ,\n\tNaushir Patuck , \n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 Dec 2021 14:44:20 +0000","Message-Id":"<20211210144424.14747-5-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211210144424.14747-1-david.plowman@raspberrypi.com>","References":"<20211210144424.14747-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v12 4/8] libcamera: video_device: Support\n\tpassing ColorSpaces to V4L2 video devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ColorSpace from the StreamConfiguration is now handled\nappropriately in the V4L2VideoDevice.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/v4l2_videodevice.h | 3 +++\n src/libcamera/v4l2_videodevice.cpp | 22 +++++++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 9b2ec3af..2d2ccc47 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -10,6 +10,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -21,6 +22,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n #include \n@@ -167,6 +169,7 @@ public:\n \n \tV4L2PixelFormat fourcc;\n \tSize size;\n+\tstd::optional colorSpace;\n \n \tstd::array planes;\n \tunsigned int planesCount = 0;\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex b4b89e27..5f36ee20 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -383,6 +383,21 @@ bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer) const\n * that identifies the image format pixel encoding scheme.\n */\n \n+/**\n+ * \\var V4L2DeviceFormat::colorSpace\n+ * \\brief The color space of the pixels\n+ *\n+ * The color space of the image. When setting the format this may be\n+ * unset, in which case the driver gets to use its default color space.\n+ * After being set, this value should contain the color space that\n+ * was actually used. If this value is unset, then the color space chosen\n+ * by the driver could not be represented by the ColorSpace class (and\n+ * should probably be added).\n+ *\n+ * It is up to the pipeline handler or application to check if the\n+ * resulting color space is acceptable.\n+ */\n+\n /**\n * \\var V4L2DeviceFormat::planes\n * \\brief The per-plane memory size information\n@@ -871,6 +886,7 @@ int V4L2VideoDevice::getFormatMultiplane(V4L2DeviceFormat *format)\n \tformat->size.height = pix->height;\n \tformat->fourcc = V4L2PixelFormat(pix->pixelformat);\n \tformat->planesCount = pix->num_planes;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \tfor (unsigned int i = 0; i < format->planesCount; ++i) {\n \t\tformat->planes[i].bpl = pix->plane_fmt[i].bytesperline;\n@@ -892,6 +908,7 @@ int V4L2VideoDevice::trySetFormatMultiplane(V4L2DeviceFormat *format, bool set)\n \tpix->pixelformat = format->fourcc;\n \tpix->num_planes = format->planesCount;\n \tpix->field = V4L2_FIELD_NONE;\n+\tfromColorSpace(format->colorSpace, *pix);\n \n \tASSERT(pix->num_planes <= std::size(pix->plane_fmt));\n \n@@ -920,6 +937,7 @@ int V4L2VideoDevice::trySetFormatMultiplane(V4L2DeviceFormat *format, bool set)\n \t\tformat->planes[i].bpl = pix->plane_fmt[i].bytesperline;\n \t\tformat->planes[i].size = pix->plane_fmt[i].sizeimage;\n \t}\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n@@ -943,6 +961,7 @@ int V4L2VideoDevice::getFormatSingleplane(V4L2DeviceFormat *format)\n \tformat->planesCount = 1;\n \tformat->planes[0].bpl = pix->bytesperline;\n \tformat->planes[0].size = pix->sizeimage;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n@@ -959,6 +978,8 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n \tpix->pixelformat = format->fourcc;\n \tpix->bytesperline = format->planes[0].bpl;\n \tpix->field = V4L2_FIELD_NONE;\n+\tfromColorSpace(format->colorSpace, *pix);\n+\n \tret = ioctl(set ? VIDIOC_S_FMT : VIDIOC_TRY_FMT, &v4l2Format);\n \tif (ret) {\n \t\tLOG(V4L2, Error)\n@@ -977,6 +998,7 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n \tformat->planesCount = 1;\n \tformat->planes[0].bpl = pix->bytesperline;\n \tformat->planes[0].size = pix->sizeimage;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v12","4/8"]}