{"id":15094,"url":"https://patchwork.libcamera.org/api/1.1/patches/15094/?format=json","web_url":"https://patchwork.libcamera.org/patch/15094/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211209101245.6187-5-david.plowman@raspberrypi.com>","date":"2021-12-09T10:12:41","name":"[libcamera-devel,v10,4/8] libcamera: video_device: Support passing ColorSpaces to V4L2 video devices","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a88fac33579696da80083b403f8913f1b22d03c7","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15094/mbox/","series":[{"id":2830,"url":"https://patchwork.libcamera.org/api/1.1/series/2830/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2830","date":"2021-12-09T10:12:37","name":"Colour spaces","version":10,"mbox":"https://patchwork.libcamera.org/series/2830/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15094/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15094/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1F03BF415\n\tfor ;\n\tThu, 9 Dec 2021 10:13:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 722B360224;\n\tThu, 9 Dec 2021 11:13:37 +0100 (CET)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67B456089C\n\tfor ;\n\tThu, 9 Dec 2021 11:13:34 +0100 (CET)","by mail-wr1-x429.google.com with SMTP id d9so8774711wrw.4\n\tfor ;\n\tThu, 09 Dec 2021 02:13:34 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tj8sm5079449wrh.16.2021.12.09.02.13.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 09 Dec 2021 02:13:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"B+QFMR9h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dNFIU7MwMl9M/WUUAajbXcsy7xJkXDsMafgWJxChUOM=;\n\tb=B+QFMR9ha9JliZWZKB9D9qOhUCjgEkJPgTDWZhzHS8rYNls7PDHuURcuDH58rC5OY9\n\tcKJ765AaDunmaMGz4hIPkrqBUv+odyWgRj+fQThFfuVu7EwwS7EOQKgaCybrbkdsI8le\n\tX6w18HCbr+l3xaHIA0APMrZy4twLtCb+9Nqc4pE5jS4w4SBIp/RWEPWuT1qyJGbYg7uW\n\t21a0HB78wT1KPUyLu8qKnBnck/KpWTJ7oWFGoh7LpE7C8s3EMmaat/dyMHsLpTu3pajB\n\tTzzK/Tfw2d9AE2k1sexoOdXNTCJNkmkifLGToh7yIT4tqVvlKO8zJLSg7Yo7ey/eHT9Y\n\tEeMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dNFIU7MwMl9M/WUUAajbXcsy7xJkXDsMafgWJxChUOM=;\n\tb=5wWLgISvnSgnyst1L2k1i2fUmTmEGWKEFYU3DCzH/DktUanSoGANMLmeAkbwt6C0/E\n\t5MzFqZPO5EFqi61/xGi2c2evxZWEsN+gv0tMPW346Ko8uk8xmntdnMsi+WmC6jwNW+ct\n\t6ZBi2hRchziKBY0RcSZSWIF1R9ft4LuhNYqeHaL7bP4YZdnCRx2QZsdCsLva/XlqjtcL\n\tDFZ7roOyxNsP5tHC/mzKjDhiAlO3qMzIA5LGmFMooZ4ZDvru1w6bdZ2ar3UPjukxhXS2\n\tTkBZbqJVsjzhWRdBmVIi02KcnIlnlAdANFYxroyStaVEGXNtjoLVlkF2IYHzjrhJWM5k\n\tns6A==","X-Gm-Message-State":"AOAM531WdQWpw7LmPvpSp44j/kgR5RIfTY0U9QX0z7ttQAR695HUlvKZ\n\t13OECCAhRDuTq0s8DyaFbQ4N1+V0rmWQuZ+r","X-Google-Smtp-Source":"ABdhPJzB93t4z6/JgUppZUPICDZ6ml9dhvns0cutvX6zKncK+tmznVCpkF1hET2EwWaD0mVpX2rAaA==","X-Received":"by 2002:adf:fb4f:: with SMTP id\n\tc15mr5408424wrs.507.1639044813629; \n\tThu, 09 Dec 2021 02:13:33 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tHans Verkuil , Tomasz Figa , \n\tJacopo Mondi , Naushir Patuck ","Date":"Thu, 9 Dec 2021 10:12:41 +0000","Message-Id":"<20211209101245.6187-5-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211209101245.6187-1-david.plowman@raspberrypi.com>","References":"<20211209101245.6187-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v10 4/8] libcamera: video_device: Support\n\tpassing ColorSpaces to V4L2 video devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ColorSpace from the StreamConfiguration is now handled\nappropriately in the V4L2VideoDevice.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/v4l2_videodevice.h | 3 ++\n src/libcamera/v4l2_videodevice.cpp | 32 +++++++++++++++++++\n 2 files changed, 35 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 9b2ec3af..2d2ccc47 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -10,6 +10,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -21,6 +22,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n #include \n@@ -167,6 +169,7 @@ public:\n \n \tV4L2PixelFormat fourcc;\n \tSize size;\n+\tstd::optional colorSpace;\n \n \tstd::array planes;\n \tunsigned int planesCount = 0;\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex b4b89e27..80a8c8e4 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -383,6 +383,21 @@ bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer) const\n * that identifies the image format pixel encoding scheme.\n */\n \n+/**\n+ * \\var V4L2DeviceFormat::colorSpace\n+ * \\brief The color space of the pixels\n+ *\n+ * The color space of the image. When setting the format this may be\n+ * unset, in which case the driver gets to use its default color space.\n+ * After being set, this value should contain the color space that\n+ * was actually used. If this value is unset, then the color space chosen\n+ * by the driver could not be represented by the ColorSpace class (and\n+ * should probably be added).\n+ *\n+ * It is up to the pipeline handler or application to check if the\n+ * resulting color space is acceptable.\n+ */\n+\n /**\n * \\var V4L2DeviceFormat::planes\n * \\brief The per-plane memory size information\n@@ -871,6 +886,7 @@ int V4L2VideoDevice::getFormatMultiplane(V4L2DeviceFormat *format)\n \tformat->size.height = pix->height;\n \tformat->fourcc = V4L2PixelFormat(pix->pixelformat);\n \tformat->planesCount = pix->num_planes;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \tfor (unsigned int i = 0; i < format->planesCount; ++i) {\n \t\tformat->planes[i].bpl = pix->plane_fmt[i].bytesperline;\n@@ -893,6 +909,12 @@ int V4L2VideoDevice::trySetFormatMultiplane(V4L2DeviceFormat *format, bool set)\n \tpix->num_planes = format->planesCount;\n \tpix->field = V4L2_FIELD_NONE;\n \n+\tret = fromColorSpace(format->colorSpace, *pix);\n+\tif (ret < 0)\n+\t\tLOG(V4L2, Warning)\n+\t\t\t<< \"Setting color space unrecognised by V4L2: \"\n+\t\t\t<< ColorSpace::toString(format->colorSpace);\n+\n \tASSERT(pix->num_planes <= std::size(pix->plane_fmt));\n \n \tfor (unsigned int i = 0; i < pix->num_planes; ++i) {\n@@ -920,6 +942,7 @@ int V4L2VideoDevice::trySetFormatMultiplane(V4L2DeviceFormat *format, bool set)\n \t\tformat->planes[i].bpl = pix->plane_fmt[i].bytesperline;\n \t\tformat->planes[i].size = pix->plane_fmt[i].sizeimage;\n \t}\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n@@ -943,6 +966,7 @@ int V4L2VideoDevice::getFormatSingleplane(V4L2DeviceFormat *format)\n \tformat->planesCount = 1;\n \tformat->planes[0].bpl = pix->bytesperline;\n \tformat->planes[0].size = pix->sizeimage;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n@@ -959,6 +983,13 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n \tpix->pixelformat = format->fourcc;\n \tpix->bytesperline = format->planes[0].bpl;\n \tpix->field = V4L2_FIELD_NONE;\n+\n+\tret = fromColorSpace(format->colorSpace, *pix);\n+\tif (ret < 0)\n+\t\tLOG(V4L2, Warning)\n+\t\t\t<< \"Set color space unrecognised by V4L2: \"\n+\t\t\t<< ColorSpace::toString(format->colorSpace);\n+\n \tret = ioctl(set ? VIDIOC_S_FMT : VIDIOC_TRY_FMT, &v4l2Format);\n \tif (ret) {\n \t\tLOG(V4L2, Error)\n@@ -977,6 +1008,7 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n \tformat->planesCount = 1;\n \tformat->planes[0].bpl = pix->bytesperline;\n \tformat->planes[0].size = pix->sizeimage;\n+\tformat->colorSpace = toColorSpace(*pix);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v10","4/8"]}