{"id":15079,"url":"https://patchwork.libcamera.org/api/1.1/patches/15079/?format=json","web_url":"https://patchwork.libcamera.org/patch/15079/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211208123637.1332668-1-naush@raspberrypi.com>","date":"2021-12-08T12:36:36","name":"[libcamera-devel,v2,1/2] pipeline: raspberrypi: Reduce logging verbosity","commit_ref":"59644205705c3c96331479f9b6603fea90c87145","pull_url":null,"state":"accepted","archived":false,"hash":"a89fa3ac4ed355b9f2e9d29e398107edb4d372a7","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15079/mbox/","series":[{"id":2827,"url":"https://patchwork.libcamera.org/api/1.1/series/2827/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2827","date":"2021-12-08T12:36:36","name":"[libcamera-devel,v2,1/2] pipeline: raspberrypi: Reduce logging verbosity","version":2,"mbox":"https://patchwork.libcamera.org/series/2827/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15079/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15079/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFF47BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  8 Dec 2021 12:36:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8795760725;\n\tWed,  8 Dec 2021 13:36:42 +0100 (CET)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B64260225\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  8 Dec 2021 13:36:40 +0100 (CET)","by mail-wm1-x32a.google.com with SMTP id\n\tn33-20020a05600c502100b0032fb900951eso4045346wmr.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 Dec 2021 04:36:40 -0800 (PST)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:27d5:9305:f572:6623])\n\tby smtp.gmail.com with ESMTPSA id\n\tn15sm5830360wmq.38.2021.12.08.04.36.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Dec 2021 04:36:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rhz9i65O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=E7CLIrqrJiwLN/jNNgXj3Wp/tw22Abt5xww5XM+Lbw8=;\n\tb=rhz9i65OByFenARxe1wQwfOWeujFGKG8mFICqWeK173sCiOZoaIliw1VnkLwhiam4M\n\t9vUTPR5pZmXkI5rJzAvgn6IOfCI+DRVLiSI6K8qew1kxen+b9Ee4QUYfeB1Qd1sQnFWj\n\ttZt+rI5xU8dwRT6chmrNNPiHy1he8YV3SIm/FSTQhjPcp3x7uBOkIUCMGeBDmjpNG/9g\n\t77Xlt5tz9JYbCfW0yrNJHI6x7NYzr15+IYj2tC1t7kIT3n5YibdwUzwDngQ1EwQ1R3O/\n\tqzL6Y4PPUlWvu0Fk6lXs41VXL1wcgf1za5oKW5fZgDaL1OT5h0msPO/GEQTlxkgcmhYN\n\tAfaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=E7CLIrqrJiwLN/jNNgXj3Wp/tw22Abt5xww5XM+Lbw8=;\n\tb=UcH3kJY7bCTfpYyCAhfrEfh7yCPLQVFSZBd7kPPg1JbzAsQ7aIbTg66ZxIgbQo8U19\n\td/3o6U33DyzdMmsZ2PfYtwNR+uzqvi71oNEw+PmENFIJId4IELJzaAssyxiGsDX5b5gQ\n\tvLh7oLs17wy5XBPf61fkPC88XqHKrC14pQ5r3dWsg02yP2NuZbvH4qcqaSicSUPNGr3b\n\tCih43aD+q5LtNQMuain7iwtZsDjpXCoijjvDMsurLY8+poWME3Po1xykx+M1+ckCR9UB\n\tJCssd0MJW+OtYxbHVxqDSmXGCUwSsd0RhiR0eQuNL/WSv1Ry9+Po5SdphKaQNgHCZ3tr\n\tUoHA==","X-Gm-Message-State":"AOAM533uIec/fnBoiYjtetYFI3QAt3a4DZbjsVoSdPHHUZ+hl61pdeab\n\tWUTwrnJ/6UtViji5wp4ePshYMaW6cw2vtPZp","X-Google-Smtp-Source":"ABdhPJzTxBMCDMWrUqW9zR/5g9QqAPXNhhXiUDBVVhhBYTVutgXVv1fDwfdTBDTqzjZIcoPk1joGHg==","X-Received":"by 2002:a1c:a58d:: with SMTP id\n\to135mr15512978wme.93.1638967000008; \n\tWed, 08 Dec 2021 04:36:40 -0800 (PST)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  8 Dec 2021 12:36:36 +0000","Message-Id":"<20211208123637.1332668-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] pipeline: raspberrypi: Reduce\n\tlogging verbosity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Demote a couple of lines of logging to Debug level to reduce the verbosity of\nthe log output during startup.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 22c8ee6831d3..101aaea30743 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -161,10 +161,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n \t\t\t\tbestFormat.size = size;\n \t\t\t}\n \n-\t\t\tLOG(RPI, Info) << \"Format: \" << size.toString()\n-\t\t\t\t       << \" fmt \" << format.toString()\n-\t\t\t\t       << \" Score: \" << score\n-\t\t\t\t       << \" (best \" << bestScore << \")\";\n+\t\t\tLOG(RPI, Debug) << \"Format: \" << size.toString()\n+\t\t\t\t\t<< \" fmt \" << format.toString()\n+\t\t\t\t\t<< \" Score: \" << score\n+\t\t\t\t\t<< \" (best \" << bestScore << \")\";\n \t\t}\n \t}\n \n@@ -1746,8 +1746,8 @@ void RPiCameraData::checkRequestCompleted()\n \t\tstate_ = State::Idle;\n \t\tif (dropFrameCount_) {\n \t\t\tdropFrameCount_--;\n-\t\t\tLOG(RPI, Info) << \"Dropping frame at the request of the IPA (\"\n-\t\t\t\t       << dropFrameCount_ << \" left)\";\n+\t\t\tLOG(RPI, Debug) << \"Dropping frame at the request of the IPA (\"\n+\t\t\t\t\t<< dropFrameCount_ << \" left)\";\n \t\t}\n \t}\n }\n","prefixes":["libcamera-devel","v2","1/2"]}