{"id":15072,"url":"https://patchwork.libcamera.org/api/1.1/patches/15072/?format=json","web_url":"https://patchwork.libcamera.org/patch/15072/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211207224512.753979-7-djrscally@gmail.com>","date":"2021-12-07T22:45:09","name":"[libcamera-devel,v3,6/9] libcamera: ipa: Add lens control member to ipu3 ipa interface","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9587ac2496d8a1e758e9122900e4c0e86fd78703","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/1.1/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15072/mbox/","series":[{"id":2824,"url":"https://patchwork.libcamera.org/api/1.1/series/2824/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2824","date":"2021-12-07T22:45:03","name":"Enumerate CameraLens by following sensor's ancillary links","version":3,"mbox":"https://patchwork.libcamera.org/series/2824/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15072/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15072/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44FABBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  7 Dec 2021 22:45:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0DA06087A;\n\tTue,  7 Dec 2021 23:45:37 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E46906088C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  7 Dec 2021 23:45:32 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\tn33-20020a05600c502100b0032fb900951eso2869208wmr.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 07 Dec 2021 14:45:32 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ty12sm980332wrn.73.2021.12.07.14.45.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Dec 2021 14:45:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bfoj0YwT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=s1xucXj0FIt6M1+ekbMacUO71Tt4NG9sYWi0tjjPPQ4=;\n\tb=bfoj0YwT7POVSzK89JzHSh6qNi0Hi7iBqWh6HFVAeIF4T5bWEh22dI6RbC6sYk9eDZ\n\tdvEN09cu6m+Dn0lr3nZjl62Y9Vca2KNdSuhC2EXhqF5O/9zVy22CBE2SDz6UTD8ZV4d5\n\tOobN4BQmDp7Ag3qeytLhZkst70TFmucyxaSgtFaayaOCQ+kpDPcnZCVP1rV3V1poiW3b\n\td29YTpCGdOy6FUcDeNlCG7fLz+p+h/n7itekPgdmzpbEOoqv5sqyi2vhDU7sRLDNedOi\n\tLqwQ5+dNX0cWbUn1uFCNq1LIXfIDfQL+xnZavlXdwynWN8Sx/iV7jsFx+/DmmZHuEdxq\n\tvyQA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=s1xucXj0FIt6M1+ekbMacUO71Tt4NG9sYWi0tjjPPQ4=;\n\tb=IXOXA8BU8QE5hzrjeRU77qXi0p4BwTRqJPldaCjbCYsY95uEv1YT423CVT3RUzI0ya\n\tKEg65OFzPTXbIL1BT58IKz2suFxPrBcyNlBrxrUn09d88LdM9CVaq7ePd7obV7u+V/3B\n\t+os3QqTUisrps+yNNQJMiWkNeZ+LYRoUsUm1lN/LoCZLEoqlGW2d93Dwq5xXRZ5V7Hmf\n\tOeMV0tTFvGoKVQXEJlMsUt4glb8KX0FxKBV1Np37pdwxZU0wRvC+QkIP3gOLhuxj5H8p\n\tcbT1tHWxAYuOD5taZ/WbgLZflu3Yp/J3wTqbw1hBKSI5dVamhYe81Dk42xWk2O7O+lGp\n\tS4AQ==","X-Gm-Message-State":"AOAM530h9mJgGoNWkNVZfrcZ+lyROTPWqCeXw8Cvfnd6Eruk0TIIEs7+\n\twWoBwW2Qbm3xwEaiNQtikoiksVr4Bck=","X-Google-Smtp-Source":"ABdhPJyj3whJKuXmyCQJU1CHuHNhQ7g0HD4gdFCuBnRyBvpeSfaYc3vbYyzHy8gYE1TQ1KrLc+ylcw==","X-Received":"by 2002:a05:600c:4982:: with SMTP id\n\th2mr10687207wmp.4.1638917132733; \n\tTue, 07 Dec 2021 14:45:32 -0800 (PST)","From":"Daniel Scally <djrscally@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue,  7 Dec 2021 22:45:09 +0000","Message-Id":"<20211207224512.753979-7-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20211207224512.753979-1-djrscally@gmail.com>","References":"<20211207224512.753979-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 6/9] libcamera: ipa: Add lens control\n\tmember to ipu3 ipa interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add further members to the ipu3 ipa interface that will hold lens\ncontrols passed in by configInfo\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges in v3:\n\n\t- None\n\n include/libcamera/ipa/ipu3.mojom | 1 +\n src/ipa/ipu3/ipu3.cpp            | 3 +++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex cc0d822f..18cdc744 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -37,6 +37,7 @@ struct IPU3Action {\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n+\tlibcamera.ControlInfoMap lensControls;\n \tlibcamera.Size bdsOutputSize;\n \tlibcamera.Size iif;\n };\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b7b48d9a..3828650d 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -162,6 +162,7 @@ private:\n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\n \n \tControlInfoMap ctrls_;\n+\tControlInfoMap lensCtrls_;\n \n \tIPACameraSensorInfo sensorInfo_;\n \n@@ -422,6 +423,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \n \tsensorInfo_ = configInfo.sensorInfo;\n \n+\tlensCtrls_ = configInfo.lensControls;\n+\n \t/*\n \t * Compute the sensor V4L2 controls to be used by the algorithms and\n \t * to be set on the sensor.\n","prefixes":["libcamera-devel","v3","6/9"]}