{"id":15047,"url":"https://patchwork.libcamera.org/api/1.1/patches/15047/?format=json","web_url":"https://patchwork.libcamera.org/patch/15047/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211206105032.13876-7-david.plowman@raspberrypi.com>","date":"2021-12-06T10:50:29","name":"[libcamera-devel,v9,6/8] libcamera: Support passing ColorSpaces to V4L2 subdevices","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3af331aa059a54a00b09e4c2dfe80eb32d96d35d","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15047/mbox/","series":[{"id":2817,"url":"https://patchwork.libcamera.org/api/1.1/series/2817/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2817","date":"2021-12-06T10:50:23","name":"Colour spaces","version":9,"mbox":"https://patchwork.libcamera.org/series/2817/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15047/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15047/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7341C3259\n\tfor ;\n\tMon, 6 Dec 2021 10:51:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 973F2608A1;\n\tMon, 6 Dec 2021 11:51:28 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7D1260890\n\tfor ;\n\tMon, 6 Dec 2021 11:51:24 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\td72-20020a1c1d4b000000b00331140f3dc8so7291649wmd.1\n\tfor ;\n\tMon, 06 Dec 2021 02:51:24 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr7sm10878186wrq.29.2021.12.06.02.51.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Dec 2021 02:51:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OmnOPz7K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mbZZhCZgEn6YYtA3/51M6wXPUxmxfiWlFLNpGT7zY88=;\n\tb=OmnOPz7KK1PUrnlrkVkEGKE2DOb0pnrTc4hS4ZYKAk6g4gEPJvG2tmLRILvIfvaxcM\n\tdwyloi+e7jgTaUrmQvZMqFTxQVIAhIFlCT5drGSygg/r49OkDHlt8V0FBJZueBByAtnO\n\toDkPbaFY78wuUc04tm1pD2WtnWSLPenQIhtNrnabTrHfT9L0Ft2/ZXlzDIGVUcofgr1o\n\tEfSEjrdEzGiJAIDaUQS9G0CveokcimmFNWP4qIvuI6QQdaNwLazgqSeTqCTlfFvLy6dm\n\t2A6WCdbgw/aWaEVZwoEToYMgciIMTXZRQqWqDr0wt6KShWv33xenB8C50K2Z2c2OnxW5\n\tLJGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mbZZhCZgEn6YYtA3/51M6wXPUxmxfiWlFLNpGT7zY88=;\n\tb=Jn/pUKxmi3dv93WIlU0SGZMkeBtC0PvmDOxnh1aksw9aONY4niiRkgL4alnvNQRbRx\n\tbV+jnSgGPxPyL+i4sGBp8IcMH82fABoM3qcpfZJy0YJGcPPZgc2kJBW8VWWvEvkudvLQ\n\tpGG/DttRIH6j74Mm2DyvrES7WqvrqX9xBGPxJ1iT8wKX5KWVGdvUnNtTpl5OYC2LZOcs\n\t93H9d+Odj04ZxaTAKu+p3Z7Y2W4iY6NpT7GKVh+2yZFvsfTetz+r8HXQm6G6pYb3yVSj\n\tk+7j/9bu0aJeArCQ0ilrFo3h61SDGrzgQYiDSkAODaEa8rAjdmGOI1VcLEVa7glgOb8Z\n\tDz3g==","X-Gm-Message-State":"AOAM530ugX3SSC3PjbA2ST42hzTjALsAH4ZZAmX4LOtQiT0E+PSB6RB4\n\tdWmIfxZlmveoopIN3H0Gzer/H4BXHKbQAQM+","X-Google-Smtp-Source":"ABdhPJzwgttQ9pRArkqaJc+VFVWVn+2f+jVthpKcKwbdNM6RyefMwZ5f26zwtP5SAan7ts9JQecMbg==","X-Received":"by 2002:a7b:c109:: with SMTP id\n\tw9mr38978470wmi.114.1638787884430; \n\tMon, 06 Dec 2021 02:51:24 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org, naush@raspberrypi.com,\n\tjacopo@jmondi.org, tfiga@google.com, hverkuil-cisco@xs4all.nl,\n\tkieran.bingham@ideasonboard.com, laurent.pinchart@ideasonboard.com","Date":"Mon, 6 Dec 2021 10:50:29 +0000","Message-Id":"<20211206105032.13876-7-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20211206105032.13876-1-david.plowman@raspberrypi.com>","References":"<20211206105032.13876-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v9 6/8] libcamera: Support passing\n\tColorSpaces to V4L2 subdevices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ColorSpace from the StreamConfiguration is now handled\nappropriately in the V4L2Subdevice.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/v4l2_subdevice.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 981645e0..f5ec6901 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -411,6 +411,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n@@ -439,7 +440,13 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tsubdevFmt.format.code = format->mbus_code;\n \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n \n-\tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n+\tint ret = fromColorSpace(format->colorSpace, subdevFmt.format);\n+\tif (ret < 0)\n+\t\tLOG(V4L2, Warning)\n+\t\t\t<< \"Setting color space unrecognised by V4L2: \"\n+\t\t\t<< ColorSpace::toString(format->colorSpace);\n+\n+\tret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n \tif (ret) {\n \t\tLOG(V4L2, Error)\n \t\t\t<< \"Unable to set format on pad \" << pad\n@@ -450,6 +457,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v9","6/8"]}