{"id":15027,"url":"https://patchwork.libcamera.org/api/1.1/patches/15027/?format=json","web_url":"https://patchwork.libcamera.org/patch/15027/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203195539.1574621-6-hiroh@chromium.org>","date":"2021-12-03T19:55:37","name":"[libcamera-devel,5/7] ipa: raspberrypi: Contrast: Protect status_ access in Initialise()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e585e3bb6b9d907933b0af9430c0a7a35d9364d3","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15027/mbox/","series":[{"id":2814,"url":"https://patchwork.libcamera.org/api/1.1/series/2814/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2814","date":"2021-12-03T19:55:32","name":"Apply clang thread safety annotations to raspberrypi","version":1,"mbox":"https://patchwork.libcamera.org/series/2814/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15027/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15027/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBAB4BDB13\n\tfor ;\n\tFri, 3 Dec 2021 19:55:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DBCA6084A;\n\tFri, 3 Dec 2021 20:55:56 +0100 (CET)","from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A33260872\n\tfor ;\n\tFri, 3 Dec 2021 20:55:55 +0100 (CET)","by mail-pf1-x431.google.com with SMTP id o4so3816094pfp.13\n\tfor ;\n\tFri, 03 Dec 2021 11:55:55 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:cd78:3a5f:d792:6177])\n\tby smtp.gmail.com with ESMTPSA id\n\tt3sm4265891pfj.207.2021.12.03.11.55.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Dec 2021 11:55:53 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"gDgFNetY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OApDSpAVIwnWpGVH4gzTtwnVfskfBHadlfdPlNwphF8=;\n\tb=gDgFNetYNWjOObkkyh1LJggT46hGDvdQLM0dE01PXpq6e3Z0jrDm18Kxzv88r/WkVh\n\tenaDlS0Oj9is65WoblO3oavUx5eHUi/97LDK6GF4Riv90DEhKETA2Q6ahtsxWfmZEY+O\n\tTzh43St9z9JcadBjw5W0wkd9mBk2J7gT/lj/M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OApDSpAVIwnWpGVH4gzTtwnVfskfBHadlfdPlNwphF8=;\n\tb=R4XsFZQcGL0e48zSK1/f7YP3nIy+ltMyfmYrHfoyzvi65NL+JoFBOJLrvDHZs+reF/\n\tKPPlPr9W4dwpw+Mfk/EG6EcVgrJuAbKIMCGvHMtwW0RYEuvTPgpDsBhEGeAMcWtdbmGL\n\t+nuPUPlY50ddtiBHT9BY7w9THwV8Uj5ayfvdpEbkM4xl29Q3zCffglhRcTh7JAPvDVmH\n\tO2jcfPlgPhzsRIrQ09GKZ/rz5vzRoBvbbXYVmHqTbvMa6sCL7VXA5TZovK3XW8hTmcOH\n\ttW71jjJ/N55RuVkiMVBziBXTt1IGlpq4cDtCOzfp3eDmObb26Sq/ezJDZz2060d2iMCe\n\tMj6g==","X-Gm-Message-State":"AOAM533oRAhEZD3rLwD9EInZ+up/Xi/EE7YVG/+rhFtFb9Fld/LmMjxp\n\t7VJWV5rA4NLEqN/ksz/sYwt7apGhAkthKQ==","X-Google-Smtp-Source":"ABdhPJyTYtWZWmIiMXNmpfvgwUgH7D+3jauq3jq0nOZN069OPd2RDWdp7jJf4M7SoYuPTcvHBVb8DQ==","X-Received":"by 2002:a63:5906:: with SMTP id n6mr5936883pgb.563.1638561353637;\n\tFri, 03 Dec 2021 11:55:53 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Dec 2021 04:55:37 +0900","Message-Id":"<20211203195539.1574621-6-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.1.400.ga245620fadb-goog","In-Reply-To":"<20211203195539.1574621-1-hiroh@chromium.org>","References":"<20211203195539.1574621-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Contrast: Protect\n\tstatus_ access in Initialise()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This fixes the bug that status_ is accessed without acquiring\nmutex_ in Contrast::Initialise().\n\nSigned-off-by: Hirokazu Honda \n---\n src/ipa/raspberrypi/controller/rpi/contrast.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/contrast.cpp b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\nindex 6726b4e3..be61353a 100644\n--- a/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n@@ -83,6 +83,7 @@ void Contrast::Initialise()\n {\n \t// Fill in some default values as Prepare will run before Process gets\n \t// called.\n+\tMutexLocker locker(mutex_);\n \tfill_in_status(status_, brightness_, contrast_, config_.gamma_curve);\n }\n \n","prefixes":["libcamera-devel","5/7"]}