{"id":15025,"url":"https://patchwork.libcamera.org/api/1.1/patches/15025/?format=json","web_url":"https://patchwork.libcamera.org/patch/15025/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203195539.1574621-4-hiroh@chromium.org>","date":"2021-12-03T19:55:35","name":"[libcamera-devel,3/7] ipa: raspberrypi: awb: Apply clang thread annotation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"df5746e19f942d48defbab9ff45c0a71da8bfbbd","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15025/mbox/","series":[{"id":2814,"url":"https://patchwork.libcamera.org/api/1.1/series/2814/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2814","date":"2021-12-03T19:55:32","name":"Apply clang thread safety annotations to raspberrypi","version":1,"mbox":"https://patchwork.libcamera.org/series/2814/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15025/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15025/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 096AAC3250\n\tfor ;\n\tFri, 3 Dec 2021 19:55:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A768760822;\n\tFri, 3 Dec 2021 20:55:53 +0100 (CET)","from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com\n\t[IPv6:2607:f8b0:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F1FB6084A\n\tfor ;\n\tFri, 3 Dec 2021 20:55:52 +0100 (CET)","by mail-pg1-x52b.google.com with SMTP id f125so4176229pgc.0\n\tfor ;\n\tFri, 03 Dec 2021 11:55:52 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:cd78:3a5f:d792:6177])\n\tby smtp.gmail.com with ESMTPSA id\n\tt3sm4265891pfj.207.2021.12.03.11.55.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Dec 2021 11:55:50 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"KKVmjxnK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=whlrVtDSaOPOhU9NB9oN0LR43VRxqEnviBCM+Ekagoo=;\n\tb=KKVmjxnKvMb71EWA9M+P+TjtX5nDqB2ttT+DTMV7sXwiDHTa/0huKz4daRbJfgwTE3\n\tIo6vzxeodHsvcecj42Nmi3yBK5DABi1hbdD/MFQ1I2RJRlo9v105ZjrP9rJn0/rtiUOQ\n\tEtrTgHFH7v3TULr2CZ/kUf2blAVzNms6nASlg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=whlrVtDSaOPOhU9NB9oN0LR43VRxqEnviBCM+Ekagoo=;\n\tb=QBq1P2cYJ8raQACPlo0pWWzBT3BM5UgXReNYRZlKBXya5FIQZTKaHjRcQeCFRNs0CX\n\tEFpDFDFbmmVZwhH0BlCbbh/Er8mglsMHUQ7CXUgTWC05dcViPDDUjhT3s3UV8lLJABbL\n\tUcj5G+1kCDg8k6hC+tOdN/kL4iIkhDDO8yCPtros+iU2lSnAoZ2YQhEyTjy4fOqbUSHX\n\tWAO2cuBJb8q29jnCsvLbqcdquDspCoiyMzaqf+LLPCwqNC9joKnMRco/RGTShfz+nxO+\n\tsAE6PEKk+FLGv0sp4SM7p7QKdxLlohfiBLuh/WolpVby2LIAkk0NJkoMRFh9KXi8xkTm\n\tpsvA==","X-Gm-Message-State":"AOAM533HCSZm7a7xL8DvDnhkINRMs9JXvRgG+gZOEqD4yVdz9lzQJtu2\n\t027ZmR6a1EgVHWxu/zsZr78nOk56jb8q1A==","X-Google-Smtp-Source":"ABdhPJywWFpHimxRyk3QqrEwt2+XuGWSHfoalPY1iUF3bgYJUHq+YaWvEzFwpFbPQue2lEuCw77MgA==","X-Received":"by 2002:a05:6a00:1945:b0:44c:a955:35ea with SMTP id\n\ts5-20020a056a00194500b0044ca95535eamr20891648pfk.85.1638561350481; \n\tFri, 03 Dec 2021 11:55:50 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Dec 2021 04:55:35 +0900","Message-Id":"<20211203195539.1574621-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.1.400.ga245620fadb-goog","In-Reply-To":"<20211203195539.1574621-1-hiroh@chromium.org>","References":"<20211203195539.1574621-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/7] ipa: raspberrypi: awb: Apply clang\n\tthread annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This annotates member functions and variables of Awb by clang\nthread safety annotations.\n\nSigned-off-by: Hirokazu Honda \n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex b4e45abf..ac253d6b 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -318,7 +318,7 @@ void Awb::asyncFunc()\n \twhile (true) {\n \t\t{\n \t\t\tMutexLocker lock(mutex_);\n-\t\t\tasync_signal_.wait(lock, [&] {\n+\t\t\tasync_signal_.wait(lock, [&]() LIBCAMERA_TSA_REQUIRES(mutex_) {\n \t\t\t\treturn async_start_ || async_abort_;\n \t\t\t});\n \t\t\tasync_start_ = false;\ndiff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\nindex 30f39c4a..413e0439 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n@@ -114,11 +114,11 @@ private:\n \t// condvar for synchronous thread to wait on\n \tlibcamera::ConditionVariable sync_signal_;\n \t// for sync thread to check if async thread finished (requires mutex)\n-\tbool async_finished_;\n+\tbool async_finished_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \t// for async thread to check if it's been told to run (requires mutex)\n-\tbool async_start_;\n+\tbool async_start_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \t// for async thread to check if it's been told to quit (requires mutex)\n-\tbool async_abort_;\n+\tbool async_abort_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \n \t// The following are only for the synchronous thread to use:\n \t// for sync thread to note its has asked async thread to run\n@@ -133,7 +133,7 @@ private:\n \t// thread can set/reset them if the async thread is known to be idle:\n \tvoid restartAsync(StatisticsPtr &stats, double lux);\n \t// copy out the results from the async thread so that it can be restarted\n-\tvoid fetchAsyncResults();\n+\tvoid fetchAsyncResults() LIBCAMERA_TSA_REQUIRES(mutex_);\n \tStatisticsPtr statistics_;\n \tAwbMode *mode_;\n \tdouble lux_;\n","prefixes":["libcamera-devel","3/7"]}