{"id":15021,"url":"https://patchwork.libcamera.org/api/1.1/patches/15021/?format=json","web_url":"https://patchwork.libcamera.org/patch/15021/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","date":"2021-12-03T17:48:53","name":"[libcamera-devel,IPU3-IPA] libcamera-helpers: mapped_framebuffer: Update to new FD API","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2b655978e16c5c8256d704593bfbbbdce2eaf701","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15021/mbox/","series":[{"id":2813,"url":"https://patchwork.libcamera.org/api/1.1/series/2813/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2813","date":"2021-12-03T17:48:53","name":"[libcamera-devel,IPU3-IPA] libcamera-helpers: mapped_framebuffer: Update to new FD API","version":1,"mbox":"https://patchwork.libcamera.org/series/2813/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15021/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15021/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B859BF415\n\tfor ;\n\tFri, 3 Dec 2021 17:49:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 621CC60832;\n\tFri, 3 Dec 2021 18:48:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A25260725\n\tfor ;\n\tFri, 3 Dec 2021 18:48:57 +0100 (CET)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88255A59;\n\tFri, 3 Dec 2021 18:48:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IOPAoPFk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638553737;\n\tbh=dyq9cN1Tx1I7jO+hKqF9n4mUkOs7nGqbJ0WaBRFrUOk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=IOPAoPFkkWOSt9Ump5ATOvTKnNpfUrgLhWJR4SNsdwTzw5r92TSw0e6P6oLW8PdAD\n\tDtNc/LwG3Bkc4OaLhuM1jhdn3O7DC4bzZ9r1ufpVZ3ccJi/rXiErc1Rt8+wKfsvcb/\n\tc3Eo+A9syG7nnrdvUvZ2DaY4tr5bdob4kisBF/9Y=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 3 Dec 2021 17:48:53 +0000","Message-Id":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [IPU3-IPA PATCH] libcamera-helpers:\n\tmapped_framebuffer: Update to new FD API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The plane file descriptors API has been updated in the libcamera\nbase library.\n\nUpdate our mapped_framebuffer class accordingly.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera-helpers/mapped_framebuffer.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera-helpers/mapped_framebuffer.cpp b/src/libcamera-helpers/mapped_framebuffer.cpp\nindex a65740831331..3d231147ed91 100644\n--- a/src/libcamera-helpers/mapped_framebuffer.cpp\n+++ b/src/libcamera-helpers/mapped_framebuffer.cpp\n@@ -198,7 +198,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n \tstd::map mappedBuffers;\n \n \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n-\t\tconst int fd = plane.fd.fd();\n+\t\tconst int fd = plane.fd.get();\n \t\tif (mappedBuffers.find(fd) == mappedBuffers.end()) {\n \t\t\tconst size_t length = lseek(fd, 0, SEEK_END);\n \t\t\tmappedBuffers[fd] = MappedBufferInfo{ nullptr, 0, length };\n@@ -220,7 +220,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n \t}\n \n \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n-\t\tconst int fd = plane.fd.fd();\n+\t\tconst int fd = plane.fd.get();\n \t\tauto &info = mappedBuffers[fd];\n \t\tif (!info.address) {\n \t\t\tvoid *address = mmap(nullptr, info.mapLength, mmapFlags,\n","prefixes":["libcamera-devel","IPU3-IPA"]}