{"id":15007,"url":"https://patchwork.libcamera.org/api/1.1/patches/15007/?format=json","web_url":"https://patchwork.libcamera.org/patch/15007/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203094426.101454-6-hanlinchen@chromium.org>","date":"2021-12-03T09:44:26","name":"[libcamera-devel,v8,5/5] ipu3: ipa: Allow IPA to apply controls to the lens device","commit_ref":"3f881dbc338e8f24f478567ee890c1f36ccb8996","pull_url":null,"state":"accepted","archived":false,"hash":"16fe7cff4136bc9233af923d7c39cb97337bbd41","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/1.1/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15007/mbox/","series":[{"id":2807,"url":"https://patchwork.libcamera.org/api/1.1/series/2807/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2807","date":"2021-12-03T09:44:21","name":"Introduce Lens class and apply auto focus on ipu3","version":8,"mbox":"https://patchwork.libcamera.org/series/2807/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15007/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15007/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8344ABDB13\n\tfor ;\n\tFri, 3 Dec 2021 09:44:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C6EA6086C;\n\tFri, 3 Dec 2021 10:44:45 +0100 (CET)","from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48FD060822\n\tfor ;\n\tFri, 3 Dec 2021 10:44:44 +0100 (CET)","by mail-pj1-x1036.google.com with SMTP id\n\tp18-20020a17090ad31200b001a78bb52876so4708076pju.3\n\tfor ;\n\tFri, 03 Dec 2021 01:44:44 -0800 (PST)","from localhost ([2401:fa00:1:10:110e:45d1:2f92:6647])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\th26sm1859204pgm.68.2021.12.03.01.44.40\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 03 Dec 2021 01:44:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mSmkGJUF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MQRk4fRbBtHKsH9Fd/COcASc6Fveou2FbQmOKlzyNYs=;\n\tb=mSmkGJUFAovzhVsnB8dzWPoBnhnSxCgrMzEpaXfYjyBDNRVjGEWywy4um0HdUw4lKj\n\tzTkjI1SLfarfYJdEQMgWag0RfNZheVUkXsphlHarsI2C95Bg0ukDseJ2ktIbJlhjvkAe\n\ta4fMvJUMIMXhXDpKZe64O76kDcV3H2JtHUMyM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MQRk4fRbBtHKsH9Fd/COcASc6Fveou2FbQmOKlzyNYs=;\n\tb=hjkXs6SzPXhn25jZNSuvZlJCDmOeQu1XecDL4sI+kE8BhTQHaMK6GI1+Glh7ZSD/st\n\tm4Wz2ZxvnSifx37eZILLQOzP7pjas99TLqDpQi+h9k7y9RTAOb6X71wuYbUiUhkTIZNw\n\tH3nTLSctQSQ3bl5Ygg2046g4iXUxB0Rn39czOVCn16efEPpnHZyEd4W76yispmffNr3B\n\tCDMFLppOAZxlLE0iG4tZjS/8UtGLwWpxXDZhj/pCvrBf1VFtAlnSShSKyQtrjjX8/HL/\n\tAS2ePPZdykJ0BTCzFZ7gVZQrzO21vvaYPf47Q0rfnnahAlrn+WTC2tiUKAStrpKn6YZ1\n\tWqfA==","X-Gm-Message-State":"AOAM533lC/qDjKTk8ykZ+6uzq9usjx6HBA2xMGcGp2KfK5P6wsV+NGsc\n\tdE0IjV4CvymcxG8+JX/bMBb4cM8/46EQDQ==","X-Google-Smtp-Source":"ABdhPJxe13PBDr0AwGmQ5DhT+FL2ZUPrL1HNlVbmOJubgffuhS3+g6WpyGZa84jU6CCwvvJiTeP6Zg==","X-Received":"by 2002:a17:90b:17cd:: with SMTP id\n\tme13mr12864138pjb.79.1638524682307; \n\tFri, 03 Dec 2021 01:44:42 -0800 (PST)","From":"Han-Lin Chen ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Dec 2021 17:44:26 +0800","Message-Id":"<20211203094426.101454-6-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.34.0.384.gca35af8252-goog","In-Reply-To":"<20211203094426.101454-1-hanlinchen@chromium.org>","References":"<20211203094426.101454-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 5/5] ipu3: ipa: Allow IPA to apply\n\tcontrols to the lens device","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Allow IPA to apply controls to the lens device.\n\nSigned-off-by: Han-Lin Chen \nReviewed-by: Kieran Bingham \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex c65afdb2..1215bdb8 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -24,6 +24,7 @@\n #include \n \n #include \"libcamera/internal/camera.h\"\n+#include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n@@ -1238,8 +1239,16 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n {\n \tswitch (action.op) {\n \tcase ipa::ipu3::ActionSetSensorControls: {\n-\t\tconst ControlList &controls = action.sensorControls;\n-\t\tdelayedCtrls_->push(controls);\n+\t\tconst ControlList &sensorControls = action.sensorControls;\n+\t\tdelayedCtrls_->push(sensorControls);\n+\n+\t\tconst ControlList lensControls = action.lensControls;\n+\t\tconst ControlValue &focusValue =\n+\t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n+\n+\t\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n+\t\tif (focusLens && !focusValue.isNone())\n+\t\t\tfocusLens->setFocusPostion(focusValue.get());\n \t\tbreak;\n \t}\n \tcase ipa::ipu3::ActionParamFilled: {\n","prefixes":["libcamera-devel","v8","5/5"]}