{"id":15006,"url":"https://patchwork.libcamera.org/api/1.1/patches/15006/?format=json","web_url":"https://patchwork.libcamera.org/patch/15006/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203094426.101454-5-hanlinchen@chromium.org>","date":"2021-12-03T09:44:25","name":"[libcamera-devel,v8,4/5] libcamera: camera_lens: add CameraLens as a member of CameraSensor","commit_ref":"ad2bcbe5b55c8824288cd1752649f39f3a53af38","pull_url":null,"state":"accepted","archived":false,"hash":"309e4039ad8a2d51e7e9c1f14c376787daa01ec9","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/1.1/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15006/mbox/","series":[{"id":2807,"url":"https://patchwork.libcamera.org/api/1.1/series/2807/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2807","date":"2021-12-03T09:44:21","name":"Introduce Lens class and apply auto focus on ipu3","version":8,"mbox":"https://patchwork.libcamera.org/series/2807/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15006/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15006/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7B29BDB13\n\tfor ;\n\tFri, 3 Dec 2021 09:44:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93C8760832;\n\tFri, 3 Dec 2021 10:44:42 +0100 (CET)","from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n\t[IPv6:2607:f8b0:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25204607DE\n\tfor ;\n\tFri, 3 Dec 2021 10:44:41 +0100 (CET)","by mail-pl1-x636.google.com with SMTP id b13so1732809plg.2\n\tfor ;\n\tFri, 03 Dec 2021 01:44:41 -0800 (PST)","from localhost ([2401:fa00:1:10:110e:45d1:2f92:6647])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\ts8sm2474535pfe.196.2021.12.03.01.44.38\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 03 Dec 2021 01:44:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Qza/PZoc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=91+Ee9OsrtZPeC0t7KdR7vuUzPXFmVUxQdvdEkxOXGk=;\n\tb=Qza/PZocqcKFTpyh1xrbaCq25g8q9oT65ClGhdUCSJuSssgconsSHU+nt9CHknB09X\n\tWJbLWnSKiH0NaoqkJtVkt10L5ACfF4bFJdWpPHTXRNUGOna0SyRIDy4GIB2bjvBktM07\n\tF4yMTXkWJrih6PAb0BHaH/J0Nip4AaC3rlu+I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=91+Ee9OsrtZPeC0t7KdR7vuUzPXFmVUxQdvdEkxOXGk=;\n\tb=whYNb1QRydQL1FSN1kYlDm6yCdSJJf5tFOLN2KZ+NSO9TXUiOoOpocuXe13TDz41XY\n\tN9EOSR86GuC+Eg980HJvYsYV7E7EJSEGcokqj9BkL06NCN4FgBIo8OZxkN+sfhzduwI6\n\tze+xkZLpuyJZW5M76GL/zO1+mSQuN6I5mMWePIptLrx2b/v8HQkINOzRwxMmE4SBEHUr\n\tXt5REqmEJYjXQguJrodssnDHW/EYQ/Z8kDTbvv1o4DVLe/034YajufmxkYE80xX8emiY\n\tcoyEZZISpYdwnBouOWDUk4mfG01Iqgk/X3VMzXkDd9k/9XFA4o+kAUHjQoU+6/p4S2+/\n\txiLw==","X-Gm-Message-State":"AOAM532Rv2Jqz4cRvTgN4xxhxq7LANWVg7Yy4iSRQOy/Udk89FISeNT2\n\tYuZ4+nzJ72ikFCJEev5djyW7VNvXG9Bezg==","X-Google-Smtp-Source":"ABdhPJxC9699c1ZArpgV9JsOsxrxF7I5D81BPXdUofNiFU0++FYCNlbVzlQRf+Rm8klWVIRpF06YhA==","X-Received":"by 2002:a17:90a:df14:: with SMTP id\n\tgp20mr12803284pjb.186.1638524679606; \n\tFri, 03 Dec 2021 01:44:39 -0800 (PST)","From":"Han-Lin Chen ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Dec 2021 17:44:25 +0800","Message-Id":"<20211203094426.101454-5-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.34.0.384.gca35af8252-goog","In-Reply-To":"<20211203094426.101454-1-hanlinchen@chromium.org>","References":"<20211203094426.101454-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 4/5] libcamera: camera_lens: add\n\tCameraLens as a member of CameraSensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add CameraLens as a member of CameraSensor. The patch does not implement how\nto link the lens to the specific sensor yet. Only to provide an interface for\npipeline handler's usage.\n\nSigned-off-by: Han-Lin Chen \nReviewed-by: Kieran Bingham \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/camera_sensor.h | 5 +++++\n src/libcamera/camera_sensor.cpp | 9 +++++++++\n 2 files changed, 14 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 2facbf3c..788c2fa3 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -24,6 +24,7 @@\n namespace libcamera {\n \n class BayerFormat;\n+class CameraLens;\n class MediaEntity;\n \n class CameraSensor : protected Loggable\n@@ -60,6 +61,8 @@ public:\n \n \tvoid updateControlInfo();\n \n+\tCameraLens *focusLens() { return focusLens_.get(); }\n+\n protected:\n \tstd::string logPrefix() const override;\n \n@@ -91,6 +94,8 @@ private:\n \tconst BayerFormat *bayerFormat_;\n \n \tControlList properties_;\n+\n+\tstd::unique_ptr focusLens_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 6151b32e..c89d39e1 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -20,6 +20,7 @@\n #include \n \n #include \"libcamera/internal/bayer_format.h\"\n+#include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n #include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/sysfs.h\"\n@@ -787,6 +788,14 @@ void CameraSensor::updateControlInfo()\n \tsubdev_->updateControlInfo();\n }\n \n+/**\n+ * \\fn CameraSensor::focusLens_()\n+ * \\brief Retrieve the focus lens controller\n+ *\n+ * \\return The focus lens controller. nullptr if no focus lens controller is\n+ * connected to the sensor\n+ */\n+\n std::string CameraSensor::logPrefix() const\n {\n \treturn \"'\" + entity_->name() + \"'\";\n","prefixes":["libcamera-devel","v8","4/5"]}