{"id":14986,"url":"https://patchwork.libcamera.org/api/1.1/patches/14986/?format=json","web_url":"https://patchwork.libcamera.org/patch/14986/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211202132110.1067409-1-umang.jain@ideasonboard.com>","date":"2021-12-02T13:21:10","name":"[libcamera-devel,RFC] android: Do not cap those minFrameDuration nearabout 30fps","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6f3762bb54399894166152951dee878af48ea02b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14986/mbox/","series":[{"id":2802,"url":"https://patchwork.libcamera.org/api/1.1/series/2802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2802","date":"2021-12-02T13:21:10","name":"[libcamera-devel,RFC] android: Do not cap those minFrameDuration nearabout 30fps","version":1,"mbox":"https://patchwork.libcamera.org/series/2802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14986/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14986/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FB62BF415\n\tfor ;\n\tThu, 2 Dec 2021 13:21:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9232D60592;\n\tThu, 2 Dec 2021 14:21:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84EF26011A\n\tfor ;\n\tThu, 2 Dec 2021 14:21:20 +0100 (CET)","from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9651AD8C;\n\tThu, 2 Dec 2021 14:21:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HH6ZOP4N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638451280;\n\tbh=t9yQaDa9e7Svv2pYpWB6kI4AJSd1h0tG9EDAJv8+kHA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=HH6ZOP4N7wN8dhoSN7N9hpMzlYVNKjJNQ8uYqaFWaTgTTN8pU9fGiRfjdhA6IyvVO\n\tSsX6uH9NUlBLAOfV09wW7rODs91l0rqpG/IPPOnoqLHRTZAnLaFPfqOGtq1NN5mo4d\n\tqXAWuQGSix9BtPEO8BNK0oShDXvPhmcDsAjk06zE=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 2 Dec 2021 18:51:10 +0530","Message-Id":"<20211202132110.1067409-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH] android: Do not cap those\n\tminFrameDuration nearabout 30fps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We have some stream resolution which can provide slightly better\nframe duration than what we cap (i.e. 1/30 fps). The problem with\nthis is CTS complains if the camera goes faster during the test\nthan minFrameDuration reported for that stream. For instance,\n\n1080p minFrameDuration:\n\t- Nautilus : 33282000\n\t- Soraka : 33147000\n\nBoth are less than capped minFrameDuration (3333333).\n\nThis patch considers this situation and doesn't cap the\nminFrameDuration if the hardware can provide frame durations slightly\nbetter. The delta considered is 1% only from the cap.\n\nSigned-off-by: Umang Jain \n---\nOn LIMITED level - no regressions were found : 230/231 pass rate\n\nOn FULL level - this fixes the test:\nandroid.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n---\n src/android/camera_capabilities.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 3e566755..6421456a 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -810,8 +810,17 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\t * control to be specified for each Request. Defer this\n \t\t\t * to the in-development configuration API rework.\n \t\t\t */\n-\t\t\tif (minFrameDuration < 1e9 / 30.0)\n-\t\t\t\tminFrameDuration = 1e9 / 30.0;\n+\t\t\tint64_t capMinFrameDuration = 1e9 / 30.0;\n+\t\t\tif (minFrameDuration < capMinFrameDuration) {\n+\t\t\t\tfloat delta = (capMinFrameDuration - minFrameDuration) * 100 / capMinFrameDuration;\n+\n+\t\t\t\t/*\n+\t\t\t\t * If the delta is less than 1%, do not cap the\n+\t\t\t\t * frame duration.\n+\t\t\t\t */\n+\t\t\t\tif (delta > 0.01)\n+\t\t\t\t\tminFrameDuration = capMinFrameDuration;\n+\t\t\t}\n \n \t\t\tstreamConfigurations_.push_back({\n \t\t\t\tres, androidFormat, minFrameDuration, maxFrameDuration,\n","prefixes":["libcamera-devel","RFC"]}