{"id":14984,"url":"https://patchwork.libcamera.org/api/1.1/patches/14984/?format=json","web_url":"https://patchwork.libcamera.org/patch/14984/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211201201548.2023225-1-raj.khem@gmail.com>","date":"2021-12-01T20:15:48","name":"[libcamera-devel,v2] backtrace: Include cxxabi.h without HAVE_DW","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"40fbaf2a6b8472ee0f4f413487fe1bdcd35789bb","submitter":{"id":62,"url":"https://patchwork.libcamera.org/api/1.1/people/62/?format=json","name":"Khem Raj","email":"raj.khem@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14984/mbox/","series":[{"id":2800,"url":"https://patchwork.libcamera.org/api/1.1/series/2800/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2800","date":"2021-12-01T20:15:48","name":"[libcamera-devel,v2] backtrace: Include cxxabi.h without HAVE_DW","version":2,"mbox":"https://patchwork.libcamera.org/series/2800/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14984/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14984/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 126C2BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  1 Dec 2021 20:15:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C857E60822;\n\tWed,  1 Dec 2021 21:15:54 +0100 (CET)","from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com\n\t[IPv6:2607:f8b0:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 778D5607DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  1 Dec 2021 21:15:53 +0100 (CET)","by mail-pl1-x62a.google.com with SMTP id z6so18584556plk.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 01 Dec 2021 12:15:53 -0800 (PST)","from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::ce68])\n\tby smtp.gmail.com with ESMTPSA id\n\t66sm449822pgg.63.2021.12.01.12.15.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Dec 2021 12:15:50 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YQcRWd28\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=cE1vm2CFjn+Kghm8OVlr501+csj7p2wEwNyWyemkUxg=;\n\tb=YQcRWd28sSt5k6oDLTi1GBkEaPAODimmfDAGmsBtKXYkwtpONGc3RskCoRZCwY4fjs\n\t0LFq5hFz7yImzJz+jZVb/8eSs4zwNsuLvLYJeWRiHY5ESgIMOeJDB0+vsPxC+R0f18pU\n\tSh9n314b5+GflDZyOaWqHZnBABKos+gKZPE146U5MKnIoapSIsTMxZNkRAZ62x8ix5h/\n\t3MgrkwvYdtWqiHYuEkenEM4f22A1QhPsq5TqeMhLLeckejsS8cix1+Ghv+wXaY6wJm+/\n\th6OTXB7yvKLEYYsK7/+KWWm7c6os8HlFvYNJYJfD3innUZI1RmpmeKbpQtmDsrmDjOFA\n\tV41w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=cE1vm2CFjn+Kghm8OVlr501+csj7p2wEwNyWyemkUxg=;\n\tb=qAXoEqJooWBcyLdWt9P6avNfyr84Fu4C6lPf7IY0bJ5Q5B0xwHmqV9jiIDCxvVLg7M\n\tYQzortedIXcaAXmDaCQs+JsGdvMWbI2VDrb1OcHG0EDTxwze0zpjIAK3J8zMGrA1W9ln\n\tV+rMXYlgy+8rvqyBFXVAfCfGduzQzO3ULAnGxj8Wurg/jfjHgGoH62Y4VOOa6ZooptIo\n\taSL8NqncrIcB0n8Ic0uB0X8CTBHXOocfCC8lGVWZfbQdN7pJMziZM84sxvNHlfJcuLwv\n\t12i+N+HT8lZMYxtQI8uxbo7H6JZ6CmdYwsoT9pqOk4ika+qMskbZaowH7OUIflTNbcdu\n\t9j0g==","X-Gm-Message-State":"AOAM533y9k4xlWgTwoXw/U7XMku8DRN0tl2nt3+K/6t8Nu2765M/H4cv\n\tsmKCDgrkIJwXzAQOKTEe+y9KmmGUif/XxQ==","X-Google-Smtp-Source":"ABdhPJyoWvzCvCcreo0rFQlbZpw8SY6XNe2b7Y7todmF0cS+ltwdw3lMzwnLSTG/JK2AXJZb+LmCYw==","X-Received":"by 2002:a17:902:ecca:b0:141:e920:3b71 with SMTP id\n\ta10-20020a170902ecca00b00141e9203b71mr10065598plh.10.1638389751478; \n\tWed, 01 Dec 2021 12:15:51 -0800 (PST)","From":"Khem Raj <raj.khem@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  1 Dec 2021 12:15:48 -0800","Message-Id":"<20211201201548.2023225-1-raj.khem@gmail.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h without\n\tHAVE_DW","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Since its used in code without HAVE_DW, it fails to compile on such\nsystems e.g. linux/musl\n\nFixes\nsrc/libcamera/base/backtrace.cpp:235:16: error: use of undeclared identifier 'abi'\n                char *name = abi::__cxa_demangle(symbol, nullptr, nullptr, nullptr);\n                             ^\n1 error generated.\n\nSigned-off-by: Khem Raj <raj.khem@gmail.com>\n---\nv2: Fix typo in subject\n\n src/libcamera/base/backtrace.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp\nindex d93e5518..42c60f7c 100644\n--- a/src/libcamera/base/backtrace.cpp\n+++ b/src/libcamera/base/backtrace.cpp\n@@ -13,11 +13,12 @@\n #endif\n \n #ifdef HAVE_DW\n-#include <cxxabi.h>\n #include <elfutils/libdwfl.h>\n #include <unistd.h>\n #endif\n \n+#include <cxxabi.h>\n+\n #if HAVE_UNWIND\n /*\n  * Disable support for remote unwinding to enable a more optimized\n","prefixes":["libcamera-devel","v2"]}